From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Lars Ingebrigtsen Newsgroups: gmane.emacs.bugs Subject: bug#57532: Restructure mailcap-add-mailcap-entry to improve readability Date: Fri, 02 Sep 2022 12:09:35 +0200 Message-ID: <87tu5qxf34.fsf@gnus.org> References: <878rn2rd22.fsf@sperrhaken.name> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="18532"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/29.0.50 (gnu/linux) Cc: 57532@debbugs.gnu.org To: Felix Dietrich Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Fri Sep 02 12:10:14 2022 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1oU3cr-0004e4-GB for geb-bug-gnu-emacs@m.gmane-mx.org; Fri, 02 Sep 2022 12:10:13 +0200 Original-Received: from localhost ([::1]:43428 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1oU3cq-00050u-A7 for geb-bug-gnu-emacs@m.gmane-mx.org; Fri, 02 Sep 2022 06:10:12 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:44590) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1oU3cg-0004zD-11 for bug-gnu-emacs@gnu.org; Fri, 02 Sep 2022 06:10:02 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:55167) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1oU3cf-0006oy-OC for bug-gnu-emacs@gnu.org; Fri, 02 Sep 2022 06:10:01 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1oU3cf-0004ut-Hz for bug-gnu-emacs@gnu.org; Fri, 02 Sep 2022 06:10:01 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Lars Ingebrigtsen Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Fri, 02 Sep 2022 10:10:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 57532 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 57532-submit@debbugs.gnu.org id=B57532.166211338718861 (code B ref 57532); Fri, 02 Sep 2022 10:10:01 +0000 Original-Received: (at 57532) by debbugs.gnu.org; 2 Sep 2022 10:09:47 +0000 Original-Received: from localhost ([127.0.0.1]:44913 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oU3cQ-0004u9-OJ for submit@debbugs.gnu.org; Fri, 02 Sep 2022 06:09:46 -0400 Original-Received: from quimby.gnus.org ([95.216.78.240]:33726) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oU3cP-0004tr-0l for 57532@debbugs.gnu.org; Fri, 02 Sep 2022 06:09:45 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnus.org; s=20200322; h=Content-Transfer-Encoding:Content-Type:MIME-Version:Message-ID :Date:References:In-Reply-To:Subject:Cc:To:From:Sender:Reply-To:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=Y/WPfRznSyO4k6+TpN/0yL1/qORLHBunUuE489udWIE=; b=Fm7Gb7/Cog/d2CcT1yUN1skwlq J3NJHSxis6VcHseRSq8pUosMTLZ0s7sfDzwil88gs8OL3gE2TyposejFBdsoePVlbgzSeqy0raI9k ByGWEtL6Tm4INbz+pLF07tG2IOc1T4lRaC5PPMJq6sAYrTrDAjKC8WivYCP8kyOkLsQE=; Original-Received: from [84.212.220.105] (helo=joga) by quimby.gnus.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1oU3cF-0004QL-VX; Fri, 02 Sep 2022 12:09:38 +0200 In-Reply-To: <878rn2rd22.fsf@sperrhaken.name> (Felix Dietrich's message of "Thu, 01 Sep 2022 23:37:41 +0200") Face: iVBORw0KGgoAAAANSUhEUgAAADAAAAAwAgMAAAAqbBEUAAAABGdBTUEAALGPC/xhBQAAACBj SFJNAAB6JgAAgIQAAPoAAACA6AAAdTAAAOpgAAA6mAAAF3CculE8AAAACVBMVEWQoMNWapj///9v UaI7AAAAAWJLR0QCZgt8ZAAAAAlwSFlzAAAASAAAAEgARslrPgAAAAd0SU1FB+YJAgoJGRPubpoA AAEKSURBVCjPTVExrsUwCAOp7P1SuA8ZuhMJ7n+Vb0jbV5QhDsGxHSLUQZ/6Ahvfzhdw/vZnZsa9 n5FVxlefaAH6EycZ3p09TaGJno1VBzjW6nBQHg0wzLynN/cgnR+Qp2DbZEpBAM5bgBedsfstCBx8 POqkCPwVLp7LlN6bLmm3JUh4LQ4Gx0PBjmOTnRPH4TSvblyEedoG2UEGSUlGMy1yksDpyTYc10hm 0pZRD/Yq/uxosF1BFLc5yYOmbQDSnLkK/NHa6WzFydebLqjRkwYTQsuLQ28Z0qsihHZenfvqZ8TI 6uNCFnkgXmSbljHLUr/DFfxZ/rq8/efzJTygLXQDDX2upSo+aeWv/gEXYlaaEPm6RQAAAFplWElm TU0AKgAAAAgABQESAAMAAAABAAEAAAEaAAUAAAABAAAASgEbAAUAAAABAAAAUgEoAAMAAAABAAEA AAITAAMAAAABAAEAAAAAAAAAAABIAAAAAQAAAEgAAAABlIHJLQAAACV0RVh0ZGF0ZTpjcmVhdGUA MjAyMi0wOS0wMlQxMDowOToyNCswMDowMKxf/h4AAAAldEVYdGRhdGU6bW9kaWZ5ADIwMjItMDkt MDJUMTA6MDk6MjQrMDA6MDDdAkaiAAAAF3RFWHRleGlmOllDYkNyUG9zaXRpb25pbmcAMawPgGMA AAAASUVORK5CYII= X-Now-Playing: Satomimagae's _KEM_: "Fumi (KEM Version)" X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:241303 Archived-At: Felix Dietrich writes: > =E2=80=98mailcap-add-mailcap-entry=E2=80=99 is written in a way that make= s it hard to > follow. My patch aims to improve its readability. In order to show > that my modification retains the original functionality, another Patch > adds ERT test cases for this function. The new version also shows > clearer an issue with the current implementation that causes some > mailcap entries to be forgotten; this is mentioned in a comment. A > docstring for the function is added as well. Thanks; pushed to Emacs 29.