From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Lars Ingebrigtsen Newsgroups: gmane.emacs.devel Subject: Re: "Eager macro-expansion failure: (excessive-variable-binding)" Date: Wed, 14 Sep 2022 17:38:00 +0200 Message-ID: <87tu5a55lz.fsf@gnus.org> References: <87o7vib140.fsf@gnus.org> <87czby6l8q.fsf@gnus.org> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="31204"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/29.0.50 (gnu/linux) Cc: "Emacs-devel@gnu.org" To: Mattias =?utf-8?Q?Engdeg=C3=A5rd?= Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Wed Sep 14 17:39:21 2022 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1oYUTw-0007w0-TA for ged-emacs-devel@m.gmane-mx.org; Wed, 14 Sep 2022 17:39:21 +0200 Original-Received: from localhost ([::1]:32772 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1oYUTv-0000xg-PM for ged-emacs-devel@m.gmane-mx.org; Wed, 14 Sep 2022 11:39:19 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:45822) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1oYUSm-000095-LN for Emacs-devel@gnu.org; Wed, 14 Sep 2022 11:38:08 -0400 Original-Received: from quimby.gnus.org ([2a01:4f9:2b:f0f::2]:40696) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1oYUSk-0007qm-Sw for Emacs-devel@gnu.org; Wed, 14 Sep 2022 11:38:08 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnus.org; s=20200322; h=Content-Type:MIME-Version:Message-ID:Date:References: In-Reply-To:Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=YuYf9oNl6zsibOetqy3tPvhKNL9a4XO6tAkbvTwpPo0=; b=D5w14ZCg+/xE+B9p5P2qdfZXCG KLM/lGqE60c6UzDmTVA2DBVugPYx2ag444v+u9fjYIQiyCjoeiSOr2LYZgMWoOdggTKPQytY9//m3 wCZR0yW44cQxtYz3C2YGGXui8IgHoeLsWXNJ7GtS/DO4l7TaD8o03NFUG0Eu5Lo8hHkI=; Original-Received: from [84.212.220.105] (helo=joga) by quimby.gnus.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1oYUSf-0007w7-68; Wed, 14 Sep 2022 17:38:03 +0200 In-Reply-To: <87czby6l8q.fsf@gnus.org> (Lars Ingebrigtsen's message of "Wed, 14 Sep 2022 17:15:01 +0200") Face: iVBORw0KGgoAAAANSUhEUgAAADAAAAAwBAMAAAClLOS0AAAABGdBTUEAALGPC/xhBQAAACBj SFJNAAB6JgAAgIQAAPoAAACA6AAAdTAAAOpgAAA6mAAAF3CculE8AAAAIVBMVEX+/v7bz9piLFp4 SHKTaI+VapGxjq3FqMKCU3xHDj3///8aSON9AAAAAWJLR0QKaND0VgAAAAd0SU1FB+YJDg8kNDoG FVMAAAGdSURBVDjL7ZIxc5wwEIUv/8Cd+1U8c7Ra3Q1p0epC2rDLUNtoSRkXgT7ceVyTin8bnQ3E tSsXeeV+896bp9Fu9y59MtY4xMqdNGrs+hz55hXM85TNc4C71p1iW2YTbgDmCfYjPphuLBBMWIDJ AC8WrEEcESwYWcABi5OdAQwAOLZTTguY/tzPczbjHSbsioQXkM0ZmG+X+6/PUeDgjYF/5RM8Db9U hz7EAtGuUWCnw6Aa64gaK9iA2Obp8aGLP86MTCPYLz9fAdn9bZN12gbNmfzvN1GmmKDruR5QRYpy XQ5XmUE5fK+OwhZWkBZbU/d1y9QeIxOtA/PrvRm0l7qtVYjKFdi8rvJeB4leksgvAD9rhdcOidML WB0u3e2+Z3tJIITAq0OrVC8V0uggGcqwOHaVsRiUy9Rqg7Dfnt0acCKNJ4m5XMm2w8JZhCsSPnrv yNsNuCASMLUSlvi8ATCUAsQHLkukM9G4OvIUQtKkt8g9loRrR7onA9ccJFnQ+TcgSOBA58BoAM8L 2Onwor4bul5V666/ed9n/6+Po78SGJiKwWM9PAAAACV0RVh0ZGF0ZTpjcmVhdGUAMjAyMi0wOS0x NFQxNTozNjo1MiswMDowMGS77gUAAAAldEVYdGRhdGU6bW9kaWZ5ADIwMjItMDktMTRUMTU6MzY6 NTIrMDA6MDAV5la5AAAAAElFTkSuQmCC X-Now-Playing: Don Cherry's New Researches featuring =?utf-8?Q?Nan=C3=A1?= Vasconcelos's _Organic Music Theatre Festival de Chateauvallon 1972 (2)_: "Interlude-North Brazilian Ceremonial Hymn" Received-SPF: pass client-ip=2a01:4f9:2b:f0f::2; envelope-from=larsi@gnus.org; helo=quimby.gnus.org X-Spam_score_int: -43 X-Spam_score: -4.4 X-Spam_bar: ---- X-Spam_report: (-4.4 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_MED=-2.3, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.io gmane.emacs.devel:295330 Archived-At: Lars Ingebrigtsen writes: > Hm... yes, it seems like this (or something else recently) increased > the "make -j32" build time from 1:08m to 1:17m, which is pretty > significant. I'm doing further rebuilds to see if that's indeed the > culprit. Yes, but via ldefs-boot.el which was done a bit later. The following patch brings build times back down to 1:08s. diff --git a/lisp/ldefs-boot.el b/lisp/ldefs-boot.el index 909ecf773c..fd2c68b98d 100644 --- a/lisp/ldefs-boot.el +++ b/lisp/ldefs-boot.el @@ -33564,7 +33564,7 @@ "vc-filewise" this list might be extended in the future. (fn SWITCHES)") -(put 'vc-git-annotate-switches 'safe-local-variable #'vc-git-annotate-switches-safe-p) +(put 'vc-git-annotate-switches 'safe-local-variable (lambda (switches) (equal switches "-w"))) (defun vc-git-registered (file) "Return non-nil if FILE is registered with git." (if (vc-find-root file ".git") ; Short cut. diff --git a/lisp/vc/vc-git.el b/lisp/vc/vc-git.el index 8d8ea33f8b..0764282676 100644 --- a/lisp/vc/vc-git.el +++ b/lisp/vc/vc-git.el @@ -135,7 +135,7 @@ vc-git-annotate-switches (string :tag "Argument String") (repeat :tag "Argument List" :value ("") string)) :version "25.1") -;;;###autoload(put 'vc-git-annotate-switches 'safe-local-variable #'vc-git-annotate-switches-safe-p) +;;;###autoload(put 'vc-git-annotate-switches 'safe-local-variable (lambda (switches) (equal switches "-w"))) (defcustom vc-git-log-switches nil "String or list of strings specifying switches for Git log under VC."