From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Sean Whitton Newsgroups: gmane.emacs.devel Subject: Re: master 6a2ee981c3: Add new functions for splitting the root window Date: Wed, 14 Sep 2022 09:52:26 -0700 Message-ID: <87tu59ucdx.fsf@melete.silentflame.com> References: <166240424802.11417.12502552895310232639@vcs2.savannah.gnu.org> <20220905185728.838CEC0088A@vcs2.savannah.gnu.org> <86h71kseiw.fsf@mail.linkov.net> <87illzmjew.fsf@gnus.org> <868rmvxdvj.fsf@mail.linkov.net> <87bkrq5bmb.fsf@gnus.org> <87pmg69ifi.fsf@gmail.com> <87h71i3vr3.fsf@gnus.org> <864jxfghcf.fsf@mail.linkov.net> <87sfkygokp.fsf@gnus.org> <87r10hg5u7.fsf@melete.silentflame.com> <86pmg0v6my.fsf@mail.linkov.net> <87a674beup.fsf@melete.silentflame.com> <86v8psqtj7.fsf@mail.linkov.net> <87edwfe5lg.fsf@melete.silentflame.com> <864jxbw2k7.fsf@mail.linkov.net> <87o7vidiu3.fsf@melete.silentflame.com> <86r10ev44h.fsf@mail.linkov.net> Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="=-=-=" Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="7830"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/29.0.50 (gnu/linux) Cc: Lars Ingebrigtsen , emacs-devel@gnu.org To: Juri Linkov Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Wed Sep 14 19:32:35 2022 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1oYWFX-0001tC-Nz for ged-emacs-devel@m.gmane-mx.org; Wed, 14 Sep 2022 19:32:35 +0200 Original-Received: from localhost ([::1]:44918 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1oYWFW-0006Ft-L5 for ged-emacs-devel@m.gmane-mx.org; Wed, 14 Sep 2022 13:32:34 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:33736) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1oYVcn-0006Y4-U8 for emacs-devel@gnu.org; Wed, 14 Sep 2022 12:52:34 -0400 Original-Received: from out3-smtp.messagingengine.com ([66.111.4.27]:34241) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1oYVcm-0002l8-1f for emacs-devel@gnu.org; Wed, 14 Sep 2022 12:52:33 -0400 Original-Received: from compute4.internal (compute4.nyi.internal [10.202.2.44]) by mailout.nyi.internal (Postfix) with ESMTP id B5B225C007E; Wed, 14 Sep 2022 12:52:27 -0400 (EDT) Original-Received: from mailfrontend2 ([10.202.2.163]) by compute4.internal (MEProxy); Wed, 14 Sep 2022 12:52:27 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=spwhitton.name; h=cc:cc:content-type:date:date:from:from:in-reply-to :in-reply-to:message-id:mime-version:references:reply-to:sender :subject:subject:to:to; s=fm1; t=1663174347; x=1663260747; bh=6X aXwYGmEaJXPDq/+9RmpLiO9e5Unn/qK8urRXlnELA=; b=1RgEg4OhU0xhpl0Ff4 YC3HytkF6BWLFgAIYFMh7Vmi2Fe5H642IYk42BC/bIbAfrIxLOiwLdz3JI0TwhXl gMpR/WFv5wsXAHC4DD+YK9Ff6GP/9i2RrWh/EadLJwr2Wn+3Ti7GZ0IxIH1hsHa1 aMhgHyH7HyRCbP5TzD0DwQogSq/ICLZuujqWXBsczwopGDpyKEfYxnKzsazgisak O3DuvgqPFyhzYMp2QG1u8nJzt38t04Ah7qs3wP85Y4XkfaHuw8QJvKzEe8Fs9wda +o9EdAe4xurYrBU7TdYPwXPr8UBGFhud4x2hHUFIAWVCr795bW89tFayuV/pB+Nr eUgA== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-type:date:date:feedback-id :feedback-id:from:from:in-reply-to:in-reply-to:message-id :mime-version:references:reply-to:sender:subject:subject:to:to :x-me-proxy:x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s= fm2; t=1663174347; x=1663260747; bh=6XaXwYGmEaJXPDq/+9RmpLiO9e5U nn/qK8urRXlnELA=; b=PxLpAdgEm0/pPsrAp8aQTHzWY7BxnRj/X4xsTqYMjkXW P7DJR9eBFUmM+jpzR+gUQXweqcZputSMiwi6uF0HXRyiEwuqcRYNpMYog0FwsAqe IZ2EM4uSAlm1xz17iFwUyjDP2GNP9veo4luwgUS8rlqTjOv7hiktDNrUaKHzT/Wz 0yl6Zale8zqguF44ku11ys8UPS4KNtcM+PWIY/elek2Tps8jRS4evbo8KqQoCQpp gPkcDDUEJfY+vTPf7wUUPAqF3akBmHJ+VMAMRuPbpF2HuM6XwruqjN6J1H6NuEA3 0G+7bI2dgCyZCVgNAnmY7DwekfCdKd0NZlcww1ViGw== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvfedrfeduiedguddtlecutefuodetggdotefrod ftvfcurfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfgh necuuegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmd enucfjughrpefhvfevufgjfhffkfgfgggtsehmtddtredtredtnecuhfhrohhmpefuvggr nhcuhghhihhtthhonhcuoehsphifhhhithhtohhnsehsphifhhhithhtohhnrdhnrghmvg eqnecuggftrfgrthhtvghrnhepffevuefhleduhfefgeejfeehhfefledujeeuheefvedt hffhteettdefleeltedunecuvehluhhsthgvrhfuihiivgeptdenucfrrghrrghmpehmrg hilhhfrhhomhepshhpfihhihhtthhonhesshhpfihhihhtthhonhdrnhgrmhgv X-ME-Proxy: Feedback-ID: i23c04076:Fastmail Original-Received: by mail.messagingengine.com (Postfix) with ESMTPA; Wed, 14 Sep 2022 12:52:27 -0400 (EDT) Original-Received: by melete.silentflame.com (Postfix, from userid 1000) id 7FF297E8DEA; Wed, 14 Sep 2022 09:52:26 -0700 (MST) In-Reply-To: <86r10ev44h.fsf@mail.linkov.net> (Juri Linkov's message of "Wed, 14 Sep 2022 09:53:18 +0300") Received-SPF: pass client-ip=66.111.4.27; envelope-from=spwhitton@spwhitton.name; helo=out3-smtp.messagingengine.com X-Spam_score_int: -27 X-Spam_score: -2.8 X-Spam_bar: -- X-Spam_report: (-2.8 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_LOW=-0.7, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.io gmane.emacs.devel:295344 Archived-At: --=-=-= Content-Type: text/plain Hello, On Wed 14 Sep 2022 at 09:53AM +03, Juri Linkov wrote: >>> - tear-off-window - C-x w ^ - detach window to a new frame >>> - tab-window-detach - C-x t ^ w - detach window to a new tab >>> - tab-detach - C-x t ^ f - detach tab to a new frame >> >> My own intuition is that C-x t is for operations *on* tabs, and C-x w >> for operations *on* windows, so what do you (and others) think about: >> >> C-x w ^ f -- tear-off-window >> C-x w ^ t -- tab-window-detach >> C-x t ^ -- tab-detach > > Nice, these keys also have transitional semantics: > > w ^ f - from window to frame > w ^ t - from window to tab Indeed! > So for consistency tab-detach also could be: > > t ^ f - from tab to frame > > if another key also makes sense: > > t ^ w - from tab to window Do you think it does? Or perhaps we should do it anyway in case we later want to put another detach command under the submap -- perhaps we'll want C-x t ^ F for some variant on tab-detach, since '^' can't be capitalised. Here is a patch for review, though it's pretty trivial -- I am wondering if an additional NEWS entry is warranted or not. I don't believe there are any manual updates required. Nice to resolve this subthread. -- Sean Whitton --=-=-= Content-Type: text/x-patch Content-Disposition: attachment; filename=0001-Use-key-for-detach-command-bindings.patch >From 2a128e9796b77f2b1d5c0b779929bd7deebe2ea1 Mon Sep 17 00:00:00 2001 From: Sean Whitton Date: Wed, 14 Sep 2022 09:49:27 -0700 Subject: [PATCH] Use '^' key for detach command bindings * lisp/tab-bar.el (tab-prefix-map): Move tear-off-window to C-x w ^ f. Bind tab-window-detach to C-x w ^ t. * lisp/window.el (window-prefix-map): Bind tab-detach to C-x t ^ f. --- lisp/tab-bar.el | 1 + lisp/window.el | 3 ++- 2 files changed, 3 insertions(+), 1 deletion(-) diff --git a/lisp/tab-bar.el b/lisp/tab-bar.el index cf5ae09a24..abefd996a8 100644 --- a/lisp/tab-bar.el +++ b/lisp/tab-bar.el @@ -2411,6 +2411,7 @@ 'tab-list (keymap-set tab-prefix-map "M" #'tab-move-to) (keymap-set tab-prefix-map "G" #'tab-group) (keymap-set tab-prefix-map "r" #'tab-rename) +(keymap-set tab-prefix-map "^ f" #'tab-detach) (keymap-set tab-prefix-map "RET" #'tab-switch) (keymap-set tab-prefix-map "b" #'switch-to-buffer-other-tab) (keymap-set tab-prefix-map "f" #'find-file-other-tab) diff --git a/lisp/window.el b/lisp/window.el index d5f42dd10b..905803b19e 100644 --- a/lisp/window.el +++ b/lisp/window.el @@ -10593,7 +10593,8 @@ window-prefix-map "2" #'split-root-window-below "3" #'split-root-window-right "s" #'window-toggle-side-windows - "f" #'tear-off-window + "^ f" #'tear-off-window + "^ t" #'tab-window-detach "-" #'fit-window-to-buffer "0" #'delete-windows-on) (define-key ctl-x-map "w" window-prefix-map) -- 2.30.2 --=-=-=--