From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Po Lu Newsgroups: gmane.emacs.devel Subject: Re: master 5b3c4004a9 2/2: Remove calls to intern with a static string from code that runs on X Date: Tue, 20 Sep 2022 16:17:58 +0800 Message-ID: <87tu52lart.fsf@yahoo.com> References: <166355307855.3830.3892166668612546304@vcs2.savannah.gnu.org> <20220919020439.67823C00874@vcs2.savannah.gnu.org> <874jx328ye.fsf@gnus.org> <877d1zsufw.fsf@yahoo.com> <87bkrbredr.fsf@yahoo.com> <878rmfpy2g.fsf@yahoo.com> <87fsgmn8cy.fsf@yahoo.com> <2b1180d2e5035730c58d@heytings.org> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="28143"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.91 (gnu/linux) Cc: Lars Ingebrigtsen , emacs-devel@gnu.org To: Gregory Heytings Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Tue Sep 20 11:04:52 2022 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1oaZBT-00073z-V5 for ged-emacs-devel@m.gmane-mx.org; Tue, 20 Sep 2022 11:04:52 +0200 Original-Received: from localhost ([::1]:60434 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1oaZBS-0000BC-Hd for ged-emacs-devel@m.gmane-mx.org; Tue, 20 Sep 2022 05:04:50 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:34700) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1oaYSK-000695-KF for emacs-devel@gnu.org; Tue, 20 Sep 2022 04:18:12 -0400 Original-Received: from sonic314-22.consmr.mail.ne1.yahoo.com ([66.163.189.148]:39152) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1oaYSH-0007I3-95 for emacs-devel@gnu.org; Tue, 20 Sep 2022 04:18:11 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=yahoo.com; s=s2048; t=1663661886; bh=gv2y/9aPGrgwQXbgY4c1TILGINPTzV1OCnWjDW4BaA4=; h=From:To:Cc:Subject:References:Date:In-Reply-To:From:Subject:Reply-To; b=ZT9VoM9qhe6g8xo9UPHgOQAjA6hi6uOXZ974N6wKnemnwxAIZ4YE5udPTqgLGqNg1mSA5N+RXXpeObnK/OBaO/c3LyJY/uO7F3Ryl3DeCcz1B4/pimRHiDneNW78JKeYat4XtfcvvJZEkIw+aAQx9P6P+JgfVhnvUWnc4Armon5X3qr168kPI+d4hPRoMmNE3xTPZ2RIJgSVBrClek9R4yLQ0LCsMh69w0/y6NmmZz07r5aKujCpu1xrIlFtqOL393J3WM+8ICcJ13I5NHB7rAQR8DoUqEpVvQGw4kOKY7fNpK0UZPoizUQMdkEVlCuSB9RWF4/T9qtSwhs140McPg== X-SONIC-DKIM-SIGN: v=1; a=rsa-sha256; c=relaxed/relaxed; d=yahoo.com; s=s2048; t=1663661886; bh=2s8eTdbsrYLf7O0dqZ+MUvtF0C2oux0hRhganyo0lse=; h=X-Sonic-MF:From:To:Subject:Date:From:Subject; b=Onqlepez2hOlrM4RB7UKyhhjVKK75BGQMLv8uKs37NrcxyASz+hx6UVAzE3xauYRkL3Uan8kKSS362urFS37OfItVj2rUONtCEeXyI/ttnRW1IRK+nioDhMObBDe9XL+exkFbNpdfsdqy1S5Jxkr9nf99+E8x5VnXvkC0drkBhjF+cUFCooFIfA7MklQtF7H751X8VW+1qs3C6Hyh7Bk++HnJtN4AYWiF61AXDf4B84uEt2jxBazbYJSPUfdeIiKq1fSNSDsOnysTRTzcwm1+n/OV6ykPb8wzcZ2kSS7ziX+fxa7C+D6jDR2MUq+gu1w/WIkxFGV/nRs7xGsX9vkOw== X-YMail-OSG: z.9HE_cVM1njue0m2q56mas9O.VXr6SccDCVXYMrkrUEpH5b9_g7QS35_rql5nZ 7pLMcPIYrf3ZyRvDDVp4.BnpAHdfvXmtx400bMrs7T3niEaidL.m2X2cnYMWRf8ALFfyipZ1.OxO 9H9DtTGsh5gMONOpEV2z58joya6iQc0AkIa5pk4.EvzHnO8tXdWRTVfwjTSo2vn8YJOyVQ9XcKVg _SLAO01DqKKD0Tkoutoy0qv7KkSlXvfw5g2CTZt7AQO9N7wNqWueU6LotkqCL_WN3_kvrO2StYRt S8VocQCX9jbDEYhVexNTzbWdFWQ4n0jBFoqJPKaZsB_ljHlV65dUsZYp5frVm9OKffuLdrcVg_pe OnuQG1Jg74.FXUr6No2CP73wRIdJAZKw_6oeeWcUCn6Olw2M4NaXDHtl5EpB6CWE3dRI_8NDtwgF inqM7AY_MOev8s3iJ_GC4tktXtE_0jS8d1HgZyxEO6bq4aw2x6vMbrNNMVFLqAPCXL3wfqEe_ULo 25C1.R9T4I25H_sR_BEOlX2Y574gltz_3h86RhlAtvbJ1TifudzmCxxL4RmSIg4QIXThjQ0bU_2P XPQwAQLoRPIbGZzFbBfJIQW47mC83KlZKNRHOeWN71ir7cpSAuZ2_c4_cYYyJqXZ98Ld_GGIMTin 4YA4Uyp.4j1cZIkEfx5P_P.eru1_.MVsbpcXfT1d3HDxNlRgeUEBTV9Wof1ju3VFOKZ9l7xkJq.x B.knZTav3TeCJb4n6YrxrhG2B_Ngst8b6MSoVNUrNB7bgWktHWh.zf0AucQ.Diri54oYKiQoTFmP g2R5hrIq055ItKFfshbx5LIdTFT.DAMuFKJukdtPoQ X-Sonic-MF: Original-Received: from sonic.gate.mail.ne1.yahoo.com by sonic314.consmr.mail.ne1.yahoo.com with HTTP; Tue, 20 Sep 2022 08:18:06 +0000 Original-Received: by hermes--canary-production-sg3-6bb8946c47-kl2d9 (Yahoo Inc. Hermes SMTP Server) with ESMTPA ID 180e92dda1363041236b5dad39b86b25; Tue, 20 Sep 2022 08:18:03 +0000 (UTC) In-Reply-To: <2b1180d2e5035730c58d@heytings.org> (Gregory Heytings's message of "Tue, 20 Sep 2022 07:55:01 +0000") X-Mailer: WebService/1.1.20663 mail.backend.jedi.jws.acl:role.jedi.acl.token.atz.jws.hermes.yahoo Received-SPF: pass client-ip=66.163.189.148; envelope-from=luangruo@yahoo.com; helo=sonic314-22.consmr.mail.ne1.yahoo.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.io gmane.emacs.devel:295790 Archived-At: Gregory Heytings writes: > I'm puzzled. Is that with emacs -Q? No. I don't develop software in "emacs -Q". > I'm at 9035c20888, and all links seem to be fontified and to work > correctly, each one takes me to the right place in the Makefile. Do > you have a recipe, perhaps? The recipe is not very relevant, since we already know the fix. Which is to remove indentation and leading dashes from the message. At the same time, it would be good to remove bullet lists from the message, and reword it in plain English. Why? Because it is easier for people who, presumably unlike you, are not native English speakers, to follow instructions laid out in the verbal format they learned at school, instead of lists of individual, heavily context-dependent sentences. Emphasis is better conveyed verbally, rather than with exclamation marks and capitals. I think it is also good to remove all uses of the first-person pronoun, like so: # ADVICE-ON-FAILURE-BEGIN:all # Running "make bootstrap" to re-build Emacs without compiled Lisp code # commonly resolves the problem, while running "make V=1" will cause # Make to display the commands it invokes to build Emacs, which can help # investigate the problem. # ADVICE-ON-FAILURE-END:all # ADVICE-ON-FAILURE-BEGIN:bootstrap # Try running "make extraclean" followed by "make", which will rebuild # Emacs with the default configuration options. Failing that, run "git # clean -fdx" and "make bootstrap"; keep in mind that will irretrievably # delete all files not under version control. If Emacs still fails to # build, please report the failure to bug-gnu-emacs@gnu.org, following # the instructions in the 'Reporting Bugs' node of the Emacs manual. # ADVICE-ON-FAILURE-END:bootstrap And this type of build failure should never happen from a tarball, so the message for both targets should be changed to: # Please report the build failure to bug-gnu-emacs@gnu.org, following # the instructions in the 'Reporting Bugs' node of the Emacs manual. For both targets.