From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Po Lu Newsgroups: gmane.emacs.devel Subject: Re: [PATCH] On the nasty "ghost key" problem on NS Date: Thu, 10 Nov 2022 20:25:03 +0800 Message-ID: <87tu373skg.fsf@yahoo.com> References: <87leord0ei.fsf@yahoo.com> <87h6zfchpu.fsf@yahoo.com> <394D8618-AF36-44C4-BA64-7AFDFBBDC429@gmail.com> <878rkrcbkx.fsf@yahoo.com> <87sfizaria.fsf@yahoo.com> <87k04ac3s6.fsf@yahoo.com> <36443E84-7646-4BD3-B1E4-C671C2BB46BC@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="40336"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Cc: Stefan Monnier , emacs-devel@gnu.org To: Kai Ma Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Thu Nov 10 13:26:07 2022 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1ot6dD-000AJ4-My for ged-emacs-devel@m.gmane-mx.org; Thu, 10 Nov 2022 13:26:07 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1ot6cd-0001H2-SH; Thu, 10 Nov 2022 07:25:31 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1ot6cT-0001FT-8z for emacs-devel@gnu.org; Thu, 10 Nov 2022 07:25:22 -0500 Original-Received: from sonic305-21.consmr.mail.ne1.yahoo.com ([66.163.185.147]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1ot6cP-0003Uq-IP for emacs-devel@gnu.org; Thu, 10 Nov 2022 07:25:20 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=yahoo.com; s=s2048; t=1668083113; bh=QmY67yqJ9qd/K0FHQWz0gGfsWuyqPNS3OApTQWbOFCg=; h=From:To:Cc:Subject:In-Reply-To:References:Date:From:Subject:Reply-To; b=mgbhhby/13wvL9TNEJ+LqiXh38a4MFZhsO8Mh1SWlHKn0vW6ZTMMxtSewTPM5J4KApXHO2ShVbYpgd63hdqybY83b3wQlvdkeX9tnKx0f8haUhN+cu4fXBM6I8kRLrJPWG/oW+0ecTi4zIG8vOTLYUaCulCJj8nxkoA0cdr2uiNq6Joy9YaM1dLTKVyc8EsJamZfveg+UkPrmsV/TUbc+PGB+k9Ji2Az/F+uYY8M9JNA0PHKnRs3cJ+nJCZiFL7M9MjclkyVZQTATh+mcbp70qml67YKYGyhZOg4yTEsi48Y11Rw2a6FkziFQTyaAYlySmy6f1uD8VM0Jw7kMyIlcw== X-SONIC-DKIM-SIGN: v=1; a=rsa-sha256; c=relaxed/relaxed; d=yahoo.com; s=s2048; t=1668083113; bh=eITzkKPkgW3UbJQElUA6nkL1XRXOV6LXeY1Orh7TBU0=; h=X-Sonic-MF:From:To:Subject:Date:From:Subject; b=P1kM88+0Fd/c4z5HttOAgb7ee6Q3smeKKfqX8Of6L4CXVqQgQFAOC0QOPHswWjKILTFfbzB9GX/IRg4nbnYekieOFaHLvYVHgzVp9bh9qhIBNT0brADOIllVxQ+h9tZXa4Ves0DCwYWEJGk4Ai3Ld+HV4eySm/A1dP+2F0AW1xAStq5ZYDOaGBB9T37NeByp39Ece9M7juf1G7VfDNMPTs4W8Z3//Gp2y+wvYiKxJwYnvs29WU0A5fUMRqSfOHhRluLOmRXeknErRuckcFbXI2eAnkWDgIxGhDqIRrcgPCiTacpnAN7PACiR/FEJh5m9FLkKpR4W87Nwq6TqFWLd8Q== X-YMail-OSG: ER8B1jgVM1kBkwXdCvYb.9VdYV9Yn4v8QN2Op.dgNE3PJzJnE6POj9VRCk6JjwM DeU5HM4oSGKySCZWC7tR90FbOUt_wL3c77vEadvQgrwORtJ1XrWj1yz1cqroSGYSH8y9hLybB6qZ DHMQVw5lbBm3IL1vh8JALUdBr.4Ok1P0Negl9TSaqScvV5NwTqf7yQtFJvuZO1fDvwfo7xgg9EJL jbsmZzcsLSOsR_LnK3WbUa1YvVXHWMdPs2D8d76ixQdhwG7ZNMSJkPVHI9_4w3SaKk0gsgGhm_U1 GEqkvoTw30JPxHvSohFuMOfrFqDc.tJOnDmcwVQWTrqR_6ekdYM.Pnsa87MJTm6dtK7GTYWGNXJp 271fsbCewqsEQ6MQwvhSG7pxfhE2dQuo3NNfg1VTzmcoW82c4AXzZSzaqJDgCGbYr6pkL51WOuMR DosilU88tykFfOEeaFWprdUx0G_YZXHRUzPuD8s80uPnjriRJ6kcfhAq0tzdupVXOCjqPbXQlkV_ VGAIbIaKZ2w80lQO2FLqJleVg_CpGyRG0rviWGtv7djRiLR4kaNqEHrUtlSTPmIsp1ql4rFF5CmS xBXllv1FR8Hn3xUukYDQrznvssTyKE4ppWKGXflIr.62wpRyGGPsE0QB03rDc6NRym8cH8mXdB2N gfORCZGTITKtA59PExaNpOUwECtXgPUwy4BZGm.o4BfXODIhF_.LROjlRNQ3lYoah450AQE8jZn_ W.NGBS8mXOeixN7f0ZGPJaILcz0KAg5p_PMnJrhYjtZ.v5ZLEttvVjB2xSQao7NgMtzca.z5hgyJ Is_0OgBZvH3GYK5aVbV2J.qATrIhqNsY2Lo6X9QEwc X-Sonic-MF: Original-Received: from sonic.gate.mail.ne1.yahoo.com by sonic305.consmr.mail.ne1.yahoo.com with HTTP; Thu, 10 Nov 2022 12:25:13 +0000 Original-Received: by hermes--production-sg3-6c8895b545-66t5n (Yahoo Inc. Hermes SMTP Server) with ESMTPA ID 74c4382d26d9470944db9b98dd56a956; Thu, 10 Nov 2022 12:25:08 +0000 (UTC) In-Reply-To: <36443E84-7646-4BD3-B1E4-C671C2BB46BC@gmail.com> (Kai Ma's message of "Thu, 10 Nov 2022 19:59:38 +0800") X-Mailer: WebService/1.1.20826 mail.backend.jedi.jws.acl:role.jedi.acl.token.atz.jws.hermes.yahoo Received-SPF: pass client-ip=66.163.185.147; envelope-from=luangruo@yahoo.com; helo=sonic305-21.consmr.mail.ne1.yahoo.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.devel:299485 Archived-At: Kai Ma writes: > On Nov 4, 2022, at 23:09, Stefan Monnier wrot= e: > > I'm glad we found a way to make the code work, apparently, but > Here we need a comment explaining why we do this gymnastic of > `safe_call` + `inhibit_quit` + `waiting_for_input`. > > It's very unusual to have to do that. > > Thanks for the pointer, this indeed turned out unnecessary (and dangerous= ). > > A tester informed me of a problem in the v3 patch: > > safe_call (0, Qns_in_echo_area) > > is incorrect. The 0 should be 1, or nargs will be -1 for funcall_general.= =20=20 > This will cause an error to be signaled, which explains why=20 > `waiting_for_input` has to be masked. > > [ I guess we could add an assertion that numargs >=3D 0 in funcall_genera= l or > somewhere else? ] > > This patch should be correct even without the ugly `waiting_for_input` ha= ck. > I=E2=80=99ve been running patched Emacs for some time without issues. > > With the current understanding of the bug, I guess the comment line could= be > /* Protect against throw-on-input. */ I will install a change using internal_catch_all instead, if Stefan is fine with that. By doing so, you get all of the benefits of safe_call and inhibit_quit, and it also protects against faulty code that changes the value of inhibit-quit inside the Lisp function.