From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Manuel Giraud Newsgroups: gmane.emacs.bugs Subject: bug#59351: 29.0.50; [PATCH] Fix mouse click position to menu bar entry Date: Fri, 18 Nov 2022 14:40:26 +0100 Message-ID: <87tu2wv0s5.fsf@elite.giraud> References: <87tu2wlku7.fsf@elite.giraud> <878rk8ee6d.fsf@yahoo.com> <8735agr0g4.fsf@elite.giraud> <83o7t4bhk4.fsf@gnu.org> <87h6ywwj9e.fsf@elite.giraud> <83edu0bg4w.fsf@gnu.org> <87cz9kwi2y.fsf@elite.giraud> <838rk8bf36.fsf@gnu.org> <87r0y0cs76.fsf@yahoo.com> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="33697"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Cc: Eli Zaretskii , 59351@debbugs.gnu.org To: Po Lu Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Fri Nov 18 14:41:21 2022 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1ow1cO-0008ZD-UP for geb-bug-gnu-emacs@m.gmane-mx.org; Fri, 18 Nov 2022 14:41:20 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1ow1c8-0008Ic-7V; Fri, 18 Nov 2022 08:41:04 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1ow1c6-0008I7-8I for bug-gnu-emacs@gnu.org; Fri, 18 Nov 2022 08:41:02 -0500 Original-Received: from debbugs.gnu.org ([209.51.188.43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1ow1c5-0002pM-VL for bug-gnu-emacs@gnu.org; Fri, 18 Nov 2022 08:41:01 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1ow1c5-0005zH-QT for bug-gnu-emacs@gnu.org; Fri, 18 Nov 2022 08:41:01 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Manuel Giraud Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Fri, 18 Nov 2022 13:41:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 59351 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 59351-submit@debbugs.gnu.org id=B59351.166877883522970 (code B ref 59351); Fri, 18 Nov 2022 13:41:01 +0000 Original-Received: (at 59351) by debbugs.gnu.org; 18 Nov 2022 13:40:35 +0000 Original-Received: from localhost ([127.0.0.1]:35800 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ow1bf-0005yP-7Y for submit@debbugs.gnu.org; Fri, 18 Nov 2022 08:40:35 -0500 Original-Received: from ledu-giraud.fr ([51.159.28.247]:46885) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ow1bZ-0005yD-6u for 59351@debbugs.gnu.org; Fri, 18 Nov 2022 08:40:33 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; s=rsa; bh=SIT8uRRJVzyWz+hu FeUjVBdgkf2QjMINoLijmC+wduM=; h=date:references:in-reply-to:subject: cc:to:from; d=ledu-giraud.fr; b=qjp/TAowodMSNPftq1C2mf/e73cbqIFF9M+Ii3 rJsfbHHu5UlMz2c27Y/nMVAojQ4Mtxkme6bx/3xUmZ5xchwUXRjCi94Mz/jKspPVM4RSa6 KZAnuX8eZYKc34oyxJ/z8xq4GEnzf0KEbpcuNwmVgrAWpQnJ+WWg6u6klswuOq/3+mMq2X p2oj9Qa8N+yTGFz3Ww5LGi4pCQEN2Jt+kT8KmgWbV6OsMFrm6KUkPheE+oaMr9WxO6JxsX kWzLjd6Ma+Er4uTKjNKAUe7J7UHabQ0yADDzU2uLeXGPPgB/m64nJmrQOHp7pBZHrcvPHH qxCs9sMEo+lT9WJtUpoKCC0g== Original-Received: from elite.giraud ( [10.1.1.1]) by ledu-giraud.fr (OpenSMTPD) with ESMTPSA id 14373e69 (TLSv1.3:TLS_AES_256_GCM_SHA384:256:NO); Fri, 18 Nov 2022 14:40:27 +0100 (CET) In-Reply-To: <87r0y0cs76.fsf@yahoo.com> (Po Lu's message of "Fri, 18 Nov 2022 21:23:09 +0800") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:248236 Archived-At: Po Lu writes: [...] > Please see my other reply. The pseudo-window is changed when a menu bar > is activated on a TTY with a mouse, but not under X, where the XMenu > library is used to display the menu. Since the proposed code only makes > a difference on terminals with variable-width fonts, my suggestion is to > use it only on X terminals, whilst letting the TTY menu bar operate as > before. Ok. I think that the #ifdef of the new version of the patch did just that (i.e. use old cold if not on X)=E2=80=A6 but wait! I'm testing a new version using FRAME_TO_WINDOW_PIXEL_* macros you two proposed. --=20 Manuel Giraud