From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Nacho Barrientos Newsgroups: gmane.emacs.bugs Subject: bug#59805: 28.2; erc-track: handle faces modified with erc-button-add-face Date: Tue, 06 Dec 2022 19:56:06 +0100 Message-ID: <87tu28fjdz.fsf__30372.135240917$1670353229$gmane$org@cern.ch> References: <87h6ycprpt.fsf@cern.ch> <87bkoglilv.fsf@neverwas.me> <87359sh53z.fsf@cern.ch> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="16257"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: mu4e 1.8.9; emacs 28.2 Cc: 59805@debbugs.gnu.org, emacs-erc@gnu.org, git@david.leatherman.fm, Olivier Certner To: "J.P." Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Tue Dec 06 20:00:21 2022 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1p2dAw-0003wU-Qg for geb-bug-gnu-emacs@m.gmane-mx.org; Tue, 06 Dec 2022 20:00:18 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1p2dAi-0003wY-H1; Tue, 06 Dec 2022 14:00:04 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1p2dAg-0003w6-TL for bug-gnu-emacs@gnu.org; Tue, 06 Dec 2022 14:00:02 -0500 Original-Received: from debbugs.gnu.org ([209.51.188.43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1p2dAg-00087M-Jf for bug-gnu-emacs@gnu.org; Tue, 06 Dec 2022 14:00:02 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1p2dAg-00070d-Dl for bug-gnu-emacs@gnu.org; Tue, 06 Dec 2022 14:00:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Nacho Barrientos Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Tue, 06 Dec 2022 19:00:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 59805 X-GNU-PR-Package: emacs Original-Received: via spool by 59805-submit@debbugs.gnu.org id=B59805.167035318826910 (code B ref 59805); Tue, 06 Dec 2022 19:00:02 +0000 Original-Received: (at 59805) by debbugs.gnu.org; 6 Dec 2022 18:59:48 +0000 Original-Received: from localhost ([127.0.0.1]:44615 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1p2dAS-0006zy-3N for submit@debbugs.gnu.org; Tue, 06 Dec 2022 13:59:48 -0500 Original-Received: from mail-gv0che01on2049.outbound.protection.outlook.com ([40.107.23.49]:45167 helo=CHE01-GV0-obe.outbound.protection.outlook.com) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1p2dAP-0006zs-Td for 59805@debbugs.gnu.org; Tue, 06 Dec 2022 13:59:47 -0500 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=W1+hUMLR9284ODJjG4x5Q/Fs/0+/RLX1q3Uf/ZAat7ud6hsxLh1gSomCVKzlojcS8XU4J1Doh155SmYtUk0U3ZUI798duqIHTYyymsijKrCGvNCFO8lM+UudccPqflSvv/C0o/HbICyJ3NuqZ5wcM1YO0rAvevEmPJ4QLtKLpRDoAmNrGTrcDIl+krOQWcCFSZi6hKXiNdmlLhqr8zxafuWyLimMClIVmH15j9X1IGp+ht5dXsYxQXHB8wxaHexo6TokTIiYrHM97WORpJDUbCb1FzA+PV989+btCsqChjxZZ7V1A06YZj9527pI1hhci82AfvkuHYWR5zpOzGtxhg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=419hfRDVAERm7nvdAtnoIcKq+47PKHkN/8mAYwTeLS4=; b=BALmTvZZUGV3X+vqJyZZ4PlWc72HEv8FTZbpEiGETsJqCaObPf4DrnKR5LFNAWi1wSzc+eyIzP7Dp3D6DzUjIWG2E0XY0Jc6LSb+kEh0ME2J+9slXig1dvTgXqr7H7NbED0A8GcPyAF5RZde1/pLn3GgkAUj5O0uR/IK+kLm2k8/utPXcfrMjiSPyzcUhb9cxR6DWt9bJGODJ3zGzdKHehrSJaxziJFJ+Zh6R0/EGWFL0jTjG2+N/+JO6vW3/9gfJFiquOW3yE+1ABchmMgsm8mDt9IG4nwMolmVOFD5qt4AEBwMuYF6Wn7vFBK0vRL8MttSqD6SW+rH+Cg+05HP7g== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=cern.ch; dmarc=pass action=none header.from=cern.ch; dkim=pass header.d=cern.ch; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=cern.ch; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=419hfRDVAERm7nvdAtnoIcKq+47PKHkN/8mAYwTeLS4=; b=DKRRYmzUSf32Yk2JUh1Tl6eMlqOfUDI65wzD7j70ixTi1JxHruOWe9bNje+ZjkNbik/pVUIRmnDytc8B7fT4jh0uBkLYRE+XJI1MJUFY2jY4RElB/1IxUmx0Bc/pm/Q1fJ0rDR8thjRwTREPJtopoEN8APIhe2GkfRUX4kYiMF4= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=cern.ch; Original-Received: from GVAP278MB0453.CHEP278.PROD.OUTLOOK.COM (2603:10a6:710:3e::12) by GV0P278MB0100.CHEP278.PROD.OUTLOOK.COM (2603:10a6:710:1e::14) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5880.14; Tue, 6 Dec 2022 18:59:37 +0000 Original-Received: from GVAP278MB0453.CHEP278.PROD.OUTLOOK.COM ([fe80::8e98:749:b643:ac85]) by GVAP278MB0453.CHEP278.PROD.OUTLOOK.COM ([fe80::8e98:749:b643:ac85%6]) with mapi id 15.20.5880.014; Tue, 6 Dec 2022 18:59:37 +0000 In-reply-to: <87359sh53z.fsf@cern.ch> X-ClientProxiedBy: ZR2P278CA0071.CHEP278.PROD.OUTLOOK.COM (2603:10a6:910:52::17) To GVAP278MB0453.CHEP278.PROD.OUTLOOK.COM (2603:10a6:710:3e::12) X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: GVAP278MB0453:EE_|GV0P278MB0100:EE_ X-MS-Office365-Filtering-Correlation-Id: 996a400e-52e4-4dcf-d341-08dad7bc055e X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: VPAUaR+TZT/DD2MApSkrhXFHZzOjvaqZUFqKzqqXGF48NRjIkb+IEc0JMB3JPd5DnoYvAmHuGl0PXn6Ifc9t0Rr1kCJUO5XPhh2OQyznxLUGf95+wyHQfc/IYQW0OGg9I6OPHAfG5SZx8TnDfBOpYKDOSr1ZNlj5K9A7QlMfkHSVYXJ1tUBTfK9igrgT8QZAQ1B4SqN5vcS82wALSGGD7sPaBJnQFqOIuZSDBxL+nyj3e6xOjpAK0jpGqrCNiwPOvSjl5M27P6nEyVItW1bmJrwHytyRxa9uBfUDP/9fM6SS98wHRKBtzd75E2l1mNJ0cCXUC2srkJNUWoOMlBbC4trvQ/WxPTM4R64u1FEofoNtvQZBWF+s0dmLFCP6Eq71hiwSUMc/B9QXn80QdDIHS06gz3AC0uHsz05O0QEYXoGl3qOXx5iNvdknTh5aLrqGUAO1Xq4ibue7SR5bTaCWyqj4y97+N5xQ2hjtMQ8lL05y3Kqm5m8aPdgohXrnPq2980EMc5jWOGI8IqUlrf+4SDggDb8O8w5lF28HPZlYNZ1FKYlRLl/W8sPk1twmvsHYxRlClp42W48c1VstePkaSLCkWq7j/DatvaDZCvq+d9Cfn8OVhkk0OImits6TMc6K/jSkGKxPJdpKjfUXwiXHCxeuWx3nwpJZUKptgtLwmSX9+BnZ6lgq6NB9xFuB7C5eq8k754+39eKKvGLM078X/A== X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:GVAP278MB0453.CHEP278.PROD.OUTLOOK.COM; PTR:; CAT:NONE; SFS:(13230022)(4636009)(39860400002)(376002)(396003)(136003)(366004)(346002)(451199015)(66946007)(66556008)(2906002)(86362001)(41320700001)(66476007)(66899015)(4326008)(8676002)(2616005)(6666004)(36756003)(478600001)(6486002)(966005)(6916009)(8936002)(41300700001)(5660300002)(186003)(83380400001)(6506007)(38100700002)(44832011)(6512007)(786003)(316002)(41080700001); DIR:OUT; SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: f3dVvbYaDNeL/EWZPWzpoTz7ZSYMJWBaQ9eqCVmo2b83j5vrrVIPoyRTucYJYJYG7rXl2spnaOaqhjq4TO3Gsmt2yze5CXj1BmMWKYB7/wkARHvlt/SLa01cILF4aNPk1KL1ZGSDvb7Lm8N30r2gjxudII9y3RiTaLV5aPAVewXch3stN0dy0UYtCsUgNSB7vUvMrSQ55smJIgedcj1L5F9x4TQfMlPKOdE7x9qbLe3yXxTZaiprvX4oHtOIfCcByy2t8f6deo4SUCK0IbFPH9SE7q5gN1it6DVYifxvzMZyrBxg5OacwMz02OB01jNgx6sPZuiVwY7L939UHiNwYT9X9DnLh2R+9p9AysOUAZAF3Mrn8fg0Ua5GJg15/WJOvhYChVlOs85TfVmba9Z8mBr1gCQiCH5BP9xxHvRz4QewCdHSout6Vn3UgZcnsXI0ugwFVfwc5Fxu/eY8jX1XtiLPeYgJ78sVwHACaVEiV7vlBawuhJ8Lq6qpE/HTgO0q+ATLypPhjpP6dAgszVdAov5oTXLMQ9WMgp4TErs9kE5W4YRim4YLr41ZW0mNI5wP8xJFs4wMgSbiz8wwzy4J2bCneZdxt0bmdj62KavHz1GDuTK+j87TRDP4Rlxv/yUU6+kY/SyBU3pW4n3SaaGiRk48yP8lGZkTTLV0OjCTqspNMJ3cs0Bu/YMSHPNeX5Jzt09CYN23OP2jIWcINzV1YJ8fhLnqT2OD5HMAy2MYL6wF6Vow6y1TQaWpqf J0L739jNlphTF6mhLSLHh7Dj5MayatXEDf3edWY/y/GsGIUlltEcgI5TatJeSxwWHZLecjDJZ5HaNI5nCtm6apDDu9aX68kbg4 X-OriginatorOrg: cern.ch X-MS-Exchange-CrossTenant-Network-Message-Id: 996a400e-52e4-4dcf-d341-08dad7bc055e X-MS-Exchange-CrossTenant-AuthSource: GVAP278MB0453.CHEP278.PROD.OUTLOOK.COM X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 06 Dec 2022 18:59:37.1364 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: c80d3499-4a40-4a8c-986e-abce017d6b19 X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: LUxxMHqGei2lbfXrdybX3dHvHlfT+iCizNJOhsiXarc6XmLTtqrkOVgn3wZTjqfflqCC9eOI4t1SLl2HQ8q5ncWZNP50m+upfoZiILAXprU= X-MS-Exchange-Transport-CrossTenantHeadersStamped: GV0P278MB0100 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:250137 Archived-At: Hi again, On 06/12/22, Nacho Barrientos said: > This is indeed what I did initially in my configuration, before I > thought about reporting this bug. This approach works, however in my > opinion it's not ideal (for me as user), because: > > 1) I have to monkeypatch erc-hl-nicks. > 2) I have to hardcode the nick-dependant face name to look for. There's > already a face to identify mentions to the current nick > (`erc-current-nick-face') so this should not be necessary. > > 1) could be addressed by submitting a patch for erc-hl-nicks so those > symbols are interned so they could be `equal''ed, as you suggested. > > For 2) I don't have an elegant/generic solution to propose, but adding > > (erc-hl-nicks-nick-nacho-face erc-current-nick-face) > > to `erc-track-faces-priority-list' can definitely work for me. My > nickname is stable across networks, however I think that the rather > valid use case of being notified no matter what your nick name is cannot > be honoured elegantly when using erc-hl-nicks. Actually there's something else that can be done from the erc-hl-nicks side, which is: (setq erc-hl-nicks-skip-nicks '("nacho")) Which comes again with the problematic of having to hardcode known nicks but it does the job. If that variable is set as indicated above, erc-hl-nicks will never create the composite face on the mention and hence: =CE=BB> (erc-faces-in (buffer-substring (point) (+ 1 (point)))) (erc-current-nick-face) (in the example above, `point' is on a mention to the current nick) Making erc-track's matching work. The current nickname is coloured anyway by ERC so if erc-hl-nicks does not act on it should be okay. This approach is good enough for me so feel free to close the bug if you don't want to go down this rabbit hole further :) Thanks again. -- bye Nacho http://cern.ch/nacho