From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Eric Abrahamsen Newsgroups: gmane.emacs.bugs Subject: bug#61640: 30.0.50; Help Elisp xref recognize defclass parent classes Date: Sun, 19 Feb 2023 17:43:48 -0800 Message-ID: <87ttzhglgr.fsf@ericabrahamsen.net> References: <871qmlqped.fsf@ericabrahamsen.net> <87y1otgqxq.fsf@ericabrahamsen.net> <717e900b-1ccf-ad08-8949-eacce0c0e606@yandex.ru> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="14789"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Cc: dgutov@yandex.ru To: 61640@debbugs.gnu.org Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Mon Feb 20 02:44:20 2023 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1pTvE3-0003eG-Hk for geb-bug-gnu-emacs@m.gmane-mx.org; Mon, 20 Feb 2023 02:44:19 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1pTvDu-000387-Fv; Sun, 19 Feb 2023 20:44:10 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pTvDm-00035r-Da for bug-gnu-emacs@gnu.org; Sun, 19 Feb 2023 20:44:02 -0500 Original-Received: from debbugs.gnu.org ([209.51.188.43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1pTvDl-0001TG-MG for bug-gnu-emacs@gnu.org; Sun, 19 Feb 2023 20:44:02 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1pTvDl-0006B7-IB for bug-gnu-emacs@gnu.org; Sun, 19 Feb 2023 20:44:01 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Eric Abrahamsen Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Mon, 20 Feb 2023 01:44:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 61640 X-GNU-PR-Package: emacs Original-Received: via spool by 61640-submit@debbugs.gnu.org id=B61640.167685743823733 (code B ref 61640); Mon, 20 Feb 2023 01:44:01 +0000 Original-Received: (at 61640) by debbugs.gnu.org; 20 Feb 2023 01:43:58 +0000 Original-Received: from localhost ([127.0.0.1]:50046 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pTvDi-0006Aj-71 for submit@debbugs.gnu.org; Sun, 19 Feb 2023 20:43:58 -0500 Original-Received: from mail.ericabrahamsen.net ([52.70.2.18]:47740) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pTvDg-0006AU-9p for 61640@debbugs.gnu.org; Sun, 19 Feb 2023 20:43:56 -0500 Original-Received: from localhost (c-71-197-232-41.hsd1.wa.comcast.net [71.197.232.41]) (Authenticated sender: eric@ericabrahamsen.net) by mail.ericabrahamsen.net (Postfix) with ESMTPSA id 881DFFA0BD; Mon, 20 Feb 2023 01:43:49 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ericabrahamsen.net; s=mail; t=1676857429; bh=H7EoA0SBuWFWcfSxtxREmjZbzCuxCu4DdfTFgNAyH44=; h=From:To:Cc:Subject:In-Reply-To:References:Date:From; b=s62qVC3YSgSRUlZAl+ixin6MdtO1BtMvbyDyYqBPaLuuqRDuvikUmd4zCnw38CYB/ ksiCAESYqMQzLiKBbfMdKOaaTVdtTNyOWpHd/W8ue8ViFh24GhkFQkUB8M7rN5TcYz 1hvHj51XQex6+DexsHhqyl5feLN1NNqD0/SaVafU= In-Reply-To: <717e900b-1ccf-ad08-8949-eacce0c0e606@yandex.ru> (Dmitry Gutov's message of "Mon, 20 Feb 2023 03:05:31 +0200") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:256124 Archived-At: Dmitry Gutov writes: > Version: 30.1 > > On 20/02/2023 01:45, Eric Abrahamsen wrote: >> Shouldn't this instead be an addition to `elisp-mode-infer-namespace', >> like with p8 below? >> (elisp-mode-test--with-buffer >> (concat "(list {p1}alpha {p2}beta)\n" >> "(progn {p3}gamma {p4}delta)\n" >> "(lambda ({p5}epsilon {p6}zeta) {p7}eta)\n" >> "(defclass child-class (parent-1 {p8}parent-2)\n") >> (should (equal (elisp--xref-infer-namespace p1) 'variable)) >> (should (equal (elisp--xref-infer-namespace p2) 'variable)) >> (should (equal (elisp--xref-infer-namespace p3) 'variable)) >> (should (equal (elisp--xref-infer-namespace p4) 'variable)) >> (should (equal (elisp--xref-infer-namespace p5) 'variable)) >> (should (equal (elisp--xref-infer-namespace p6) 'variable)) >> (should (equal (elisp--xref-infer-namespace p7) 'variable)) >> (should (equal (elisp--xref-infer-namespace p8) 'function))) >> Obviously just guessing here... > > It seems you're right, thanks. > > I've put the test case separately and pushed the combined change to > master, commit cac13e36054. > > That fixes the bug in my testing, but please do tell if something else > comes up. Thanks!