From: Eric Abrahamsen <eric@ericabrahamsen.net>
To: 61640@debbugs.gnu.org
Cc: dgutov@yandex.ru
Subject: bug#61640: 30.0.50; Help Elisp xref recognize defclass parent classes
Date: Sun, 19 Feb 2023 17:43:48 -0800 [thread overview]
Message-ID: <87ttzhglgr.fsf@ericabrahamsen.net> (raw)
In-Reply-To: <717e900b-1ccf-ad08-8949-eacce0c0e606@yandex.ru> (Dmitry Gutov's message of "Mon, 20 Feb 2023 03:05:31 +0200")
Dmitry Gutov <dgutov@yandex.ru> writes:
> Version: 30.1
>
> On 20/02/2023 01:45, Eric Abrahamsen wrote:
>> Shouldn't this instead be an addition to `elisp-mode-infer-namespace',
>> like with p8 below?
>> (elisp-mode-test--with-buffer
>> (concat "(list {p1}alpha {p2}beta)\n"
>> "(progn {p3}gamma {p4}delta)\n"
>> "(lambda ({p5}epsilon {p6}zeta) {p7}eta)\n"
>> "(defclass child-class (parent-1 {p8}parent-2)\n")
>> (should (equal (elisp--xref-infer-namespace p1) 'variable))
>> (should (equal (elisp--xref-infer-namespace p2) 'variable))
>> (should (equal (elisp--xref-infer-namespace p3) 'variable))
>> (should (equal (elisp--xref-infer-namespace p4) 'variable))
>> (should (equal (elisp--xref-infer-namespace p5) 'variable))
>> (should (equal (elisp--xref-infer-namespace p6) 'variable))
>> (should (equal (elisp--xref-infer-namespace p7) 'variable))
>> (should (equal (elisp--xref-infer-namespace p8) 'function)))
>> Obviously just guessing here...
>
> It seems you're right, thanks.
>
> I've put the test case separately and pushed the combined change to
> master, commit cac13e36054.
>
> That fixes the bug in my testing, but please do tell if something else
> comes up.
Thanks!
prev parent reply other threads:[~2023-02-20 1:43 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-02-19 22:08 bug#61640: 30.0.50; Help Elisp xref recognize defclass parent classes Eric Abrahamsen
2023-02-19 22:42 ` Dmitry Gutov
2023-02-19 23:45 ` Eric Abrahamsen
2023-02-20 1:05 ` Dmitry Gutov
2023-02-20 1:43 ` Eric Abrahamsen [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87ttzhglgr.fsf@ericabrahamsen.net \
--to=eric@ericabrahamsen.net \
--cc=61640@debbugs.gnu.org \
--cc=dgutov@yandex.ru \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.