From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Michael Albinus Newsgroups: gmane.emacs.bugs Subject: bug#62194: 30.0.50; Two Eglot-over-Tramp tests are failing on master, passing on emacs-29 Date: Thu, 16 Mar 2023 13:02:01 +0100 Message-ID: <87ttykj45i.fsf@gmx.de> References: <87wn3jue1q.fsf@gmail.com> <87edpqjqsv.fsf@gmx.de> <874jqmjl0s.fsf@gmx.de> <875yb1pxai.fsf@miha-pc> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="19843"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Cc: 62194@debbugs.gnu.org, miha@kamnitnik.top To: =?UTF-8?Q?Jo=C3=A3o_?= =?UTF-8?Q?T=C3=A1vora?= Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Thu Mar 16 13:03:22 2023 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1pcmKH-0004yp-TM for geb-bug-gnu-emacs@m.gmane-mx.org; Thu, 16 Mar 2023 13:03:21 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1pcmK0-0001x7-SF; Thu, 16 Mar 2023 08:03:04 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pcmJy-0001wy-Qh for bug-gnu-emacs@gnu.org; Thu, 16 Mar 2023 08:03:02 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1pcmJy-0002E2-IG for bug-gnu-emacs@gnu.org; Thu, 16 Mar 2023 08:03:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1pcmJy-0005ib-0p for bug-gnu-emacs@gnu.org; Thu, 16 Mar 2023 08:03:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Michael Albinus Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Thu, 16 Mar 2023 12:03:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 62194 X-GNU-PR-Package: emacs Original-Received: via spool by 62194-submit@debbugs.gnu.org id=B62194.167896813221916 (code B ref 62194); Thu, 16 Mar 2023 12:03:01 +0000 Original-Received: (at 62194) by debbugs.gnu.org; 16 Mar 2023 12:02:12 +0000 Original-Received: from localhost ([127.0.0.1]:41426 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pcmJA-0005hQ-16 for submit@debbugs.gnu.org; Thu, 16 Mar 2023 08:02:12 -0400 Original-Received: from mout.gmx.net ([212.227.17.21]:43057) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pcmJ7-0005hA-BU for 62194@debbugs.gnu.org; Thu, 16 Mar 2023 08:02:09 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=gmx.de; s=s31663417; t=1678968122; i=michael.albinus@gmx.de; bh=Dmdgow3BOBIm7FkM/Jh2TNPOxTnecetmpd5FNeC/4ro=; h=X-UI-Sender-Class:From:To:Cc:Subject:In-Reply-To:References:Date; b=NeGNJDXM+JOx1WNNuAxITiYcYPNaTma4c9znZcYPTRGHYzflWvmajiTjUqvEFTZFI OVSn4xlyJydfAeksmOLKhzizggJz1s8k0ESjeIEl4TWLwyzjrPZqgbfKuXzEudRL+8 EN/5PhA5cQ1GLSHE4DAsW6Vf77VToOf50RaH+oxG/Qk/EalgZSUO8X0dRCyPWh1YUd MVPHfCsTCUdY3a8f57GNr5OXL5//SzjNsionp7zYTHZ+MIwEESIM+UZQEOLWshZLl6 KqNaOHK9m7x3f2o7hJB88paGt0ZgtKO9hvUuPSdm8BfBAzpKqddTTnL1bSGtQz72zC agoAXtY4sDrwg== X-UI-Sender-Class: 724b4f7f-cbec-4199-ad4e-598c01a50d3a Original-Received: from gandalf.gmx.de ([185.89.39.19]) by mail.gmx.net (mrgmx105 [212.227.17.168]) with ESMTPSA (Nemesis) id 1MpUYu-1qJrwU2cLU-00py6e; Thu, 16 Mar 2023 13:02:02 +0100 In-Reply-To: ("=?UTF-8?Q?Jo=C3=A3o_?= =?UTF-8?Q?T=C3=A1vora?="'s message of "Wed, 15 Mar 2023 20:45:47 +0000") X-Provags-ID: V03:K1:mGnsKhgbplA+nbJrWt8w3uvtbuRm0zIINzxarrJMhwxTjSj8rSd qHtZkFNJ1EfT8LFL28v5oF6qrlG9D92C179W8AVZvPM7Hbabx2RuwVsvshHN0R/DFYhsvSx ZuulAREfJumhCsfMuro4DTXfOukNivhHkECZRP0Nw9wFMlmzW3uMxrZNG8e7I0CfPYS/RmC HDNhgFiS3LR7BWKcsmXQA== UI-OutboundReport: notjunk:1;M01:P0:aM9omZxhm6I=;YuxVkTGZgVyvKpz1fReQSLcD3BX g6kGo1XXjykIQ7WyTk394sVwyQq9sGUA6xVT/a4zhMlmAdSIZHZhmiMIV0Saja2b7Dtsk9+RF bAv1/gSKMHhdXA3XPtyRre458UZ4+54OqLLkZWQvytehSPl/OjzzpYX8IT7RUmQIdcIqO1t1a Zo2V3zwTBvyDN8kSNsmalPW3rraPwE3jRZQOuBU5Z3fjmL1KEtzkJZdSTAv6qA4ecDwE3vrkP O8clpyzJvODs9gRJXLgESsNniWczAfh0Iy3oq/ZpL64R9bJbKXpFu99BBMciheA7R+gth7Cp3 7khP4xb9vOXrbJG6wP0mxgViivoo3VO8uq8RyQBE+1TcQnkXSZLwgksHltn+Lt8b3BM0NV73f orMNqs2Zqzamtr8FeSTLirXRn1VD2sdGZpmnXXmbmcLPuYS5cL7R33BFS9AO7jLnupyuNk+q+ UZ2n1q2BawFrC9xjWjb0UUaZNHKPdaljgrMEHCREldc4jeg6GBMa63Fz7+HmDG8zrSl0TuuiZ Ogx7dPpKdH/TtKV1ZdsZTbH82VBcHIxiJRk7VjsUXwo4jjgpZEGOY+OkrAXK2TQdMFPkT1lzc IrGyH6M01J4325p2jIEpJyBX2nOQ7fdsm2Z5nMUJepssQtDuyKeYu9YVL3fNMBRln+gAdUgSl Z3GU0ZkJ4quUfpToIJY86Gp3FoXDOrqlWGEFT0cjBkcBsjybi+jV6QA+pzMyQP4Swx3GVSKcE GegLlipFjPguBKnkv4j85wYYCfBAEQfs32p7ZtSDF8bBzTEYnXPDrQu4BnF+/Bad0ZLv2L0/ X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:258013 Archived-At: Jo=C3=A3o T=C3=A1vora writes: Hi, > I'm "against" this too, but hard facts here trump arguments and opinion. > This is exactly what fixes the ControlMaster hang, that's well understood, > and is really intended. It brings about some other failures but I've just > confirmed that if you put > > (while (accept-process-output p 0 nil t)) > > then all's well. > > Of course, it's only _one_ of the ways to fix the problem. If you have a= nother > more elegant one, but I don't know if signals is a great one. I'd guess > SIGWINCH to be somewhat limited in platform support, right? I'm also against using SIGWINCH at this point. It isn't portable, and it isn't even known whether it is needed always. The proposed patch wraps it by --8<---------------cut here---------------start------------->8--- (when (and (not result) (process-get proc 'shared-socket)) --8<---------------cut here---------------end--------------->8--- But the reason why result is nil could be simply the case that the remote side hasn't something to tell yet, and we need to wait. And this would complicate the scenario further. We have already a very fragile tramp-accept-process-output, which has changed again and again ove the last 20 years. I *really* would like to see a simple and robust implementation. My attempt with the additional process property `shared-socket' has failed, and I've reverted it. Pushed to master. The Eglot Tramp tests pass now, so I recommend to close this bug. > Jo=C3=A3o Best regards, Michael.