From: Robert Pluim <rpluim@gmail.com>
To: Nicolas Martyanoff <nicolas@n16f.net>
Cc: emacs-devel@gnu.org
Subject: Re: [PATCH] sql: add missing postgresql types
Date: Mon, 17 Apr 2023 11:12:32 +0200 [thread overview]
Message-ID: <87ttxeeutb.fsf@gmail.com> (raw)
In-Reply-To: <20230416133843.74970-1-nicolas@n16f.net> (Nicolas Martyanoff's message of "Sun, 16 Apr 2023 15:38:43 +0200")
>>>>> On Sun, 16 Apr 2023 15:38:43 +0200, Nicolas Martyanoff <nicolas@n16f.net> said:
Nicolas> * lisp/progmodes/sql.el: Add multiple missing PostgreSQL types: bigserial,
Nicolas> smallserial, macaddr8, jsonb, jsonpath, built-in range types, object
Nicolas> identifier types (oid & co).
Nicolas> ---
Nicolas> lisp/progmodes/sql.el | 19 +++++++++++--------
Nicolas> 1 file changed, 11 insertions(+), 8 deletions(-)
Nicolas> diff --git a/lisp/progmodes/sql.el b/lisp/progmodes/sql.el
Nicolas> index d8bd6bc2685..75d0cbbb367 100644
Nicolas> --- a/lisp/progmodes/sql.el
Nicolas> +++ b/lisp/progmodes/sql.el
Nicolas> @@ -2192,14 +2192,17 @@ sql-mode-postgres-font-lock-keywords
Nicolas> ;; Postgres Data Types
Nicolas> (sql-font-lock-keywords-builder 'font-lock-type-face nil
Nicolas> -"bigint" "bigserial" "bit" "bool" "boolean" "box" "bytea" "char"
Nicolas> -"character" "cidr" "circle" "date" "decimal" "double" "float4"
Nicolas> -"float8" "inet" "int" "int2" "int4" "int8" "integer" "interval" "line"
Nicolas> -"lseg" "macaddr" "money" "name" "numeric" "path" "point" "polygon"
Nicolas> -"precision" "real" "serial" "serial4" "serial8" "sequences" "smallint" "text"
Nicolas> -"time" "timestamp" "timestamptz" "timetz" "tsquery" "tsvector"
Nicolas> -"txid_snapshot" "unknown" "uuid" "varbit" "varchar" "varying" "without"
Nicolas> -"xml" "zone"
Nicolas> + "bigint" "bigserial" "bigserial" "bit" "bool" "boolean" "box" "bytea" "char"
Nicolas> +"character" "cidr" "circle" "date" "daterange" "decimal" "double" "float4"
Nicolas> +"float8" "inet" "int" "int2" "int4" "int4range" "int8" "int8range" "integer"
Nicolas> +"interval" "jsonb" "jsonpath" "line" "lseg" "macaddr" "macaddr8" "money"
Nicolas> +"name" "numeric" "numrange" "oid" "path" "point" "polygon" "precision" "real"
Nicolas> +"regclass" "regcollation" "regconfig" "regdictionary" "regnamespace "
Nicolas> +"regoper" "regoperator" "regproc" "regprocedure" "regrole" "regtype"
Nicolas> +"sequences" "serial" "serial4" "serial8" "smallint" "smallserial" "text"
Nicolas> +"time" "timestamp" "timestamptz" "timetz" "tsquery" "tsrange" "tstzrange"
Nicolas> +"tsvector" "txid_snapshot" "unknown" "uuid" "varbit" "varchar" "varying"
Nicolas> +"without" "xml" "zone"
Nicolas> )))
You have 'bigserial' in there twice.
Robert
--
next prev parent reply other threads:[~2023-04-17 9:12 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-04-16 13:38 [PATCH] sql: add missing postgresql types Nicolas Martyanoff
2023-04-16 13:41 ` Nicolas Martyanoff
2023-04-17 9:12 ` Robert Pluim [this message]
2023-04-17 10:18 ` Nicolas Martyanoff
2023-04-20 7:52 ` Eli Zaretskii
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87ttxeeutb.fsf@gmail.com \
--to=rpluim@gmail.com \
--cc=emacs-devel@gnu.org \
--cc=nicolas@n16f.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.