From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Philip Kaludercic Newsgroups: gmane.emacs.bugs Subject: bug#63337: [PATCH] package-vc--build-documentation: Fix relative @include statements Date: Fri, 12 May 2023 07:35:16 +0000 Message-ID: <87ttwivw7f.fsf@posteo.net> References: <87fs89qg9y.fsf@breatheoutbreathe.in> <87cz3cea4k.fsf@posteo.net> <87pm7c7zfs.fsf@breatheoutbreathe.in> <83zg6gc5yp.fsf@gnu.org> <87sfc8gd9s.fsf@posteo.net> <87fs877tgz.fsf@breatheoutbreathe.in> <875y936iec.fsf@posteo.net> <87y1lyhbfy.fsf@breatheoutbreathe.in> <83sfc6azol.fsf@gnu.org> <87bkitgj3c.fsf@breatheoutbreathe.in> <87lehwfzli.fsf@posteo.net> <87a5ybsjum.fsf@breatheoutbreathe.in> <875y8yxct4.fsf@posteo.net> <838rdu3tt4.fsf@gnu.org> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="17117"; mail-complaints-to="usenet@ciao.gmane.io" Cc: 63337@debbugs.gnu.org, joseph@breatheoutbreathe.in To: Eli Zaretskii Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Fri May 12 09:36:15 2023 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1pxNK3-0004Cq-61 for geb-bug-gnu-emacs@m.gmane-mx.org; Fri, 12 May 2023 09:36:15 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1pxNJr-0005lb-QD; Fri, 12 May 2023 03:36:03 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pxNJq-0005lT-9T for bug-gnu-emacs@gnu.org; Fri, 12 May 2023 03:36:02 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1pxNJp-0003Rr-U0 for bug-gnu-emacs@gnu.org; Fri, 12 May 2023 03:36:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1pxNJp-0000T6-Pc for bug-gnu-emacs@gnu.org; Fri, 12 May 2023 03:36:01 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Philip Kaludercic Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Fri, 12 May 2023 07:36:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 63337 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 63337-submit@debbugs.gnu.org id=B63337.16838769261758 (code B ref 63337); Fri, 12 May 2023 07:36:01 +0000 Original-Received: (at 63337) by debbugs.gnu.org; 12 May 2023 07:35:26 +0000 Original-Received: from localhost ([127.0.0.1]:53942 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pxNJF-0000SH-VG for submit@debbugs.gnu.org; Fri, 12 May 2023 03:35:26 -0400 Original-Received: from mout02.posteo.de ([185.67.36.66]:37727) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pxNJE-0000S2-2Y for 63337@debbugs.gnu.org; Fri, 12 May 2023 03:35:24 -0400 Original-Received: from submission (posteo.de [185.67.36.169]) by mout02.posteo.de (Postfix) with ESMTPS id 1D0CC24028A for <63337@debbugs.gnu.org>; Fri, 12 May 2023 09:35:18 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=posteo.net; s=2017; t=1683876918; bh=/NHfws6su9NsPYUDFP+Xc2choh3Qcsu9iIIRTU+jfOI=; h=From:To:Cc:Subject:Autocrypt:Date:Message-ID:MIME-Version:From; b=frGv4teP2aslWplsmIV+UpJd5ENLLb9AXEmzoG9+zHSYm+CoQMLbYtmiY9n3J101y poKPz8zbuwpEqJDj9KG1dWgHotHxceEiTkIvBX9fUQycyaSWhS4shogUtAdFifEnAg FCxuq5mrgOWChPHm5pL0J9LtPPmg/m0YP+GIrNcd6WxvZIBLVTFs1W8SEOun9GcedD jvUn9fupTBiRxjfqofrgWzWdOWO2LSoCQrAHqL1P9puhKf9QC8nAVx3CvJKD9wjJE/ CukCBzZ/EAj8hcF/sFGusth05ND6ZJVirHUmRezgsi5cHo3KJy6nisqd6IXNNosHsz NJiVzOZULf2YA== Original-Received: from customer (localhost [127.0.0.1]) by submission (posteo.de) with ESMTPSA id 4QHgXP2LdDz9rxD; Fri, 12 May 2023 09:35:17 +0200 (CEST) In-Reply-To: <838rdu3tt4.fsf@gnu.org> (Eli Zaretskii's message of "Fri, 12 May 2023 10:14:31 +0300") Autocrypt: addr=philipk@posteo.net; keydata= mDMEZBBQQhYJKwYBBAHaRw8BAQdAHJuofBrfqFh12uQu0Yi7mrl525F28eTmwUDflFNmdui0QlBo aWxpcCBLYWx1ZGVyY2ljIChnZW5lcmF0ZWQgYnkgYXV0b2NyeXB0LmVsKSA8cGhpbGlwa0Bwb3N0 ZW8ubmV0PoiWBBMWCAA+FiEEDg7HY17ghYlni8XN8xYDWXahwukFAmQQUEICGwMFCQHhM4AFCwkI BwIGFQoJCAsCBBYCAwECHgECF4AACgkQ8xYDWXahwulikAEA77hloUiSrXgFkUVJhlKBpLCHUjA0 mWZ9j9w5d08+jVwBAK6c4iGP7j+/PhbkxaEKa4V3MzIl7zJkcNNjHCXmvFcEuDgEZBBQQhIKKwYB BAGXVQEFAQEHQI5NLiLRjZy3OfSt1dhCmFyn+fN/QKELUYQetiaoe+MMAwEIB4h+BBgWCAAmFiEE Dg7HY17ghYlni8XN8xYDWXahwukFAmQQUEICGwwFCQHhM4AACgkQ8xYDWXahwukm+wEA8cml4JpK NeAu65rg+auKrPOP6TP/4YWRCTIvuYDm0joBALw98AMz7/qMHvSCeU/hw9PL6u6R2EScxtpKnWof z4oM X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:261614 Archived-At: Eli Zaretskii writes: >> From: Philip Kaludercic >> Cc: Eli Zaretskii , 63337@debbugs.gnu.org >> Date: Fri, 12 May 2023 06:51:19 +0000 >> >> One issue I still notice in this case is that if the file doesn't exist, >> the issue is raised by `insert-file-contents' which aborts the entire >> installation. Does checking the existence of the file, and continuing >> on if this is not the case make sense: > > If the file's (non)existence is the problem, then checking that up > front is an okay solution, IMO. Are there any downsides to doing that? One might not notice that there was an issue with the package specification, since a number of messages are usually generated when installing a package. But I agree that this sounds better than not being able to install the package at all (as is currently the case with org-transclusion).