From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Philip Kaludercic Newsgroups: gmane.emacs.devel Subject: Re: [ELPA] New package: dict Date: Thu, 18 May 2023 12:59:42 +0000 Message-ID: <87ttw9okw1.fsf@posteo.net> References: <834joj55pt.fsf@gnu.org> <87ednnvtt6.fsf@posteo.net> <875y8ywwko.fsf@posteo.net> <83zg69br5f.fsf@gnu.org> <83ednj9sw2.fsf@gnu.org> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="22962"; mail-complaints-to="usenet@ciao.gmane.io" Cc: Eli Zaretskii , emacs-devel@gnu.org To: Eshel Yaron Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Thu May 18 15:00:49 2023 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1pzdFR-0005jU-00 for ged-emacs-devel@m.gmane-mx.org; Thu, 18 May 2023 15:00:49 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1pzdEW-0007fm-5D; Thu, 18 May 2023 08:59:52 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pzdET-0007fa-2M for emacs-devel@gnu.org; Thu, 18 May 2023 08:59:49 -0400 Original-Received: from mout01.posteo.de ([185.67.36.65]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pzdER-0000js-3k for emacs-devel@gnu.org; Thu, 18 May 2023 08:59:48 -0400 Original-Received: from submission (posteo.de [185.67.36.169]) by mout01.posteo.de (Postfix) with ESMTPS id 46B5024002A for ; Thu, 18 May 2023 14:59:43 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=posteo.net; s=2017; t=1684414783; bh=N6lppUleGU7wkwS8oHkxlpYRvycwWO7RDfDcoSSvafQ=; h=From:To:Cc:Subject:Autocrypt:Date:Message-ID:MIME-Version:From; b=kEBbo2/Ek3LZskQDyVv2CXltSmYAZD+rThgf+XgJqS2guCp5Vhxuw1XFZF+mkoX14 Q5wKka6texLgcww5YSVQDoT4enOEshnzZbemt8e9ko/0jZ3SJaoUWYNJNh6dErrsF6 eukBsFfQYTm0mPgafRfqevt0s2KnFec5alqSVCmsKY4QMp94CjYedhF3NfVpRUzep3 04MaL5v0xPlyCcC0XUbWEZeYduGA/etJ6VKUCDZQi/jUMLdMYM1ZYRR+RzAtm1GhNi kFsnC/bO/+bUmpcJy1DOpCPpxHM6vgRFaQFXvklOgydhQSKFemZX9A1Vw/SSN5aGFM skG4bDUpaqFtg== Original-Received: from customer (localhost [127.0.0.1]) by submission (posteo.de) with ESMTPSA id 4QMVRy4jqWz6txL; Thu, 18 May 2023 14:59:42 +0200 (CEST) In-Reply-To: (Eshel Yaron's message of "Mon, 15 May 2023 21:50:57 +0300") Autocrypt: addr=philipk@posteo.net; keydata= mDMEZBBQQhYJKwYBBAHaRw8BAQdAHJuofBrfqFh12uQu0Yi7mrl525F28eTmwUDflFNmdui0QlBo aWxpcCBLYWx1ZGVyY2ljIChnZW5lcmF0ZWQgYnkgYXV0b2NyeXB0LmVsKSA8cGhpbGlwa0Bwb3N0 ZW8ubmV0PoiWBBMWCAA+FiEEDg7HY17ghYlni8XN8xYDWXahwukFAmQQUEICGwMFCQHhM4AFCwkI BwIGFQoJCAsCBBYCAwECHgECF4AACgkQ8xYDWXahwulikAEA77hloUiSrXgFkUVJhlKBpLCHUjA0 mWZ9j9w5d08+jVwBAK6c4iGP7j+/PhbkxaEKa4V3MzIl7zJkcNNjHCXmvFcEuDgEZBBQQhIKKwYB BAGXVQEFAQEHQI5NLiLRjZy3OfSt1dhCmFyn+fN/QKELUYQetiaoe+MMAwEIB4h+BBgWCAAmFiEE Dg7HY17ghYlni8XN8xYDWXahwukFAmQQUEICGwwFCQHhM4AACgkQ8xYDWXahwukm+wEA8cml4JpK NeAu65rg+auKrPOP6TP/4YWRCTIvuYDm0joBALw98AMz7/qMHvSCeU/hw9PL6u6R2EScxtpKnWof z4oM Received-SPF: pass client-ip=185.67.36.65; envelope-from=philipk@posteo.net; helo=mout01.posteo.de X-Spam_score_int: -43 X-Spam_score: -4.4 X-Spam_bar: ---- X-Spam_report: (-4.4 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_MED=-2.3, RCVD_IN_MSPIKE_H2=-0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.devel:306172 Archived-At: Eshel Yaron writes: > diff --git a/lisp/net/dictionary.el b/lisp/net/dictionary.el > index ba65225692a..adf1f409f26 100644 > --- a/lisp/net/dictionary.el > +++ b/lisp/net/dictionary.el > @@ -38,6 +38,7 @@ > (require 'custom) > (require 'dictionary-connection) > (require 'button) > +(require 'help-mode) > > ;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;; > ;; Stuff for customizing. > @@ -247,6 +248,39 @@ dictionary-coding-systems-for-dictionaries > ))) > :version "28.1") > > +(defcustom dictionary-read-word-prompt "Search word" > + "Prompt string to use when prompting for a word." > + :type 'string > + :version "30.1") > + > +(defcustom dictionary-display-definition-function nil > + "Function to use for displaying dictionary definitions. > +It is called with three string arguments: the word being defined, > +the dictionary name, and the full definition." > + :type '(choice (const :tag "Dictionary buffer" nil) > + (const :tag "Help buffer" > + dictionary-display-definition-in-help-buffer) > + (function :tag "Custom function")) > + :version "30.1") > + > +(defcustom dictionary-read-word-function nil > + "Function to use for prompting for a word. > +It is called with no arguments and must return a string." > + :type '(choice (const :tag "Default" nil) > + (const :tag "Dictionary-based completion" > + dictionary-completing-read-word) > + (function :tag "Custom function")) > + :version "30.1") > + > +(defcustom dictionary-read-dictionary-function nil > + "Function to use for prompting for a dictionary. > +It is called with no arguments and must return a string." > + :type '(choice (const :tag "Default" nil) > + (const :tag "Choose among server-provided dictionaries" > + dictionary-completing-read-dictionary) > + (function :tag "Custom function")) > + :version "30.1") Would there be a point in implementing the previous, default implementations as functions here that would be invoked, instead of relying using nil? -- Philip Kaludercic