From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Michael Albinus Newsgroups: gmane.emacs.devel Subject: Re: master 400df210ce0: Fix last change of 'delete-file' Date: Fri, 11 Aug 2023 19:24:25 +0200 Message-ID: <87ttt5sd9y.fsf@gmx.de> References: <169133064669.24990.11219399079845613336@vcs2.savannah.gnu.org> <20230806140407.09E6BC038BE@vcs2.savannah.gnu.org> <875y5n6nz2.fsf@gmail.com> <83o7jfhvw3.fsf@gnu.org> <871qgb6mg9.fsf@gmail.com> <83h6p7hueg.fsf@gnu.org> <87wmy355aa.fsf@gmail.com> <83cyzvhri7.fsf@gnu.org> <87msyyt4ne.fsf@gmx.de> <83h6p5hmex.fsf@gnu.org> <87350pu7qq.fsf@gmx.de> <834jl5hj9x.fsf@gnu.org> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="11665"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Cc: rpluim@gmail.com, emacs-devel@gnu.org, esr@thyrsus.com To: Eli Zaretskii Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Fri Aug 11 19:25:29 2023 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1qUVtB-0002pU-2k for ged-emacs-devel@m.gmane-mx.org; Fri, 11 Aug 2023 19:25:29 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1qUVsK-0006LQ-UK; Fri, 11 Aug 2023 13:24:36 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qUVsJ-0006JG-3J for emacs-devel@gnu.org; Fri, 11 Aug 2023 13:24:35 -0400 Original-Received: from mout.gmx.net ([212.227.17.22]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qUVsH-0008SN-8k; Fri, 11 Aug 2023 13:24:34 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=gmx.de; s=s31663417; t=1691774667; x=1692379467; i=michael.albinus@gmx.de; bh=ejNEST3YqyvUyTwddbpJ3lQNjzH7ILBeVgwnJ1gEZaA=; h=X-UI-Sender-Class:From:To:Cc:Subject:In-Reply-To:References:Date; b=Xo1DZqotiB4kfQNKyk+1KxBf+Av4m1ExyeW+Xx9AoOA1aCRBGWv2xH3+qmtq1Kjcsf3aSpM FEbKppj1BFkAo7GXa6X/IeZ/iDAJUklr+Tma3etzUaijBvYPJCdZe2mIb7sYCJ6M5bzxwmHn6 A09ISZK92A+IvZzwqSfcp62Rzd2SXqLnKuKAw9vmo5qgZqSRYQYUwQnaz5sMBUQevgLgalw5S W5fH+E6nalraSUtDOTWlqpymHZYaD2Sd+RZwm44J268VcV4jGfy/Bx4vOo/fP1YPX8gRSloUB JBimEToNNNuBTx2qALnDKNk2EtXyatHGJJ1lnP+aOkytSH1Ekzuw== X-UI-Sender-Class: 724b4f7f-cbec-4199-ad4e-598c01a50d3a Original-Received: from gandalf.gmx.de ([185.89.39.27]) by mail.gmx.net (mrgmx105 [212.227.17.168]) with ESMTPSA (Nemesis) id 1MuUnK-1pdESn2Hha-00rbpD; Fri, 11 Aug 2023 19:24:27 +0200 In-Reply-To: <834jl5hj9x.fsf@gnu.org> (Eli Zaretskii's message of "Fri, 11 Aug 2023 15:10:18 +0300") X-Provags-ID: V03:K1:1cqdFyVsChyeb5ET6zt03+LnEERRVwLZc/WkGYyTGD3+N8CO6j3 KlwXlfjiAl7t8kV48WUVjmiwvWhcPZVe+aEf3blEGPonm05ivyDPiqHPVlNJbLQkuS9+6ii 8PUh7MBPHVJe0SGmKKiznRS04Dzx+39YF7Crrn3zL71P02kSOTNPzvVJkH43Jt/dMxmPpAY YzBrdUTXr9UGzxeN6EYYQ== UI-OutboundReport: notjunk:1;M01:P0:nrSgForaHok=;PWDyaviqjYCyS8JHKHYUCdDacB3 QcKWQBS+FUdoX4ty+C7q/tm035wd4iCuS4m5oFuGBDjwq5OyYSTX+EOGNVrXxnA3Jaz4+N56V 5Ohb+n5mIKc/BvxlnSF2OKm/bW2RY6E//XIpaMpPRrk8Dy6NBiQv6IoWtIIkblAqb45wVAYMk ApiHc2OCnpc3vR5j7kZlYlLcfRWzerlwbLPd5WlsMablAofgEOv07fOp0j0F/JnJ3tySHVlBw havF8swdQaZmaopxoyk47YlinqKGjzLLWZl4RjaIpQ4vbJrNQH45FQsEuk64xElM4g/13npuN w5L2LeXeNxE4r1epFJ7iyV9XCKlU9Mr+7p9FZYAycrU1Zlfw6PczZO8jRQ3gParUWhivNlT9Y wKnivxIB/qeKw6g24Bcnsdq0jXyvq4g5BxDms/E+4hOAQor3R0aUkFCFcVwUfmugRXaQ3JqbX paZlC1WK7p4N2N/hB7YZxPL/VjcSU41tP12p0wqtQ7nWC3Axst/rSkUODmqmwHfYT7Revs668 tFfy8jXEWTKEC7qLpAE3i7s61W8VAwPYO14NUUN/TH0j9fEECZ0hGZZCI9KRVE5s3WH2tNT4p 8gQUNitOPnC5MmuNFWgkt99euC2sWmMq8Trj8CprWYsHnOcUrmgPVZqg6Q7nBWaIEz9bnkfvo 0+tJ8b9Tv/Hv8SXhYY41FDe0bxDcjgVCXSwYPnfYFEkGnkOpX2zaskKDZjy/2tSJJy1PiTa9k rdTUmbiPkI2FEoK9wCeyMaa8A4H4MrKr55AzDmn46z59elU8JsLkC22hvJ7E7VsXxV8ast9G Received-SPF: pass client-ip=212.227.17.22; envelope-from=michael.albinus@gmx.de; helo=mout.gmx.net X-Spam_score_int: -27 X-Spam_score: -2.8 X-Spam_bar: -- X-Spam_report: (-2.8 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_LOW=-0.7, RCVD_IN_MSPIKE_H4=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.devel:308585 Archived-At: Eli Zaretskii writes: Hi Eli, > Primitives indeed _must_ call expand-file-name. And expand-file-name > does that with default-directory because it accepts a directory as its > 2nd argument, and that argument defaults to default-directory. Do you want two different versions of find-file-name-handler? One used for primitives in C core which doesn't apply expand-file-name, and another version for file operations in Lisp? > The addition of expand-file-name to delete-file made that function a > bit slower, and for local files that is a net loss. We should extend > instead find-file-name-handler to work for non-absolute file names to > avoid this overhead. It is not a recent addition, it has been there for ages. In Fdelete_file. I vaguely remember that I've tried that approach many years ago, in my early years working for Tramp. There were subtle bugs, hard to fix, because of this. But I don't remember the details. >> I wouldn't touch this as it works. Improvements in documentation might >> be appreciated. > > Indeed, the fact that find-file-name-handler needs an absolute file > name is never mentioned anywhere in the documentation. It is strange > this didn't pop up earlier. find-file-name-handler does not need an absolute file name in general. Several handlers are invoked based on the file name extensions. It are the remote file names which require absolute file names. If we add expand-file-name for cases it isn't applied yet, Emacs might become slower. And perhaps we introduce new faults by this, because everybody has arranged with the current behavior. Best regards, Michael.