From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Danny Freeman Newsgroups: gmane.emacs.devel Subject: Re: New Package for NonGNU-ELPA: clojure-ts-mode Date: Sat, 12 Aug 2023 15:12:21 -0400 Message-ID: <87ttt42gna.fsf@dfreeman.email> References: <87il9kksqz.fsf@dfreeman.email> <87a5uw9ivs.fsf@posteo.net> Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="=-=-=" Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="8914"; mail-complaints-to="usenet@ciao.gmane.io" Cc: Danny Freeman , emacs-devel , Manuel Uberti To: Philip Kaludercic Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Sat Aug 12 21:41:52 2023 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1qUuUg-00026f-G1 for ged-emacs-devel@m.gmane-mx.org; Sat, 12 Aug 2023 21:41:51 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1qUuTl-0003I4-O1; Sat, 12 Aug 2023 15:40:53 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qUuTj-0003G6-A1 for emacs-devel@gnu.org; Sat, 12 Aug 2023 15:40:51 -0400 Original-Received: from out-110.mta1.migadu.com ([95.215.58.110]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qUuTf-0007cO-JD for emacs-devel@gnu.org; Sat, 12 Aug 2023 15:40:49 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=dfreeman.email; s=key1; t=1691869244; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=NafUUreh31lDO6KBa/1E0ZFMUmUE1aV72JDcEVxNF9Q=; b=cUre2+1PxXdUdBfZZ4pvWNDrzOZ4lrmTuK8J4EQYPEQ988CLBCWVvIfmnKmJ0fpPmpwH45 QuL3nBeYKMQSt/RKXGnT01U3aJ7y/Xzolxiww/Uj7lWJMooohzEoFchjaNBtb3X7eqsntX 1YPT3WyUA965tK+0+uJ5yA5qV0imF1c= X-Report-Abuse: Please report any abuse attempt to abuse@migadu.com and include these headers. In-reply-to: <87a5uw9ivs.fsf@posteo.net> X-Migadu-Flow: FLOW_OUT Received-SPF: pass client-ip=95.215.58.110; envelope-from=danny@dfreeman.email; helo=out-110.mta1.migadu.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.devel:308630 Archived-At: --=-=-= Content-Type: text/plain Philip Kaludercic writes: > Is there a reason we wouldn't want to have support in the core? Or at > least GNU ELPA? Not all of the maintainers of clojure-mode and clojure-ts-mode are on board with the core development model, particularly copyright assignment. Initially I wanted to put this straight in the core but after some discussion we decided not to. I have personally done my copyright assignment, but for clojure-ts-mode we won't be asking contributors for it. Therefore, going into GNU ELPA or core then is out of the question. > If added to GNU ELPA and NonGNU ELPA, this would be the first *-ts-mode > package, from what I see. From what I recall, the -ts-mode approach was > a compromise to add some basic support for Tree Sitter in Emacs 29, but > I am not sure if it was a final decision on the matter, because at least > from my perspective of following the tree sitter development from a > close distance, but also from user reports I have heard of since the > release of Emacs 29, the current approach is slightly confusing. Adding > a -ts-mode to ELPA might be misinterpreted as a commitment to the > current trajectory, and I am not sure if that is intended. Yeah it is kind of confusing but I'm not sure what the end game is for all the other *-ts-modes. Non tree-sitter Clojure-mode itself has a lot of features and is also depended on by some other packages (cider, inf-clojure). In that regard, we decided trying to keep clojure-ts-mode and clojure-mode in the same repo would be too complex of a task. Therefore we put it in it's own repo. Very long term plans are for clojure-ts-mode to eventually reach feature parity with clojure-mode and start making it's consumer packages also use it. That will probably take a number of years though. >> + (clojure-ts-mode :url "https://github.com/clojure-emacs/clojure-ts-mode" >> + :ignored-files ("doc" "test") > > If possible, it is preferable to list ignored files in a .elpaignore > file, in the repository root directory. I have made a commit to the repo including one of those .elpaignores. I'm going to wait a while to tag a new release in case there is other feedback though. Here is the revised patch --=-=-= Content-Type: text/x-patch Content-Disposition: attachment; filename=0002-elpa-packages-clojure-ts-mode-new-package.patch >From baf7c0d081cbda5760c8f7523780316fcb041714 Mon Sep 17 00:00:00 2001 From: dannyfreeman Date: Sat, 12 Aug 2023 14:31:44 -0400 Subject: [PATCH] * elpa-packages (clojure-ts-mode): new package --- elpa-packages | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/elpa-packages b/elpa-packages index 9dac0cd..6ea2057 100644 --- a/elpa-packages +++ b/elpa-packages @@ -87,6 +87,10 @@ :ignored-files ("clojure-mode-extra-font-locking.el" "doc" "test" "test.clj") :news "CHANGELOG.md") + (clojure-ts-mode :url "https://github.com/clojure-emacs/clojure-ts-mode" + :readme "README.md" + :news "CHANGELOG.md") + (coffee-mode :url "https://github.com/defunkt/coffee-mode") (corfu-terminal :url "https://codeberg.org/akib/emacs-corfu-terminal") -- 2.40.1 --=-=-= Content-Type: text/plain -- Danny Freeman --=-=-=--