From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Manuel Giraud via "Bug reports for GNU Emacs, the Swiss army knife of text editors" Newsgroups: gmane.emacs.bugs Subject: bug#64791: 30.0.50; [PATCH] Fix dired mismatch on some filenames Date: Sun, 03 Sep 2023 16:04:01 +0200 Message-ID: <87ttsbbbfy.fsf@ledu-giraud.fr> References: <87sf9gozbl.fsf@ledu-giraud.fr> <83fs5g8392.fsf@gnu.org> <87lef8ovgc.fsf@ledu-giraud.fr> <835y6c7yvo.fsf@gnu.org> Reply-To: Manuel Giraud Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="18223"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Cc: Eli Zaretskii , 64791@debbugs.gnu.org To: Stefan Kangas Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Sun Sep 03 16:05:15 2023 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1qcnj0-0004WO-Rg for geb-bug-gnu-emacs@m.gmane-mx.org; Sun, 03 Sep 2023 16:05:14 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1qcnif-0008CQ-Fs; Sun, 03 Sep 2023 10:04:53 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qcnie-0008CD-FF for bug-gnu-emacs@gnu.org; Sun, 03 Sep 2023 10:04:52 -0400 Original-Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1qcnie-0002Bt-6p for bug-gnu-emacs@gnu.org; Sun, 03 Sep 2023 10:04:52 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1qcnio-0003Gw-8j for bug-gnu-emacs@gnu.org; Sun, 03 Sep 2023 10:05:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Manuel Giraud Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sun, 03 Sep 2023 14:05:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 64791 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 64791-submit@debbugs.gnu.org id=B64791.169374985912521 (code B ref 64791); Sun, 03 Sep 2023 14:05:02 +0000 Original-Received: (at 64791) by debbugs.gnu.org; 3 Sep 2023 14:04:19 +0000 Original-Received: from localhost ([127.0.0.1]:43235 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qcni7-0003Ft-FD for submit@debbugs.gnu.org; Sun, 03 Sep 2023 10:04:19 -0400 Original-Received: from ledu-giraud.fr ([51.159.28.247]:38727) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qcni4-0003Fj-0w for 64791@debbugs.gnu.org; Sun, 03 Sep 2023 10:04:17 -0400 DKIM-Signature: v=1; a=ed25519-sha256; c=simple/simple; s=ed25519; bh=4JRVrWeK +JTSBRvcW+ucSoP3Hk/48yBAAt3CuxHgJQk=; h=date:references:in-reply-to: subject:cc:to:from; d=ledu-giraud.fr; b=2LB2p3XCTGwrd8MMDpFONmnPW50nmE CxGKUFawXkTrlNNlubXToYiiyVQA3snf3/nu4RkBX/blqfvtjN7QSiDg== DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; s=rsa; bh=4JRVrWeK+JTSBRvc W+ucSoP3Hk/48yBAAt3CuxHgJQk=; h=date:references:in-reply-to:subject: cc:to:from; d=ledu-giraud.fr; b=KNrsZBL4pzB7ByveemqbWT4ouumqHPUwsgi1F8 XDXYT3J3mKisDBPKS14T+ylPWZob9YLA+nNMxP1EdkZoPTLjKNjV5PlGNFlIgdoLXFOnxQ K0gzwG5fgy533W3IrZjrxyu3dBUSYh4YN0hGHW7U2BDySQIe9LmO8/QmKB7Zbzb/J97hu0 TW6HF1honSEL/OITaiLyiNMWkeitBckM1TH4F1V8mcv4DohQRVFWQWoPEPT1LywfvVV1UP G4AUPtd5wVy/GzjD3mNyATnDwinC8HDSEi5ZXdbhC0737w+rn4jlhOt34wiOB04dC0M6pk LRb/NU6z+2A+0FXSVdS27Apg== Original-Received: from computer ( [10.1.1.1]) by ledu-giraud.fr (OpenSMTPD) with ESMTPSA id b4389808 (TLSv1.3:TLS_AES_256_GCM_SHA384:256:NO); Sun, 3 Sep 2023 16:04:03 +0200 (CEST) In-Reply-To: (Stefan Kangas's message of "Sun, 3 Sep 2023 04:34:38 -0700") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:269167 Archived-At: Stefan Kangas writes: > Eli Zaretskii writes: > >>> From: Manuel Giraud >>> Cc: 64791@debbugs.gnu.org >>> Date: Sat, 22 Jul 2023 16:46:27 +0200 >>> >>> Eli Zaretskii writes: >>> >>> > I'm not sure there can be the end to such fixes. The real fix is to >>> > use GNU 'ls' which has special support for Dired (or use ls-lisp.el). >>> > I guess you don't have GNU 'ls', since you are on OpenBSD? > > Yup. Perhaps we should consider checking for the existence of "gls" and > using that. E.g., I use the following, here: > > (if (and (memq system-type '(berkeley-unix darwin)) > (executable-find "gls")) > (setq insert-directory-program "gls")) > > But I've only tested this on macOS so far, so I'm not sure how well this > would work on *BSD. From memory, I think it should be fine. Perhaps > Manuel can say what he thinks. It would work also on OpenBSD because GNU ls is also called "gls" in the coreutils package here. BTW, Could you reproduce this bug with default ls on macOS? >>> You're right I'm using OpenBSD's ls. But I thought it was a reasonable >>> fix: it seems more obvious then looking for something that looked like a >>> file size. >> >> Maybe. Let's hear what others think about this. > > FWIW, I don't think I mind such portability fixes. It wouldn't be a bad > thing if Dired played a bit more nicely on BSD machines. Yes and I still think that this patch is reasonable even though someone is using GNU ls. It went "look for something that looks like a file size" to "go directly after column 5 where the modification is starting". I find the former more error prone than the latter. But maybe, I'm missing something about all the architectures (Unix and non-Unix) that Emacs supports. -- Manuel Giraud