From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Po Lu Newsgroups: gmane.emacs.devel Subject: Re: master 37889523278: Add new `swap` macro and use it Date: Wed, 17 Jan 2024 19:15:32 +0800 Message-ID: <87ttncw6qz.fsf@yahoo.com> References: <170452579053.27998.16123231327386305897@vcs2.savannah.gnu.org> <20240106072311.28B8FC0034E@vcs2.savannah.gnu.org> <87plye9ahs.fsf@yahoo.com> <83o7dyua0d.fsf@gnu.org> <87le9297ei.fsf@yahoo.com> <87cyue92fx.fsf@yahoo.com> <877ckm8uzz.fsf@yahoo.com> <83v886sgtl.fsf@gnu.org> <4719da9bc2bbcffdb634@heytings.org> <87bk9o1ooo.fsf@yahoo.com> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="11280"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Cc: Gregory Heytings , Eli Zaretskii , emacs-devel@gnu.org To: Stefan Kangas Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Wed Jan 17 12:16:51 2024 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1rQ3uc-0002mo-3x for ged-emacs-devel@m.gmane-mx.org; Wed, 17 Jan 2024 12:16:50 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1rQ3tm-0007uN-P5; Wed, 17 Jan 2024 06:15:59 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1rQ3th-0007u0-94 for emacs-devel@gnu.org; Wed, 17 Jan 2024 06:15:55 -0500 Original-Received: from sonic307-56.consmr.mail.ne1.yahoo.com ([66.163.190.31]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1rQ3te-0002GA-Sg for emacs-devel@gnu.org; Wed, 17 Jan 2024 06:15:52 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=yahoo.com; s=s2048; t=1705490147; bh=V8hsev/f8sqGEnlPoOfJeypGvDeh0er/UdsiVY2mQtI=; h=From:To:Cc:Subject:In-Reply-To:References:Date:From:Subject:Reply-To; b=W4EdCM1N+SuDCzFHVFAHZ2PIUMZPxdqOGc3X1cR0b9pYNq/ouWieCZZ3/a6im2aX392iNS3o4jgmhRDaf5DcdozE7b3kKvTd5Q7OTUGPb5+Q6lfoxiN8kvN0hKB2PxxoIlfVEuCPlha0kMdFw/gkI0TTIK5YRQE8NpDirOQczvaxiJjIYHvXK68cJLu+wUQ2lbSciljTj26yqkwPP1mHrwfN9vWGu1D4mM8TmcKLHNkRIwl/Tbd1NWCw98vXDlPukdv9H8CNg1HFk2MStxXoZfDETV6q/di2MxyO9lU51IMvpOjZJ0bQk2zzxTvvPvYXyLFFnreqafYOxjcTS5gZ0w== X-SONIC-DKIM-SIGN: v=1; a=rsa-sha256; c=relaxed/relaxed; d=yahoo.com; s=s2048; t=1705490147; bh=6XfPa0kUHgo9ayESZE+nrIyqaOXvo1WwJ/tNx8c1Dg3=; h=X-Sonic-MF:From:To:Subject:Date:From:Subject; b=Xe6e/R0iByM3eiOmfksfTTMguYLrWKc8nD+ETR1aapshsLXhVxfZ9pmttQIfU8w/gqSiyMV5AzI60044alsl+7VHey6kyik7gvp02yK5gprrMLCBjxfGH2n01hCcWxa/6onKVe08M2iYq8A32Qi3/e4vH/tIIqmrK1IfarFBoioEw3QRaf7GAUdSX6oCCzwoSHjk5eJe8Zb6s+KF6KWSwvGhezop8zJt879Zoao5+t92Qz5VkszkOCifip7xUJdBqMXrZ16ouMFZrgK2O3TY/rK69EiY6p0CFQcYR01nXheUCkQrWmBdnrs4x62O5NwLxYNirqwRDTmJF8K5rEUOYQ== X-YMail-OSG: 7MFBce4VM1kgfJEsWKo3Dy5efl9JPsJW_t5Ci7BQ1MZlma8ONu6LoDhkoQdWcuJ HlhB29AauMh2ni0WO9JswpQHfojTVkv2gVs2cDzdLqPOMIwLxdSufwXakJhTN0TgEU0KKjndb5iZ UcuPtgs2Gfm40yR7drNtQ2dbNmN4DvZ3Q5hE2dXz35Kaz4296ws.mP0lMEfGcT8pU1JJyyeaKg6M FgBRBApiAbG61uRENtRmGfNZ9tR3eQ6LxnLj1fwEoj3e3B9AvmmxxY7VkrcIPdRHg6FHuCw8CmRR yVjq5t6p4f6ARZcubCyOCjTnh_eXTJIpqrwc3SerpVZ.OA1BC7QTEoV3BlOfd7n3enW4P91F2BcC c6ljOLye.2L4dua9kJ1kGbLGUSJ5UtU8XJguttFDqS2Wr8iGZCzjKTjMNFttgAyy2MX3Gi3QSd2x 5c3hUg0YkGgVXJ69saDtdp82kjbC3uN3G5erKDjTUyc6cVmCyW_GO8uQGj2woXo9TCffTniuZIeW kgrQYFEZeWlDWNFqwekhs9pl35un_lGjVW5FAzxqtaXz2LLUHnQLiV.hrEEcGDw1H78zmtlQHcRx I1tYyzfdBH4Vfrzk7DSQhW_FPzfSPyS9oZ52afw1.6gUoYzJq.ecCfUBf9KvrCocnOjoCqmmMn4k XBRFmOZgRJR2HxgG4UniZ9HiCdEu.j3Lk6kEkAiZtap39z.KaPdKKK4SNlSqx8LbcVygy9NvWqCp TtMyrC_mZbpkTx1OqthrkPUURkstHpLWdEXmoTFkTgJpLIhHVQc4zbqrdj6E3un5m2Kz9DxD8XRC Sm8j95ENl6g2MY89MU1uTKgq0ZUl7cJjRfkTAMbVBg X-Sonic-MF: X-Sonic-ID: 5b7f5081-1918-4dbe-aca7-a0d6fb3d8415 Original-Received: from sonic.gate.mail.ne1.yahoo.com by sonic307.consmr.mail.ne1.yahoo.com with HTTP; Wed, 17 Jan 2024 11:15:47 +0000 Original-Received: by hermes--production-sg3-677476f564-gxjj2 (Yahoo Inc. Hermes SMTP Server) with ESMTPA ID 4918edc0927314edcb6d712c30761e32; Wed, 17 Jan 2024 11:15:40 +0000 (UTC) In-Reply-To: (Stefan Kangas's message of "Wed, 17 Jan 2024 02:16:54 -0800") X-Mailer: WebService/1.1.22010 mail.backend.jedi.jws.acl:role.jedi.acl.token.atz.jws.hermes.yahoo Received-SPF: pass client-ip=66.163.190.31; envelope-from=luangruo@yahoo.com; helo=sonic307-56.consmr.mail.ne1.yahoo.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H2=-0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=unavailable autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.devel:315030 Archived-At: Stefan Kangas writes: > BTW, we already use typeof in Emacs 29.1: > > ./src/pgtkselect.c:1158: ldata = (typeof (ldata)) data; > > This was introduced in > > commit be35c92c90d455739a6ff9d4beefa2b35d044852 > Author: Po Lu > Date: Tue Jun 21 22:03:42 2022 +0800 > > Rewrite PGTK selection code from scratch > > I don't see any problem with that, and judging by the lack of bug > reports, neither do our users. Maybe it's worth changing it to use > __typeof__. I wrote this code aware of the systems on which it would run, and the systems typeof would affect did not number among them. As regards __typeof__, I recall a comment in a GLib header to the effect that it was unusable under compilers older than GCC 4.8, so we should also avoid it in the PGTK port. > It was the C standards committee guys that wrote the above, not > Gregory. The C standards committee is not infailable, and this instance is either one where they have overlooked significant information, or where their conclusions are being taken out of context and invoked to prove a point far removed from the context they were drawn in. > I guess that wasn't a puregtk build. The PGTK build is designed for systems which run Wayland and GTK 3, namely GNU/Linux; you'll find that the same code is not present in xselect.c.