From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Po Lu Newsgroups: gmane.emacs.devel Subject: Re: discoverability, better defaults and which-key in Emacs Date: Sun, 11 Feb 2024 10:39:48 +0800 Message-ID: <87ttmf207f.fsf@yahoo.com> References: <874jetaxri.fsf@jeremybryant.net> <87r0hridvr.fsf@posteo.net> <5dd3d04c-c0eb-43fe-b7c2-957f80261ea3@gutov.dev> <87eddqiw84.fsf@posteo.net> <32071337-c91d-46ad-bb9b-10b8d0c83965@gutov.dev> <86h6ikzc38.fsf@gnu.org> <1056a72d-af5c-487e-be33-67522fe47d17@gutov.dev> <87r0hnohgv.fsf@gmail.com> <86a5obxwy9.fsf@gnu.org> <61ffccc8-56c0-4b14-9420-2d0fd9cac216@gutov.dev> <86r0hnw1l1.fsf@gnu.org> <86o7crvza4.fsf@gnu.org> <941e2791-bb35-4de6-b7a7-e3dce4938a1d@gutov.dev> <8c6f06a7-e5e3-499a-88c4-d2b035262c4d@gutov.dev> <2dab155b-05a1-4672-b327-680a683f63e4@gutov.dev> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="20281"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Cc: Eli Zaretskii , visuweshm@gmail.com, justin@burkett.cc, philipk@posteo.net, jb@jeremybryant.net, emacs-devel@gnu.org To: Dmitry Gutov Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Sun Feb 11 03:41:09 2024 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1rYzmG-00058V-R3 for ged-emacs-devel@m.gmane-mx.org; Sun, 11 Feb 2024 03:41:08 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1rYzlI-0005ON-7Q; Sat, 10 Feb 2024 21:40:08 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1rYzlF-0005O3-Nm for emacs-devel@gnu.org; Sat, 10 Feb 2024 21:40:06 -0500 Original-Received: from sonic315-21.consmr.mail.ne1.yahoo.com ([66.163.190.147]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1rYzlE-0006dN-0y for emacs-devel@gnu.org; Sat, 10 Feb 2024 21:40:05 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=yahoo.com; s=s2048; t=1707619202; bh=jtMnxdUU01QcnOGGQKOvCc/vDkCGdu09Kj1YnodMEEM=; h=From:To:Cc:Subject:In-Reply-To:References:Date:From:Subject:Reply-To; b=JH5cdibQ7857NWFbkzfwf2DvSfoL99MXUixBsujF0bajv88oFXQQa0WScAlFYhwcpLbdcBHeXBYKNYzDaYdNpPWa+BuwPfaXaikp6s6OSaOeyt1RYfTJzz8myagO4x0JXlbdESiJAo0r/uUygKkzHkmJmOOt30wFl9SiKipIOWJTTZHkUcLtMLvBNwk+sLOyjLeVOmXtbq3rLE9z8F2dHK8PX24VXP5ZzF8+BTyGEhavhjwLNdky26tK+I8gGtpE3ZAR6db2RqOTL0n3YY2DRJXNkqyqj89wltn8+GWGhgpXZ0jFIWLYwoBux0DX+RDPqAQi2EsFRYwG+vDy6s58KA== X-SONIC-DKIM-SIGN: v=1; a=rsa-sha256; c=relaxed/relaxed; d=yahoo.com; s=s2048; t=1707619202; bh=kQ0L3uUuiRbcBSaYlC5dOzEBv6Y/jxn8BwQ9YjoVnq7=; h=X-Sonic-MF:From:To:Subject:Date:From:Subject; b=csYR+lTUUU4QQ9z+EDeqVlcFbvpJDVNcPTOmEiDGmi6s8I5WYFq1AnGYANGzsV45c6OOL/LgD0NwALgjneirXk/B9tq7yr90wYiH/AyawYTpaa6MF4yuOEPPSdZflj0M+ntFvGD0UT5q03ilGwWNAY+kSo+iKcJG2/a64W7CW23AIrJAiRy2NGK2q1wbUuYnqWcOQ034OXgcqAng72JmaGfErV+5MoQ0/gZ36bstXuE6OdGdhmU8n9YyrvDkldowsAsS0/oP4CJidyg5GTEpxJA+ZAHUayyvoLW62ULrTGCI7d/+/njnTcfvQosPrnnfrcUN8mSWbSGu9MKdBDrgJg== X-YMail-OSG: HH4xPXEVM1lBQvJJszxTFJsBFT201FasaEd9z402499AXFdkTJSTx8snlsLyIkB nnpWcdOvbMza3Uk.mshGeEsu2Vq2f.2wP8zVLZVKCgI8iOYJWv6ahmoL4MDm25Axg4_P32fNIKU6 If.DNadmJE0if_AXpagRLyxpY7.cl38KKbmX2xKbOEYgerRSYj6B58zp1SjlK4axUcRjU0z9gffr dtI2lKhuWP_aUY1FHq7cuK962ARpePYuHJqYnvcRmFL4cPoDrtAbQtpWyiTDxC14mjsCtwq2JfT8 mSmBCAQZEGxGauzoYkdl2ueV5nbk7gB.b8wiOoxpiZf3jmPe3fYBX605LHOhvqHTFKFIgwPgOAAy MrOSFXPyytS8ctW3f7_Ig0ziHuEso6Gm4yFCEoYkREK11p_siLzTX5b9ciVyQXj94.B58XoqXx4l esrwAd.Oo3w9O3.G5CKquQ_ZdTZQafMWxkpk34KhC_tZ8PyWwfj4daWXrqPfW6iPTjfXIm27R8Uv 96wo465P1QsKaLBDjQ.WC6x0lGUWuU9VYfMwdKrfgZ4YEFVRlXgdtZC3p13_NyIvvLsHqyL_TiSm GwFGNYJIwGWGZeyUrMTg_WEqoATkaqnqvbfxHF76g1U8s7br0J7JF1BUeTpKHd4hmVG3xpAgAnbZ isE1A48G6hbFu.f6ZZg1LZZDBQdDAxnehoqSF26oHSBjgionMWFynXp6G.qLz1lamQ6iCGWpGhOR 378kzNBZ8XAdQIEaX1YhjirsjEX7NMvbHsXoPeoMZXRPozk_RDL4rH2zfRc72TAg5J936UuKpWVr 17Dx_OWb6ONTukYMDF1yzgt1lQ3rGTM1Fu5a3J1dNC X-Sonic-MF: X-Sonic-ID: 2dd39917-c917-4b1e-a8f0-cd6d4b06490a Original-Received: from sonic.gate.mail.ne1.yahoo.com by sonic315.consmr.mail.ne1.yahoo.com with HTTP; Sun, 11 Feb 2024 02:40:02 +0000 Original-Received: by hermes--production-sg3-6dc75bc8fb-smdnz (Yahoo Inc. Hermes SMTP Server) with ESMTPA ID 0fc84f70a0511592ea95ee4410c3593a; Sun, 11 Feb 2024 02:39:56 +0000 (UTC) In-Reply-To: <2dab155b-05a1-4672-b327-680a683f63e4@gutov.dev> (Dmitry Gutov's message of "Sun, 11 Feb 2024 04:17:21 +0200") X-Mailer: WebService/1.1.22077 mail.backend.jedi.jws.acl:role.jedi.acl.token.atz.jws.hermes.yahoo Received-SPF: pass client-ip=66.163.190.147; envelope-from=luangruo@yahoo.com; helo=sonic315-21.consmr.mail.ne1.yahoo.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H2=-0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=unavailable autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.devel:316107 Archived-At: Dmitry Gutov writes: > diff --git a/src/keyboard.c b/src/keyboard.c > index 10cdef67348..8cc1b2ec756 100644 > --- a/src/keyboard.c > +++ b/src/keyboard.c > @@ -594,14 +594,9 @@ echo_dash (void) > concat2 (KVAR (current_kboard, echo_string), dash)); > > if (echo_keystrokes_help) > - { > - Lisp_Object help; > - > - help = build_string (" (\\`C-h' or \\`' for help)"); > - kset_echo_string (current_kboard, > - concat2 (KVAR (current_kboard, echo_string), > - calln (Qsubstitute_command_keys, help))); > - } > + kset_echo_string (current_kboard, > + calln (intern_c_string ("help--append-keystrokes-help"), > + KVAR (current_kboard, echo_string))); > > echo_now (); > } Please replace the call to intern_c_string with a DEFSYM. There's no good reason not to.