From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Philip Kaludercic Newsgroups: gmane.emacs.bugs Subject: bug#69079: [PATCH] Add 'customize-toggle-option' command Date: Tue, 13 Feb 2024 20:09:46 +0000 Message-ID: <87ttmc5do5.fsf@posteo.net> References: <87frxx37wq.fsf@posteo.net> <86plx1r2uq.fsf@gnu.org> <87le7p1pg8.fsf@posteo.net> <86frxxqxzw.fsf@gnu.org> <87r0hh1aq9.fsf@posteo.net> <864jecr0z2.fsf@gnu.org> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="6604"; mail-complaints-to="usenet@ciao.gmane.io" Cc: Eli Zaretskii , 69079-done@debbugs.gnu.org To: Eshel Yaron Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Tue Feb 13 21:11:56 2024 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1rZz8G-0001UB-BG for geb-bug-gnu-emacs@m.gmane-mx.org; Tue, 13 Feb 2024 21:11:56 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1rZz7H-0004iK-Gw; Tue, 13 Feb 2024 15:10:57 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1rZz76-0004bW-Qv for bug-gnu-emacs@gnu.org; Tue, 13 Feb 2024 15:10:45 -0500 Original-Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1rZz76-0003QR-HF for bug-gnu-emacs@gnu.org; Tue, 13 Feb 2024 15:10:44 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1rZz7N-0005ab-Po for bug-gnu-emacs@gnu.org; Tue, 13 Feb 2024 15:11:01 -0500 Resent-From: Philip Kaludercic Original-Sender: "Debbugs-submit" Resent-To: bug-gnu-emacs@gnu.org Resent-Date: Tue, 13 Feb 2024 20:11:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: cc-closed 69079 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Mail-Followup-To: 69079@debbugs.gnu.org, philipk@posteo.net, philipk@posteo.net Original-Received: via spool by 69079-done@debbugs.gnu.org id=D69079.170785501521366 (code D ref 69079); Tue, 13 Feb 2024 20:11:01 +0000 Original-Received: (at 69079-done) by debbugs.gnu.org; 13 Feb 2024 20:10:15 +0000 Original-Received: from localhost ([127.0.0.1]:47651 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rZz6d-0005YW-4y for submit@debbugs.gnu.org; Tue, 13 Feb 2024 15:10:15 -0500 Original-Received: from mout02.posteo.de ([185.67.36.66]:41249) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rZz6Z-0005YF-Mg for 69079-done@debbugs.gnu.org; Tue, 13 Feb 2024 15:10:13 -0500 Original-Received: from submission (posteo.de [185.67.36.169]) by mout02.posteo.de (Postfix) with ESMTPS id EC201240104 for <69079-done@debbugs.gnu.org>; Tue, 13 Feb 2024 21:09:47 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=posteo.net; s=2017; t=1707854988; bh=t+IEBJsHernFptuwcZP0CztBc0JW+r3qYsj52/2plpg=; h=From:To:Cc:Subject:OpenPGP:Date:Message-ID:MIME-Version: Content-Type:From; b=TFf9v/xH+/2T7tiWs4J64syh732a+92cX/Oukq7cqktCHRrmpRPpWiYFvGUXHlTci 1HcAWFhlVahx2eiv8udysCLMgfmO9iqtOR60hm3PbHTG+252GS3R7GJOwADOBTHSjJ vxP+Fa49+Ggyyvfk9BKpAWo8eD+WdkGNUBGy4HOrdsNvexYnVj5DYzDhNMB7KSgaLm CqSxytIqWQATLX2KzPwB7TyNtF0O3gNGGGhbXxQ9v7S52zedoxMbuehrYFbxFsnmIE b/rHw+Ro1LYRlQHI1ErEbNhgvOErLU1bZrEe7qqFkrj8VouH2buf6F64oNqkB/WMna to+LN6083tYLw== Original-Received: from customer (localhost [127.0.0.1]) by submission (posteo.de) with ESMTPSA id 4TZC971snCz9rxP; Tue, 13 Feb 2024 21:09:46 +0100 (CET) In-Reply-To: (Eshel Yaron's message of "Tue, 13 Feb 2024 13:46:28 +0100") OpenPGP: id=7126E1DE2F0CE35C770BED01F2C3CC513DB89F66; url="https://keys.openpgp.org/vks/v1/by-fingerprint/7126E1DE2F0CE35C770BED01F2C3CC513DB89F66"; preference=signencrypt X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:279978 Archived-At: Eshel Yaron writes: > Eli Zaretskii writes: > >>> From: Philip Kaludercic >>> Cc: 69079@debbugs.gnu.org >>> Date: Tue, 13 Feb 2024 00:14:38 +0000 >>> >>> >> My assumption was that the command would only be invoked interactivly, >>> >> so I can either make that explicit with an `interactive-only' or repeat >>> >> the check. What do you think would be better? >>> > >>> > I think an explicit test is better, since then we get to display a >>> > user-friendly error message, instead of relying on Lisp errors to >>> > explain themselves. >>> > >>> > Btw, are you sure that the users can never succeed in inputting a >>> > non-boolean option with the way you prompt them? >>> >>> No, that was not ensured, and I think it is better not to. I have >>> adjusted the patch to check and prompt the user if the user option is >>> non-boolean, in case they know what they are doing. WDYT? >> >> LGTM, although I haven't tried to actually use the code. >> >> Thanks. > > FWIW, I think it'd be nice to use the as the default minibuffer argument > symbol at point, if applicable. Done and pushed.