From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Philip Kaludercic Newsgroups: gmane.emacs.devel Subject: Re: NonGNU ELPA: Conditions for accepting a potential new package 'rmsbolt' ? Date: Tue, 27 Feb 2024 17:10:18 +0000 Message-ID: <87ttltu939.fsf@posteo.net> References: <87jzmsmecw.fsf@jeremybryant.net> <877cir8yap.fsf@posteo.net> <877ciqn8wg.fsf@jeremybryant.net> <87y1b6tkk1.fsf@posteo.net> <87msrleuwd.fsf@eve> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="28019"; mail-complaints-to="usenet@ciao.gmane.io" Cc: Jeremy Bryant , "emacs-devel@gnu.org" , monnier@iro.umontreal.ca To: Jay Kamat Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Tue Feb 27 18:11:20 2024 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1rf0z9-00071u-SD for ged-emacs-devel@m.gmane-mx.org; Tue, 27 Feb 2024 18:11:20 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1rf0yK-0007oo-JJ; Tue, 27 Feb 2024 12:10:28 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1rf0yI-0007oL-Qi for emacs-devel@gnu.org; Tue, 27 Feb 2024 12:10:26 -0500 Original-Received: from mout02.posteo.de ([185.67.36.66]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1rf0yH-0007ZL-0o for emacs-devel@gnu.org; Tue, 27 Feb 2024 12:10:26 -0500 Original-Received: from submission (posteo.de [185.67.36.169]) by mout02.posteo.de (Postfix) with ESMTPS id 8DEFD240104 for ; Tue, 27 Feb 2024 18:10:20 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=posteo.net; s=2017; t=1709053820; bh=fDu6SM2QwYaeO+z6m59Uuoxb5hiIEBm3cHzOowOLKWU=; h=From:To:Cc:Subject:OpenPGP:Date:Message-ID:MIME-Version: Content-Type:Content-Transfer-Encoding:From; b=FpfJ/iozfEfcGmbmcVqZ1bkxFOg23EL3CcnHX6yx1SFAP9i8r77NYtk5iYYx6vV3t rSjKDRuTI1TaXziJuyWk5WY+xNi2JPUpIN0NkFRrwknJzwwRKwxm86DdTNLg+fN8x8 f5cWnTCDtzuanRRlS5Xn4fZbXzwu6KvS0nxX7z0oTRGZCjD9kBgp6MkjmpVeuPBVOf aXWV6HZ/XGEmwckfHlnOiJyHJL9Bzzg1bykvRGxYhNPphCBWFX0QVOMURWB3A0rhob 579chAkHyH9Qsw4L2DlOQYZqM3PqyY1xaberYftWD0ZLLxrNB4Lsgetj9HLvAqmdMZ VyQ9iD86VneWg== Original-Received: from customer (localhost [127.0.0.1]) by submission (posteo.de) with ESMTPSA id 4TkkWb0lRnz9rxG; Tue, 27 Feb 2024 18:10:18 +0100 (CET) In-Reply-To: <87msrleuwd.fsf@eve> (Jay Kamat's message of "Tue, 27 Feb 2024 08:13:57 -0800") OpenPGP: id=7126E1DE2F0CE35C770BED01F2C3CC513DB89F66; url="https://keys.openpgp.org/vks/v1/by-fingerprint/7126E1DE2F0CE35C770BED01F2C3CC513DB89F66"; preference=signencrypt Received-SPF: pass client-ip=185.67.36.66; envelope-from=philipk@posteo.net; helo=mout02.posteo.de X-Spam_score_int: -43 X-Spam_score: -4.4 X-Spam_bar: ---- X-Spam_report: (-4.4 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_MED=-2.3, RCVD_IN_MSPIKE_H4=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.devel:316593 Archived-At: Jay Kamat writes: > Philip Kaludercic writes: > > Might take me a while to fully review and test all the changes, but > they look good, so once I do so, I'll include them! > >> +(defcustom rmsbolt-mode-lighter " RMS=F0=9F=97=B2" ;could the unicode >> charachter be removed? it can unnecessarily resize the mode line. > > Sure - I can remove it. I'll do it after I apply your patch generally. Just keep in mind that I didn't send a patch. I just find it convenient to send comments in form of a diff. >> -(defun rmsbolt--convert-file-name-to-system-type (file-name) >> +(defun rmsbolt--convert-file-name-to-system-type (file-name) >> ;perhaps use `convert-standard-filename'? > > Right now, a contributor is trying to improve this area/enable tramp > support - so I'd like to keep this as stable as possible while they do > so. But this is a great suggestion - I'll let them know about this > function and hopefully it will help them in their change as well! No problem. >> >> ;;;;; Starter Definitions >> >> ;; IIUC, this "starter" business is not a necessary part of RMSBolt, bu= t is >> ;; a way to provide sample files with which users can try out RMSBolt. >> >> -(defvar rmsbolt-starter-files >> +(defvar rmsbolt-starter-files ;should this be part >> of a secondary file that isn't loaded by default? > > Maybe - I think I would load it by default though - as this is the > easiest way for someone to try out the package. In my personal usage I > almost always start from one of these files and add my changes. I > should update the comment above with that information as well. It shouldn't matter, as long as the command that uses `rmsbolt-starter-files' remains auto-loaded, even if the command is not defined in the main file. > Thanks! I just want to be doubly sure of all the changes before I > commit them, I'll try to do that testing tomorrow - I'm a bit busy > today. I'll also try to fix any remaining checkdoc errors. Thanks! > -Jay > --=20 Philip Kaludercic on peregrine