From: Philip Kaludercic <philipk@posteo.net>
To: Jay Kamat <jaygkamat@gmail.com>
Cc: Jeremy Bryant <jb@jeremybryant.net>,
"emacs-devel@gnu.org" <emacs-devel@gnu.org>,
monnier@iro.umontreal.ca
Subject: Re: NonGNU ELPA: Conditions for accepting a potential new package 'rmsbolt' ?
Date: Tue, 27 Feb 2024 17:10:18 +0000 [thread overview]
Message-ID: <87ttltu939.fsf@posteo.net> (raw)
In-Reply-To: <87msrleuwd.fsf@eve> (Jay Kamat's message of "Tue, 27 Feb 2024 08:13:57 -0800")
Jay Kamat <jaygkamat@gmail.com> writes:
> Philip Kaludercic <philipk@posteo.net> writes:
>
> Might take me a while to fully review and test all the changes, but
> they look good, so once I do so, I'll include them!
>
>> +(defcustom rmsbolt-mode-lighter " RMS🗲" ;could the unicode
>> charachter be removed? it can unnecessarily resize the mode line.
>
> Sure - I can remove it. I'll do it after I apply your patch generally.
Just keep in mind that I didn't send a patch. I just find it convenient
to send comments in form of a diff.
>> -(defun rmsbolt--convert-file-name-to-system-type (file-name)
>> +(defun rmsbolt--convert-file-name-to-system-type (file-name)
>> ;perhaps use `convert-standard-filename'?
>
> Right now, a contributor is trying to improve this area/enable tramp
> support - so I'd like to keep this as stable as possible while they do
> so. But this is a great suggestion - I'll let them know about this
> function and hopefully it will help them in their change as well!
No problem.
>>
>> ;;;;; Starter Definitions
>>
>> ;; IIUC, this "starter" business is not a necessary part of RMSBolt, but is
>> ;; a way to provide sample files with which users can try out RMSBolt.
>>
>> -(defvar rmsbolt-starter-files
>> +(defvar rmsbolt-starter-files ;should this be part
>> of a secondary file that isn't loaded by default?
>
> Maybe - I think I would load it by default though - as this is the
> easiest way for someone to try out the package. In my personal usage I
> almost always start from one of these files and add my changes. I
> should update the comment above with that information as well.
It shouldn't matter, as long as the command that uses
`rmsbolt-starter-files' remains auto-loaded, even if the command is
not defined in the main file.
> Thanks! I just want to be doubly sure of all the changes before I
> commit them, I'll try to do that testing tomorrow - I'm a bit busy
> today. I'll also try to fix any remaining checkdoc errors.
Thanks!
> -Jay
>
--
Philip Kaludercic on peregrine
next prev parent reply other threads:[~2024-02-27 17:10 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-02-25 21:07 NonGNU ELPA: Conditions for accepting a potential new package 'rmsbolt' ? Jeremy Bryant
2024-02-26 7:44 ` Philip Kaludercic
2024-02-26 22:40 ` Jeremy Bryant
2024-02-27 7:47 ` Philip Kaludercic
2024-02-27 16:13 ` Jay Kamat
2024-02-27 17:10 ` Philip Kaludercic [this message]
2024-02-27 17:14 ` Jay Kamat
2024-02-27 17:21 ` Philip Kaludercic
2024-02-27 17:21 ` Stefan Monnier
2024-02-27 17:27 ` Philip Kaludercic
2024-02-27 17:49 ` Stefan Monnier
2024-02-27 18:42 ` Philip Kaludercic
2024-02-27 19:43 ` Stefan Monnier
2024-02-27 18:46 ` Eli Zaretskii
2024-03-01 17:37 ` Jay Kamat
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87ttltu939.fsf@posteo.net \
--to=philipk@posteo.net \
--cc=emacs-devel@gnu.org \
--cc=jaygkamat@gmail.com \
--cc=jb@jeremybryant.net \
--cc=monnier@iro.umontreal.ca \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.