all messages for Emacs-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
From: Michael Albinus via "Bug reports for GNU Emacs, the Swiss army knife of text editors" <bug-gnu-emacs@gnu.org>
To: Stefan Kangas <stefankangas@gmail.com>
Cc: 71235@debbugs.gnu.org
Subject: bug#71235: Failing test on macOS: tramp-test17-dired-with-wildcards
Date: Fri, 31 May 2024 11:22:48 +0200	[thread overview]
Message-ID: <87ttie5o9j.fsf@gmx.de> (raw)
In-Reply-To: <87zfs74hxb.fsf@gmx.de> (Michael Albinus's message of "Thu, 30 May 2024 14:12:48 +0200")

[-- Attachment #1: Type: text/plain, Size: 332 bytes --]

Michael Albinus <michael.albinus@gmx.de> writes:

Hi Stefan,

> So I guess 'insert-directory-program' is "gls" in your case, but Tramp
> doesn't find it. Where is it installed? What does '(executable-find "gls")'
> return on your machine?

Could you pls check, whether the appended patch fixes the problem?

Best regards, Michael.


[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: Type: text/x-patch, Size: 875 bytes --]

diff --git a/lisp/dired.el b/lisp/dired.el
index f2a75df6ef1..c51e5e42c29 100644
--- a/lisp/dired.el
+++ b/lisp/dired.el
@@ -1710,9 +1710,10 @@ dired-insert-directory
       (cond ((and dir-wildcard (files--use-insert-directory-program-p))
              (setq switches (concat "-d " switches))
              (let* ((default-directory (car dir-wildcard))
+                    (ls (or (and remotep "ls")
+                            insert-directory-program))
                     (script (format "%s %s %s"
-                                    insert-directory-program
-                                    switches (cdr dir-wildcard)))
+                                    ls switches (cdr dir-wildcard)))
                     (sh (or (and remotep "/bin/sh")
                             (executable-find shell-file-name)
                             (executable-find "sh")))

  reply	other threads:[~2024-05-31  9:22 UTC|newest]

Thread overview: 19+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-05-27 21:32 bug#71235: Failing test on macOS: tramp-test17-dired-with-wildcards Stefan Kangas
2024-05-28  7:44 ` Michael Albinus via Bug reports for GNU Emacs, the Swiss army knife of text editors
2024-05-28 22:56   ` Stefan Kangas
2024-05-29  7:28     ` Michael Albinus via Bug reports for GNU Emacs, the Swiss army knife of text editors
2024-05-29 20:51       ` Stefan Kangas
2024-05-30  8:54         ` Michael Albinus via Bug reports for GNU Emacs, the Swiss army knife of text editors
2024-05-30 12:12     ` Michael Albinus via Bug reports for GNU Emacs, the Swiss army knife of text editors
2024-05-31  9:22       ` Michael Albinus via Bug reports for GNU Emacs, the Swiss army knife of text editors [this message]
2024-06-02 10:37         ` Stefan Kangas
2024-06-02 10:19       ` Stefan Kangas
2024-06-02 10:33         ` Michael Albinus via Bug reports for GNU Emacs, the Swiss army knife of text editors
2024-06-02 11:04           ` Stefan Kangas
2024-06-02 11:07             ` Stefan Kangas
2024-06-02 13:14             ` Michael Albinus via Bug reports for GNU Emacs, the Swiss army knife of text editors
2024-06-02 17:51               ` Stefan Kangas
2024-06-02 14:03             ` Gerd Möllmann
2024-06-02 14:23               ` Michael Albinus via Bug reports for GNU Emacs, the Swiss army knife of text editors
2024-06-02 14:46                 ` Gerd Möllmann
2024-06-02 14:55                   ` Michael Albinus via Bug reports for GNU Emacs, the Swiss army knife of text editors

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87ttie5o9j.fsf@gmx.de \
    --to=bug-gnu-emacs@gnu.org \
    --cc=71235@debbugs.gnu.org \
    --cc=michael.albinus@gmx.de \
    --cc=stefankangas@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/emacs.git
	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.