From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Philip Kaludercic Newsgroups: gmane.emacs.devel Subject: Re: [nongnu] elpa/clojure-ts-mode 649bf1120f: Improve the package version reporting Date: Tue, 04 Jun 2024 11:27:03 +0000 Message-ID: <87tti9aqyg.fsf@posteo.net> References: <171748798553.6513.6711701045751855775@vcs2.savannah.gnu.org> <20240604075945.DB087C1F9CB@vcs2.savannah.gnu.org> <878qzlcbvx.fsf@posteo.net> <871q5dc71y.fsf@posteo.net> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="8462"; mail-complaints-to="usenet@ciao.gmane.io" Cc: "Emacs Devel" To: "Bozhidar Batsov" Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Tue Jun 04 13:27:44 2024 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1sESKO-0001wc-1K for ged-emacs-devel@m.gmane-mx.org; Tue, 04 Jun 2024 13:27:44 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1sESJq-000484-G6; Tue, 04 Jun 2024 07:27:10 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1sESJo-00047H-KK for emacs-devel@gnu.org; Tue, 04 Jun 2024 07:27:08 -0400 Original-Received: from mout02.posteo.de ([185.67.36.66]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1sESJm-0004zf-Cr for emacs-devel@gnu.org; Tue, 04 Jun 2024 07:27:08 -0400 Original-Received: from submission (posteo.de [185.67.36.169]) by mout02.posteo.de (Postfix) with ESMTPS id 48AB6240103 for ; Tue, 4 Jun 2024 13:27:04 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=posteo.net; s=2017; t=1717500424; bh=Aqvbpe2a3aWXPnS+zK8fGppo6hTSz6I+x4YaCGQyaw8=; h=From:To:Cc:Subject:OpenPGP:Date:Message-ID:MIME-Version: Content-Type:From; b=m/v3aPLi/uFark2aUXtf3Pr0Zhrj1I2g3378NzcRKE1x2XjJy1wTP+Ga+usjeDhW8 8g295s4SdyBprQpP3QsWHV90TZbtzwqz+KsJMWN+LtkXD6G+m3mdNKFW4RTpBjkeSw ZangN27PwMAUQ3OIOwKW46CRkP+9RZNjvrCyFnAaP1EwJOML+TxMvCFTLDbLMWA4um Ssnr04mj563PE2y/fOJu9jXtG14lN3tvr2j+L4TocTY1ebtgdHXIVcy2++t2q1AEln GnxS79lTsHIC483l2ypIgiIOG41b0RpB9nS7NHneFCFtslo9UWis2wThUmCL/T/YD/ vEDjV3sEdY9jQ== Original-Received: from customer (localhost [127.0.0.1]) by submission (posteo.de) with ESMTPSA id 4VtpGH5LLBz9rxL; Tue, 4 Jun 2024 13:27:03 +0200 (CEST) In-Reply-To: (Bozhidar Batsov's message of "Tue, 04 Jun 2024 13:58:08 +0300") OpenPGP: id=7126E1DE2F0CE35C770BED01F2C3CC513DB89F66; url="https://keys.openpgp.org/vks/v1/by-fingerprint/7126E1DE2F0CE35C770BED01F2C3CC513DB89F66"; preference=signencrypt Received-SPF: pass client-ip=185.67.36.66; envelope-from=philipk@posteo.net; helo=mout02.posteo.de X-Spam_score_int: -43 X-Spam_score: -4.4 X-Spam_bar: ---- X-Spam_report: (-4.4 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_MED=-2.3, RCVD_IN_MSPIKE_H3=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.devel:319818 Archived-At: "Bozhidar Batsov" writes: > Pretty sure this was never the case. See the image below for details: That looks bad, but I guess if having the package on MELPA is a requirement, then this is the necessary price to pay :/ (Also, the information in that screenshot is just text, you could have just copied it into your message, then it would have been part of my response as well). > * > > On Tue, Jun 4, 2024, at 1:54 PM, Philip Kaludercic wrote: > > "Bozhidar Batsov" writes: > > > I guess you having used MELPA, right? The package versions there are > > replaced with a timestamp, so they are not very useful if they are not > > complemented by the actual version. That's why for development > > versions I'd like to see them both in the user reports. > > My understanding was that they appended the timestamp (in a decimal > encoding) to the version string? Or is that information outdated? > > > On Tue, Jun 4, 2024, at 12:09 PM, Philip Kaludercic wrote: > >> ELPA Syncer writes: > >> > >> > branch: elpa/clojure-ts-mode > >> > commit 649bf1120f10250d464d4e9ad1905b481d2e504c > >> > Author: Bozhidar Batsov > >> > Commit: Bozhidar Batsov > >> > > >> > Improve the package version reporting > >> > --- > >> > clojure-ts-mode.el | 9 +++++---- > >> > 1 file changed, 5 insertions(+), 4 deletions(-) > >> > > >> > diff --git a/clojure-ts-mode.el b/clojure-ts-mode.el > >> > index 99f28cd20a..d2be3e737c 100644 > >> > --- a/clojure-ts-mode.el > >> > +++ b/clojure-ts-mode.el > >> > @@ -54,7 +54,6 @@ > >> > > >> > ;;; Code: > >> > (require 'treesit) > >> > -(require 'lisp-mnt) > >> > > >> > (declare-function treesit-parser-create "treesit.c") > >> > (declare-function treesit-node-eq "treesit.c") > >> > @@ -71,8 +70,7 @@ > >> > :link '(emacs-commentary-link :tag "Commentary" "clojure-mode")) > >> > > >> > (defconst clojure-ts-mode-version > >> > - (eval-when-compile > >> > - (lm-version (or load-file-name buffer-file-name))) > >> > + "0.2.2" > >> > "The current version of `clojure-ts-mode'.") > >> > > >> > (defcustom clojure-ts-comment-macro-font-lock-body nil > >> > @@ -884,7 +882,10 @@ forms like deftype, defrecord, reify, proxy, etc." > >> > (defun clojure-ts-mode-display-version () > >> > "Display the current `clojure-mode-version' in the minibuffer." > >> > (interactive) > >> > - (message "clojure-ts-mode (version %s)" clojure-ts-mode-version)) > >> > + (let ((pkg-version (package-get-version))) > >> > + (if pkg-version > >> > + (message "clojure-ts-mode %s (package: %s)" clojure-ts-mode-version pkg-version) > >> > + (message "clojure-ts-mode %s" clojure-ts-mode-version)))) > >> > > >> > (defconst clojure-ts-grammar-recipes > >> > '((clojure "https://github.com/sogaiu/tree-sitter-clojure.git" > >> > >> I don't understand the point of this change. If you duplicate the > >> information of the package version anyway, then why use > >> `package-get-version' at all? The only advantage this seems to bring is > >> that if you forget to bump the version in `clojure-ts-mode-version' that > >> you can find out about the discrepancy, but then it is too late and > >> confusing. > >> > >> (Generally, I just don't think these kinds of "version information" > >> commands are really useful anymore, at least since package management > >> has become the widespread norm.) > >> > >> -- > >> Philip Kaludercic on peregrine > >> > >> > > -- > Philip Kaludercic on peregrine > -- Philip Kaludercic on peregrine