From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Robert Pluim Newsgroups: gmane.emacs.devel Subject: Re: master fa4203300fd: Merge remote-tracking branch 'origin/feature/which-key-in-core' Date: Wed, 19 Jun 2024 14:01:07 +0200 Message-ID: <87tthpxhto.fsf@gmail.com> References: <171873998859.23986.6867742580209068033@vcs2.savannah.gnu.org> <20240618194635.AC606C1FB66@vcs2.savannah.gnu.org> <8734p9z9d0.fsf@gmail.com> <878qz1l6p3.fsf@posteo.net> <87y171xqoq.fsf@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="2042"; mail-complaints-to="usenet@ciao.gmane.io" Cc: emacs-devel@gnu.org To: Philip Kaludercic Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Wed Jun 19 14:01:37 2024 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1sJu0P-0000NL-6u for ged-emacs-devel@m.gmane-mx.org; Wed, 19 Jun 2024 14:01:37 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1sJu03-0002M0-4v; Wed, 19 Jun 2024 08:01:15 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1sJu01-0002Jo-T3 for emacs-devel@gnu.org; Wed, 19 Jun 2024 08:01:13 -0400 Original-Received: from mail-wr1-x429.google.com ([2a00:1450:4864:20::429]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1sJu00-0007pV-1B for emacs-devel@gnu.org; Wed, 19 Jun 2024 08:01:13 -0400 Original-Received: by mail-wr1-x429.google.com with SMTP id ffacd0b85a97d-35f090093d8so5068995f8f.0 for ; Wed, 19 Jun 2024 05:01:11 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1718798469; x=1719403269; darn=gnu.org; h=content-transfer-encoding:mime-version:message-id:date:references :in-reply-to:subject:cc:to:from:from:to:cc:subject:date:message-id :reply-to; bh=T9ajIq7qN9SFHLfpMqg2+LGba2MPkRjerdJZYW+md+8=; b=KzGzELsJlZwClL2GLxiZ+xTR86LHwGTx+y7EAq2Z2usA3JjfpsOmIhW1NJ+EBF9S/y PZ4hPLAJAZ8RJKG3EMURz/ckCR3+hZU+5XvhvganO7TSftsw4GWymqOZdzqXbyNfsfxn qp3Zsyx+vr9RalOtu6ZxBmFRJoFy4PBNiBHxPAJsO96kvczJPiHLzGKHzqCt1athn14a MdQCgYWkTJlkgRsse9hELO3JsBBWC/VS2HTiuGPUhunTczJU1SWiT+QgsX+DeytdG0sH ibIqqL772kPNSJ7JHhO3Y98r3OD4yc4rCMdJm+e6NskK33qP/SLKG3TXNIzCC7czbjdt s1mg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1718798469; x=1719403269; h=content-transfer-encoding:mime-version:message-id:date:references :in-reply-to:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=T9ajIq7qN9SFHLfpMqg2+LGba2MPkRjerdJZYW+md+8=; b=uYFJkDQjM1uLRJfG9HKDvbOy00nzaW5uhq8WOWE6+8LZar/SudbsXBku6all8U1Kmj abEY9h0qHmnq+GHDPf3sIdSGTmHNk4Ux9YmvI50BB83dZqDMvBkkm9wUQA35Q266ygLa pKEL/aROS4oxmb5WE+nKRn2j4V7akDsUFweZX1HFCesV5cHn9ODK8tIWOqiU7a7WCY2O 2rtsJqj/bXcvCqjvc7pU8cYN74PR/clckn3unkdU9rcpEPO3cyeSrDfV01TrOLEh+8zr O+3FC6RkUltx/vYwPu9Cfg8A1JJThfZxDa2iEwhNOPKgbtsosp2e7kIt/jN2SxP6nAlU WM6A== X-Gm-Message-State: AOJu0Yz8G9RV4a04kc4xo52iVqSaNAYuhPoSzqjy2k6ty5ThoeDOm+/I 4wzTnphbi4ymZTkA6W5LJrVt0zeKBJF2jcPtvAI0BH1wfSv/lQPi0Q1/Mg== X-Google-Smtp-Source: AGHT+IE7zvN9ofYZ59NuGfbvKl/Q1XFHVzP1g87s4YcYE41IpF07DCSDCEYNPgFywDh+HadRY/n6HA== X-Received: by 2002:adf:e508:0:b0:35f:2998:f10a with SMTP id ffacd0b85a97d-363170ec90cmr2064277f8f.10.1718798469069; Wed, 19 Jun 2024 05:01:09 -0700 (PDT) Original-Received: from rltb ([82.66.8.55]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-3631488c450sm2641379f8f.60.2024.06.19.05.01.08 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 19 Jun 2024 05:01:08 -0700 (PDT) In-Reply-To: <87y171xqoq.fsf@gmail.com> (Robert Pluim's message of "Wed, 19 Jun 2024 10:49:41 +0200") Received-SPF: pass client-ip=2a00:1450:4864:20::429; envelope-from=rpluim@gmail.com; helo=mail-wr1-x429.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.devel:320288 Archived-At: >>>>> On Wed, 19 Jun 2024 10:49:41 +0200, Robert Pluim s= aid: >>>>> On Wed, 19 Jun 2024 07:42:16 +0000, Philip Kaludercic said: Philip> Robert Pluim writes: >>>>>>>> On Tue, 18 Jun 2024 15:46:35 -0400 (EDT), Philip Kaludercic said: >>>=20 Philip> + Philip> ++++ Philip> +** New package Which-Key Philip> +The 'which-key' package from GNU ELPA is now included in Emacs= . It Philip> +implements the 'which-key-mode' that displays a table of key b= indings Philip> +upon entering a partial key chord and waiting for a moment. Philip> + >>>=20 >>> This doesn=CA=BCt appear to work for the "iso-transl" key bindings,= but >>> then again I=CA=BCm not sure it should :-) Philip> I am not sure what bindings you have in mind specifically. Whi= le I Philip> don't really have a good, global understanding of which-key, I = can try Philip> to look into the issue (if it is one), if you give me something= to test. Robert> I=CA=BCm thinking of stuff like 'C-x 8 * E'. It=CA=BCs possible= to argue that Robert> doesn=CA=BCt qualify as a 'key binding', since its entire purpo= se is to Robert> enter a specific character, not run a command. This patch does it, now we just need to decide if we want to do it, and if so, should there be a user option to enable it? Perhaps `function-key-map' should not be consulted. (are we planning to turn `which-key-mode' on by default? Personally I wouldn=CA=BCt mind, but it=CA=BCs a change in default behaviour, which tend= s to annoy people) @@ -1942,8 +1949,10 @@ which-key--get-keymap-bindings =20 (defun which-key--get-current-bindings (&optional prefix filter) "Generate a list of current active bindings." - (let (bindings) - (dolist (map (current-active-maps t) bindings) + (let (bindings + (maps (nconc (current-active-maps t) + (list key-translation-map function-key-map)))) + (dolist (map maps bindings) (when (cdr map) (setq bindings (which-key--get-keymap-bindings Robert --=20