From: Philip Kaludercic <philipk@posteo.net>
To: Robert Pluim <rpluim@gmail.com>
Cc: emacs-devel@gnu.org
Subject: Re: emacs-30 768e92b9c02: Update options that depend on 'which-key-dont-use-unicode'
Date: Mon, 24 Jun 2024 15:01:24 +0000 [thread overview]
Message-ID: <87tthi2xmj.fsf@posteo.net> (raw)
In-Reply-To: <875xtybedy.fsf@gmail.com> (Robert Pluim's message of "Mon, 24 Jun 2024 16:32:09 +0200")
[-- Attachment #1: Type: text/plain, Size: 1148 bytes --]
Robert Pluim <rpluim@gmail.com> writes:
>>>>>> On Mon, 24 Jun 2024 03:46:37 -0400 (EDT), Philip Kaludercic
> <philipk@posteo.net> said:
>
> Philip> branch: emacs-30
> Philip> commit 768e92b9c0214a2aa1be2afbee48c455583d3110
> Philip> Author: Philip Kaludercic <philipk@posteo.net>
> Philip> Commit: Philip Kaludercic <philipk@posteo.net>
>
> Philip> Update options that depend on 'which-key-dont-use-unicode'
>
> Philip> * lisp/which-key.el (which-key-dont-use-unicode): Add a custom setter
> Philip> that re-evaluates a manual list of options use
> Philip> 'which-key-dont-use-unicode' to determine their default value.
>
> Philip> https://lists.gnu.org/archive/html/help-gnu-emacs/2024-06/msg00130.html
>
> This commit causes `which-key-separator' and `which-key-ellipsis' to
> be nil for me (after `which-key-mode'). Reverting this commit fixes it.
Eh, that might be because `which-key-dont-use-unicode' is being
evaluated before the other two options, but the :set function is giving
them initial values (nil), even though we haven't determined their
default value yet.
Does
[-- Attachment #2: Type: text/plain, Size: 412 bytes --]
diff --git a/lisp/which-key.el b/lisp/which-key.el
index 91007ce4ada..8b78bfb2576 100644
--- a/lisp/which-key.el
+++ b/lisp/which-key.el
@@ -133,6 +133,7 @@ which-key-dont-use-unicode
(mapc #'custom-reevaluate-setting
'(which-key-separator
which-key-ellipsis)))
+ :initialize #'custom-initialize-changed
:type 'boolean
:package-version "1.0" :version "30.1")
[-- Attachment #3: Type: text/plain, Size: 115 bytes --]
make sense? I am always uncertain which :initialize value to use.
> Robert
--
Philip Kaludercic on peregrine
next prev parent reply other threads:[~2024-06-24 15:01 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <171921519771.16563.15139426619834982564@vcs2.savannah.gnu.org>
[not found] ` <20240624074638.294E1C1FB6E@vcs2.savannah.gnu.org>
2024-06-24 14:32 ` emacs-30 768e92b9c02: Update options that depend on 'which-key-dont-use-unicode' Robert Pluim
2024-06-24 15:01 ` Philip Kaludercic [this message]
2024-06-24 17:14 ` Robert Pluim
2024-06-24 18:49 ` Philip Kaludercic
2024-07-11 9:40 ` Robert Pluim
2024-07-12 13:40 ` Philip Kaludercic
2024-07-12 14:38 ` Robert Pluim
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87tthi2xmj.fsf@posteo.net \
--to=philipk@posteo.net \
--cc=emacs-devel@gnu.org \
--cc=rpluim@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.