From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Jeremy Bryant via "Bug reports for GNU Emacs, the Swiss army knife of text editors" Newsgroups: gmane.emacs.bugs Subject: bug#71961: [PATCH] Improve tab-line-tabs-fixed-window-buffers performance Date: Sun, 07 Jul 2024 21:32:10 +0100 Message-ID: <87tth1ndth.fsf@jeremybryant.net> References: Reply-To: Jeremy Bryant Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="1267"; mail-complaints-to="usenet@ciao.gmane.io" Cc: 71961@debbugs.gnu.org, Juri Linkov To: Eval Exec Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Sun Jul 07 22:33:23 2024 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1sQYZV-00004z-G7 for geb-bug-gnu-emacs@m.gmane-mx.org; Sun, 07 Jul 2024 22:33:22 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1sQYZ8-00066C-Un; Sun, 07 Jul 2024 16:32:58 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1sQYZ8-000664-1t for bug-gnu-emacs@gnu.org; Sun, 07 Jul 2024 16:32:58 -0400 Original-Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1sQYZ7-0005lC-Pu for bug-gnu-emacs@gnu.org; Sun, 07 Jul 2024 16:32:57 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1sQYZB-000560-Um for bug-gnu-emacs@gnu.org; Sun, 07 Jul 2024 16:33:01 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Jeremy Bryant Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sun, 07 Jul 2024 20:33:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 71961 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 71961-submit@debbugs.gnu.org id=B71961.172038434919541 (code B ref 71961); Sun, 07 Jul 2024 20:33:01 +0000 Original-Received: (at 71961) by debbugs.gnu.org; 7 Jul 2024 20:32:29 +0000 Original-Received: from localhost ([127.0.0.1]:49237 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1sQYYe-000556-UN for submit@debbugs.gnu.org; Sun, 07 Jul 2024 16:32:29 -0400 Original-Received: from out-176.mta0.migadu.com ([91.218.175.176]:53876) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1sQYYc-00054m-3V for 71961@debbugs.gnu.org; Sun, 07 Jul 2024 16:32:27 -0400 X-Envelope-To: juri@linkov.net DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=jeremybryant.net; s=key1; t=1720384333; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=SuMpG8eitc4FCToRf1ZtbdUkJQrkpJ5Y9Wz52q160P4=; b=kSsZDmzbF5faBZikGHfvMS+61lRIGvItSh1ogrF8QFhHFDVy1/KzBLR70tU5speE70gMFt aKWxZjIxxtcYbvqhb9fU/VnduXXsuURSqRlQEJsIdNx+8+PUiGnFh0KrMzZWFAyIrjg/6j YcwZxlUzQTA96uLu8jqYfS3Q5EPY0skFbnC0J8NCXg+RYu9dhQi6iCz3OYCZHTvgPQ52ik BWLdr/Vz+Eww7QXKXact0+znpnpW4gq6ukZ4Rkcexe1afM6DaLJOTJuudhzCFLgSt78o0e cK6rO27HlJ+OFlLZfBOb2m1BSwnHfuZc2ahkfNdeUk5fH7SVOwoVRJ7qphDDJA== X-Envelope-To: 71961@debbugs.gnu.org X-Envelope-To: execvy@gmail.com X-Report-Abuse: Please report any abuse attempt to abuse@migadu.com and include these headers. In-Reply-To: (Eval Exec's message of "Fri, 5 Jul 2024 22:50:40 +0800") X-Migadu-Flow: FLOW_OUT X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:288572 Archived-At: Eval Exec writes: > Hello, > After noticing severe lag when `buffer-list` exceeds 1000 buffers, 1000? > particularly > with `tab-line-switch-to-prev-tab` and `tab-line-switch-to-next-tab`, > a profiler > revealed that the sorting operation in > `tab-line-tabs-fixed-window-buffers` heavily > relies on the `seq-position` function. This reliance significantly > impacts performance. > To address this, I have proposed a patch to optimize the buffer > sorting mechanism within > `tab-line-tabs-fixed-window-buffers`. The solution involves replacing > the inefficient > `seq-position` calls with a hash table to cache buffer positions, > which markedly > enhances performance when handling large buffer lists. > > This is my first attempt at hacking Emacs. Do you have any suggestions > on this idea? Adding Juri to this bug report > > Thank you > > [2. text/x-patch; 0001-Improve-tab-line-tabs-fixed-window-buffers-performan.patch]...