From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Tassilo Horn Newsgroups: gmane.emacs.bugs Subject: bug#72275: 30.0.60; [PATCH] Fix jumping to page in DocView's text contents Date: Thu, 25 Jul 2024 08:51:34 +0200 Message-ID: <87ttgeufpl.fsf@gnu.org> References: <875xsuhq3o.fsf@ledu-giraud.fr> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="1401"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) To: Manuel Giraud , 72275-done@debbugs.gnu.org Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Thu Jul 25 08:52:13 2024 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1sWsKj-000095-Dg for geb-bug-gnu-emacs@m.gmane-mx.org; Thu, 25 Jul 2024 08:52:13 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1sWsKT-0007Wf-Te; Thu, 25 Jul 2024 02:51:57 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1sWsKS-0007WD-9x for bug-gnu-emacs@gnu.org; Thu, 25 Jul 2024 02:51:56 -0400 Original-Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1sWsKS-0007Wy-1l for bug-gnu-emacs@gnu.org; Thu, 25 Jul 2024 02:51:56 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1sWsKY-0004AV-HF for bug-gnu-emacs@gnu.org; Thu, 25 Jul 2024 02:52:02 -0400 Resent-From: Tassilo Horn Original-Sender: "Debbugs-submit" Resent-To: bug-gnu-emacs@gnu.org Resent-Date: Thu, 25 Jul 2024 06:52:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: cc-closed 72275 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Mail-Followup-To: 72275@debbugs.gnu.org, tsdh@gnu.org, manuel@ledu-giraud.fr Original-Received: via spool by 72275-done@debbugs.gnu.org id=D72275.172189031416001 (code D ref 72275); Thu, 25 Jul 2024 06:52:02 +0000 Original-Received: (at 72275-done) by debbugs.gnu.org; 25 Jul 2024 06:51:54 +0000 Original-Received: from localhost ([127.0.0.1]:35210 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1sWsKP-0004A1-J8 for submit@debbugs.gnu.org; Thu, 25 Jul 2024 02:51:53 -0400 Original-Received: from eggs.gnu.org ([209.51.188.92]:38376) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1sWsKN-00049m-Hv for 72275-done@debbugs.gnu.org; Thu, 25 Jul 2024 02:51:52 -0400 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1sWsKA-0007Vr-P8; Thu, 25 Jul 2024 02:51:38 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=MIME-Version:Date:References:In-Reply-To:Subject:To: From; bh=2t0jF4D3Ixz1hqG93ncLG7W0Vzl/p4tWYWrHSqq+bvs=; b=I9B3ZrxRqLcfQxGsvWDt 0VStGdR4OXnNCOQUi6+oPVsqFcfq5z3u9TOZO+WE+KqLJJZKzIHkvCHWOuIGOEJQidLukrn5HAoIT cK2+xxnVsbbRyuYXH1l6AxaFHvH1KHd+4HSC3kdRNWeimrYJPyQuKFIYrnkqNKlvKUxFWTMgqj6Dp CPTgQEUxhyOtzIDlLz4YBFHTD2QbfWmYDlH8Rk/ra5uw1ynRIwOikV8IaizEHzJN5UNBxQOgN1ga+ nkP0468EGJ7XGg+QfFu8CFdU6dHXowKXo/2RqIMCTSlYCAx9wKw6ka2DXfBHrAYzfv0vJmZxlxTsB D6lowSGKJF0wGw==; X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgeeftddriedvgdduudegucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne cujfgurhephffvufgjfhffkfgfgggtsehttdertddtredtnecuhfhrohhmpefvrghsshhi lhhoucfjohhrnhcuoehtshguhhesghhnuhdrohhrgheqnecuggftrfgrthhtvghrnheptd dutdeugfeihedtvddtleehfeduffetfeefiefhjeejudffgedvudettdduffetnecuvehl uhhsthgvrhfuihiivgeptdenucfrrghrrghmpehmrghilhhfrhhomhepthhhohhrnhdomh gvshhmthhprghuthhhphgvrhhsohhnrghlihhthidqkeeijeefkeejkeegqdeifeehvdel kedqthhsughhpeepghhnuhdrohhrghesfhgrshhtmhgrihhlrdhfmhdpnhgspghrtghpth htoheptd X-ME-Proxy: Feedback-ID: ib2b94485:Fastmail In-Reply-To: <875xsuhq3o.fsf@ledu-giraud.fr> (Manuel Giraud's message of "Wed, 24 Jul 2024 15:33:15 +0200") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:289274 Archived-At: Manuel Giraud writes: > Poppler's "pdftotext" does not seem to enforce page delimiter at the > first column. For instance, I have documents translated with > "pdftotext" that skips the first three page starting with " ". > > In such case, using `page-delimiter' (which defaults to "^ ") to jump > to the text contents page does not work as expected. This patch fixes > this issue. Hm, it looks like that was wrong from the beginning when Lars added that in commit c1c9af312ed3 in 2019. page-delimiter never had a different default value and pdftotext always used just ^L (FORM FEED)... Looking at what other modes do, I've set page-delimiter buffer-locally to the form feed character in the new text contents buffer now, i.e., it's only fixed on master which I think is ok given that nobody except you found the issue in the last 5 years. Bye, Tassilo