From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Thierry Volpiatto Newsgroups: gmane.emacs.bugs Subject: bug#72141: 29.4; package-upgrade vs package-load-list Date: Sun, 28 Jul 2024 12:27:10 +0000 Message-ID: <87ttg9bt29.fsf@posteo.net> References: <87ikx5xulu.fsf@posteo.net> <865xsr2tn0.fsf@gnu.org> <871q3drb4v.fsf@posteo.net> Mime-Version: 1.0 Content-Type: multipart/signed; boundary="=-=-="; micalg=pgp-sha512; protocol="application/pgp-signature" Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="3144"; mail-complaints-to="usenet@ciao.gmane.io" Cc: Thierry Volpiatto , Eli Zaretskii , 72141@debbugs.gnu.org To: Philip Kaludercic Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Sun Jul 28 14:25:14 2024 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1sY2xd-0000cs-6B for geb-bug-gnu-emacs@m.gmane-mx.org; Sun, 28 Jul 2024 14:25:13 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1sY2xU-0003zd-9E; Sun, 28 Jul 2024 08:25:04 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1sY2xI-0003yt-8N for bug-gnu-emacs@gnu.org; Sun, 28 Jul 2024 08:24:54 -0400 Original-Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1sY2xH-0007Ic-EJ for bug-gnu-emacs@gnu.org; Sun, 28 Jul 2024 08:24:51 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=debbugs.gnu.org; s=debbugs-gnu-org; h=MIME-Version:Date:References:In-Reply-To:From:To:Subject; bh=TUxiQNdeUjdDqBMLYTstgPbJv+uxEicj1ctQplT4BlE=; b=NI4GHlPSYVT27HNsA7wzjlGScS4qpGjy0vB/CcSL5XvpU/qy2tgZm6UWqhCj6o9HOqFWh7rr2EgzMvijN/iclPsPeOjpmv6sKVENa5yXBa44OZPf0fS3EQNvUXd+5TO0S5/Y7rxDOr+jq7nT5W07/B8dUNcQ3OBtCCJWySSGQUhRNSGftzVrTNmy08Ycoi03mOnV0DnwTpaTmI10lfVAWiAiWk4+BEGjbRYkEmvGvtkBTNMbrh4m3ArNeVRQxsfk/Eurv6K0qEyxaDZW3CkLBWB3Vu2xOlGrXWrfNmrlTHAWhHK/0qQIzsyWyE3v4z2tPMkkKDY8GXTo8QdJRjZSwQ==; Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1sY2xS-0007Db-IW for bug-gnu-emacs@gnu.org; Sun, 28 Jul 2024 08:25:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Thierry Volpiatto Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sun, 28 Jul 2024 12:25:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 72141 X-GNU-PR-Package: emacs Original-Received: via spool by 72141-submit@debbugs.gnu.org id=B72141.172216944727669 (code B ref 72141); Sun, 28 Jul 2024 12:25:02 +0000 Original-Received: (at 72141) by debbugs.gnu.org; 28 Jul 2024 12:24:07 +0000 Original-Received: from localhost ([127.0.0.1]:42798 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1sY2wY-0007CD-F4 for submit@debbugs.gnu.org; Sun, 28 Jul 2024 08:24:06 -0400 Original-Received: from mout02.posteo.de ([185.67.36.66]:46033) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1sY2wW-0007Bh-22 for 72141@debbugs.gnu.org; Sun, 28 Jul 2024 08:24:05 -0400 Original-Received: from submission (posteo.de [185.67.36.169]) by mout02.posteo.de (Postfix) with ESMTPS id A1440240103 for <72141@debbugs.gnu.org>; Sun, 28 Jul 2024 14:23:45 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=posteo.net; s=2017; t=1722169425; bh=dZV12uHvLZLhSjquVTeqwPqTHxHMQlu80SiH4wjTsYE=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version:Content-Type: Autocrypt:OpenPGP:From; b=I3VFRtsUXtoC/gVvZvlC8jW0J53UgJ8rU/nhHbC4G8EI0/WMHc7AbZ6zL4tX+JxP8 SLNB7YbZAVGad0tNsopAHb1b5rpuj7qP8tf2Fas1V7xkmXh9/99gVXh0+al5SYzqky rLzNngwDUSbOC5ZorS/Mj1pAPyQ+HRSVKz9o8ZUqs8yQ7IMdvX0E3xTMXdwdiHtslq +jjQEUMGkfS2YCBNI31yEjQR6akz96R1aqpUd71q07qPP/SzK1fXRTmm6zX9uX0wfX 7G3CBYaHdmP//tRuxmDR3aS8EyCGqFpBoco38yW2QOk+y+FeL2x1QrN5IA6YDqkHU0 EW4i/A0u5ca4w== Original-Received: from customer (localhost [127.0.0.1]) by submission (posteo.de) with ESMTPSA id 4WX0yk6mxjz9rxL; Sun, 28 Jul 2024 14:23:42 +0200 (CEST) In-Reply-To: <871q3drb4v.fsf@posteo.net> (Philip Kaludercic's message of "Sun, 28 Jul 2024 11:47:44 +0000") Autocrypt: addr=thievol@posteo.net; prefer-encrypt=mutual; keydata=xsDNBF8ylcIBDADG+hy+zR6L4/vbdDDZuSaMmSrU3A5QZJpeBCvxTr7MpzzruZbhLPW1K3R6N2MA edi8Y+C8o27FVRIjpdbaKMGu9je7JV/TbUQYo3SOwCK1vM4LUn4V6ZLzSYkuiEt4eyMoiDdyvN0p kcK6P9x9DCetcEVszXzQg+yzCVrQ2hXWDXWT4M18EC3wtO7RHPouMqGiwBFhBAYErCqFWFxQHkfb tG/4yGyJ58rglb65O3qijjMWvYwcWZun9/7qm8Z4/4mHopmo2zgU+OrptnLSZfkZGz3Y7Uf452xQ GVq0Fv75NPvQru7y+DYVhuVXXyAmGxt+vf4rIiixMBbhKEPjcxEPAa2LTzex2IsTZR+QVG9uDnqC WcgaOEQ58fzXNvNhtwwF/Rgio2XWAJVdmFWS59/k9W58CIUSNKBMZh2XeGdEmtHvDtCxW3z6FJha 36RzOM3fMNNiAGdFZJA84gcdloJR+sHCDTTPT3784fjr+V8An7sI581NGFzkRQqPvEQCZbUAEQEA Ac0SdGhpZXZvbEBwb3N0ZW8ubmV0wsEOBBMBCgA4AhsDBQsJCAcCBhUKCQgLAgQWAgMBAh4BAheA FiEEI9twfRN7r3nig/xwDsVtFB0W75MFAmL3HCoACgkQDsVtFB0W75OVEAv/f6XxmtIFz08fUb8h Bp/zJP6IC4/rhhh+0GMRIRzLN8DK0jV8JCzYdFHiRJOy2lNIOpmrrCmjRRxferc2G42+ePFIsslx hU46VSz1Z83NwIG3mpdYNV5WUTUdgzxExHTNTFCd7NKv0nlHKQaA OpenPGP: url=https://posteo.de/keys/thievol@posteo.net.asc; preference=encrypt X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:289466 Archived-At: --=-=-= Content-Type: text/plain Content-Transfer-Encoding: quoted-printable Philip Kaludercic writes: > Eli Zaretskii writes: > >>> From: Thierry Volpiatto >>> Date: Tue, 16 Jul 2024 14:46:37 +0000 >>>=20 >>>=20 >>> I think there is a bug here, but please verify with following recipe as >>> I don't use widely package installation, at least for myself. When rea= ding >>> the code I believe it is reproductible as well on emacs-30+. >>>=20 >>> 1) Install package foo and bar. >>> 2) Disable them in package-load-list ((foo nil) (bar nil) all). >>> 3) Wait some time until foo and/or bar have new versions available. >>> 4) Call package-upgrade-all. It will call package-upgrade on foo >>> and bar (and possibly others). When package-upgrade find foo >>> package it will (1) delete it and (2) call package-install which >>> will refuse to install (error) because foo is disabled. >>>=20 >>> As a result we have lost foo package, it is now uninstalled. >>> Same problem with M-x package-upgrade, foo and bar are listed in >>> completion and made available whereas they are going to fail to >>> upgrade. >> >> Philip, any comments or suggestions? > > The issue is that we don't install a package if it is disabled. So > either we allow installing (but don't activate) disabled packages, or we > ignore disabled packages during upgrades. That might just need this > change: > > diff --git a/lisp/emacs-lisp/package.el b/lisp/emacs-lisp/package.el > index 7cae8d68bc0..eb77d99fad2 100644 > --- a/lisp/emacs-lisp/package.el > +++ b/lisp/emacs-lisp/package.el > @@ -2286,6 +2286,9 @@ package--upgradeable-packages > (or (let ((available > (assq (car elt) package-archive-contents))) > (and available > + (package-disabled-p > + (cadr elt) > + (package-desc-version (cadr elt))) > (or (and > include-builtins > (not (package-desc-version (cadr elt)))) If nothing in package.el or elsewhere relay on the fact that package--upgradeable-packages returns the disabled packages that looks good. Also why in this function you are using (mapcar 'car (seq-filter ...))? Perhaps one loop could be avoided here? (just asking, I am not familiar with seq, I don't use it). Thanks. =2D-=20 Thierry --=-=-= Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQHHBAEBCgAxFiEEI9twfRN7r3nig/xwDsVtFB0W75MFAmamOR4THHRoaWV2b2xA cG9zdGVvLm5ldAAKCRAOxW0UHRbvk7a/C/0e0lP4+V50PmWKp9wjmCgeF1cz/CPS cRlx37WyczfLHrH1IB3k/PvBRPIKzkY3LJZrR9MiiHVFB5/pqDUYdmznXBIMcbiU yhBYB7aZG/FAHJn/P8dIzLHIC4EI9QOdEKf91lbrWbLDjXl6PApJw9rSgAcoJgS2 mYuQlj9NcKPzB+xxJ8NbtgGvmYZwgnnf1o1A9xLqYvHhcJG/MlvbUm/Cz+wImgoX sngAihiVg+dh48GJZLwStzPpb7IrUPvfKt8lD6DSu/1+LPG37FpGp2/kUbn9G1gW cl145ZgEaLsfRh0PrY+oA5VsnkAfyxeSP4ZIB9h033cnT2dBGL2gbN5Gn4eLcTgG AH0IM0cHh13BNpJrEF3iYcd624rAgfvU9fzc36XJqMJsTDslpQOm6VH3wisDjO29 4p836UH8p3aJkrNUSqUMrf9pJd/k+VO//FVJzYJFZI0zJLxj/0WRG74A2s5LVpPj UKC2vbwqq4dDqk5BgXGEVs857VGENdwnV9Y= =N6tq -----END PGP SIGNATURE----- --=-=-=--