From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Philip Kaludercic Newsgroups: gmane.emacs.devel Subject: Re: [PATCH] add compiled regexp primitive lisp object Date: Tue, 30 Jul 2024 13:02:40 +0000 Message-ID: <87ttg7qbgv.fsf@posteo.net> References: Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="3917"; mail-complaints-to="usenet@ciao.gmane.io" Cc: "emacs-devel@gnu.org" To: Danny McClanahan Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Tue Jul 30 15:59:33 2024 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1sYnO0-0000r7-VO for ged-emacs-devel@m.gmane-mx.org; Tue, 30 Jul 2024 15:59:33 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1sYn6w-0000Sa-GJ; Tue, 30 Jul 2024 09:42:07 -0400 Original-Received: from [2001:470:142:3::10] (helo=eggs.gnu.org) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1sYn6B-0000PN-Be for emacs-devel@gnu.org; Tue, 30 Jul 2024 09:41:13 -0400 Original-Received: from [185.67.36.66] (helo=mout02.posteo.de) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1sYn5L-0006h2-Ix for emacs-devel@gnu.org; Tue, 30 Jul 2024 09:40:46 -0400 Original-Received: from submission (posteo.de [185.67.36.169]) by mout02.posteo.de (Postfix) with ESMTPS id C2572240101 for ; Tue, 30 Jul 2024 15:02:41 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=posteo.net; s=2017; t=1722344561; bh=CNB5kH6MnltuC5Z41m7qUZKc8YbtD6JnVeMjKGFvHsw=; h=From:To:Cc:Subject:Autocrypt:OpenPGP:Date:Message-ID:MIME-Version: Content-Type:From; b=ax1wlIXj/OzynrHSm10DxTa6tV4ZA0fVqRm0dKHWuHKafGnvNlCLlIerspL4JjjtR vZlBsEaVIwu0Rqh41bd1hqlXKDziKUYfJCF8tR8nhZ5Qh+m3D1feK8o74aIgcofqUb 7510bNZCu1YdxKHYj1bzbivXeK6h2HKMFeDCA/pFopn6444P1PIT0TLrV3+baO/wTH m2t3VpnmhYzyHJNq1qyIlRJlGI4gAkWLIgYMms0mbbn/4u1P3+U2+jMlpGC/dWYnZM KZXGqFWoNr42T+xwJqDjX/HMxsIvPBRoi5XPJz9vuIJoUlbHScNWwlWtsSVzDQBGLX uZJY6Awn/Ovpw== Original-Received: from customer (localhost [127.0.0.1]) by submission (posteo.de) with ESMTPSA id 4WYFkn06Xnz6tyY; Tue, 30 Jul 2024 15:02:40 +0200 (CEST) In-Reply-To: (Danny McClanahan's message of "Tue, 30 Jul 2024 05:08:28 +0000") Autocrypt: addr=philipk@posteo.net; keydata= mDMEZBBQQhYJKwYBBAHaRw8BAQdAHJuofBrfqFh12uQu0Yi7mrl525F28eTmwUDflFNmdui0QlBo aWxpcCBLYWx1ZGVyY2ljIChnZW5lcmF0ZWQgYnkgYXV0b2NyeXB0LmVsKSA8cGhpbGlwa0Bwb3N0 ZW8ubmV0PoiWBBMWCAA+FiEEDg7HY17ghYlni8XN8xYDWXahwukFAmQQUEICGwMFCQHhM4AFCwkI BwIGFQoJCAsCBBYCAwECHgECF4AACgkQ8xYDWXahwulikAEA77hloUiSrXgFkUVJhlKBpLCHUjA0 mWZ9j9w5d08+jVwBAK6c4iGP7j+/PhbkxaEKa4V3MzIl7zJkcNNjHCXmvFcEuDgEZBBQQhIKKwYB BAGXVQEFAQEHQI5NLiLRjZy3OfSt1dhCmFyn+fN/QKELUYQetiaoe+MMAwEIB4h+BBgWCAAmFiEE Dg7HY17ghYlni8XN8xYDWXahwukFAmQQUEICGwwFCQHhM4AACgkQ8xYDWXahwukm+wEA8cml4JpK NeAu65rg+auKrPOP6TP/4YWRCTIvuYDm0joBALw98AMz7/qMHvSCeU/hw9PL6u6R2EScxtpKnWof z4oM OpenPGP: id=philipk@posteo.net; url="https://keys.openpgp.org/vks/v1/by-email/philipk@posteo.net"; preference=signencrypt X-Host-Lookup-Failed: Reverse DNS lookup failed for 185.67.36.66 (deferred) Received-SPF: pass client-ip=185.67.36.66; envelope-from=philipk@posteo.net; helo=mout02.posteo.de X-Spam_score_int: -31 X-Spam_score: -3.2 X-Spam_bar: --- X-Spam_report: (-3.2 / 5.0 requ) BAYES_00=-1.9, DKIM_INVALID=0.1, DKIM_SIGNED=0.1, RCVD_IN_DNSWL_MED=-2.3, RCVD_IN_MSPIKE_H3=-0.01, RCVD_IN_MSPIKE_WL=-0.01, RDNS_NONE=0.793, T_SPF_HELO_TEMPERROR=0.01, T_SPF_TEMPERROR=0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.devel:322211 Archived-At: Danny McClanahan writes: > This is a first attempt at a lisp-level API for explicit regexp > compilation. I have provided the entire diff inline in this email > under the impression that this will make it easier to discuss the > specifics--I do apologize if diffs above a certain size should > always be attached as patch files in the future. > > The result of this change is that pre-compiled regexp objects constructed by > `make-regexp' will have the lifetime of standard lisp objects, instead of > being potentially invalidated and re-compiled upon every call to `string-match'. No comments on the patch from me, I am just curious, did you notice any performance improvements? Or is this just cleaning up the codebase? -- Philip Kaludercic on peregrine