From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Stephen Berman via "Bug reports for GNU Emacs, the Swiss army knife of text editors" Newsgroups: gmane.emacs.bugs Subject: bug#72404: 30.0.60; Customization of options is broken Date: Thu, 01 Aug 2024 19:28:04 +0200 Message-ID: <87ttg48863.fsf@gmx.net> References: <86a5hxv6cp.fsf@mail.linkov.net> <86frrpxws9.fsf@gnu.org> <87le1hs1s2.fsf@pub.pink> <867cd0ygkf.fsf@gnu.org> <878qxga6vv.fsf@gmx.net> Reply-To: Stephen Berman Mime-Version: 1.0 Content-Type: text/plain Content-Transfer-Encoding: quoted-printable Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="12983"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Cc: 72404@debbugs.gnu.org, john muhl , maurooaranda@gmail.com, juri@linkov.net To: Eli Zaretskii Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Thu Aug 01 19:29:15 2024 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1sZZc2-0003Eb-TE for geb-bug-gnu-emacs@m.gmane-mx.org; Thu, 01 Aug 2024 19:29:15 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1sZZbd-0002C6-2V; Thu, 01 Aug 2024 13:28:49 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1sZZba-0002Bf-Aj for bug-gnu-emacs@gnu.org; Thu, 01 Aug 2024 13:28:46 -0400 Original-Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1sZZba-0005KH-1V for bug-gnu-emacs@gnu.org; Thu, 01 Aug 2024 13:28:46 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=debbugs.gnu.org; s=debbugs-gnu-org; h=MIME-Version:Date:References:In-Reply-To:From:To:Subject; bh=TepLuylHa2Fsc4ga8+AH2qFgVzN0wGrKBLyiqDOyFno=; b=EXwNyWK1NNrUckRd8kVK5Xq8i/bMUAI/Mu4HxFY6g57cKIeDKl2x6glpDZsEAAxItjb7mJYK5sgRm2upTztsCTVgJSuJwaacZrEGLxtOjdpe+ruzAs2Cp1vGv/kuTai4UXSvgHvVzOL/Nv8s0J2GSAOmi+v6rSATFbZyhQFQK++boIp8w9/uKYipG2x/1Uum0te+v1hvsa4fgcEnqr9fbx4Bflrstp6EtU5Kz00+pYCFMyZEjvqUvzSKOSbxB32UGXco2P5wF0Pi1Ukp11BlWXBsDn4f+1s3M2NVCkQi5q0QyrN3/QD6aVVvnTPIOhXa6qFzMz3bUgGyN4fD6o5W0w==; Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1sZZbq-0002o1-CJ for bug-gnu-emacs@gnu.org; Thu, 01 Aug 2024 13:29:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Stephen Berman Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Thu, 01 Aug 2024 17:29:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 72404 X-GNU-PR-Package: emacs Original-Received: via spool by 72404-submit@debbugs.gnu.org id=B72404.172253331810748 (code B ref 72404); Thu, 01 Aug 2024 17:29:02 +0000 Original-Received: (at 72404) by debbugs.gnu.org; 1 Aug 2024 17:28:38 +0000 Original-Received: from localhost ([127.0.0.1]:51921 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1sZZbS-0002nH-0G for submit@debbugs.gnu.org; Thu, 01 Aug 2024 13:28:38 -0400 Original-Received: from mout.gmx.net ([212.227.15.19]:58019) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1sZZbN-0002my-MF for 72404@debbugs.gnu.org; Thu, 01 Aug 2024 13:28:36 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmx.net; s=s31663417; t=1722533285; x=1723138085; i=stephen.berman@gmx.net; bh=TepLuylHa2Fsc4ga8+AH2qFgVzN0wGrKBLyiqDOyFno=; h=X-UI-Sender-Class:From:To:Cc:Subject:In-Reply-To:References:Date: Message-ID:MIME-Version:Content-Type:Content-Transfer-Encoding:cc: content-transfer-encoding:content-type:date:from:message-id: mime-version:reply-to:subject:to; b=A0TJoiJc4dKMdE5B+zRj7IbBbYTXxgszUHjHlDJR67/p0PkhSg1Pm+zuGU0XcxX+ rZHbzv3sfVTRhxPCCPjjTcG87iy1xr7N2bfVtvAM+1ApWM6Or4dkl4rf1eIgrrBFa 298hDPf4J11NWB+/8YYqdEzcPuFhDfbOb6MqHUFT6bPMfGpRrVysKO6dBDXLgXFvD Lqy+FOAoA8d0iD/wAe55cbge9gDnxknfGCjsEwbjFPtx+NOEnm6ST5fyx+twx9mMQ uer75JB+kjRuXim3e7SWnpdmPqKyjOlBDHLJKPt9U/k+UY82WdpKM6T8o5aHhVMV+ /cx8ubI8PCKX40lQsg== X-UI-Sender-Class: 724b4f7f-cbec-4199-ad4e-598c01a50d3a Original-Received: from strobelfs ([94.134.94.179]) by mail.gmx.net (mrgmx005 [212.227.17.190]) with ESMTPSA (Nemesis) id 1M8QWA-1sdzRl1DWa-004E61; Thu, 01 Aug 2024 19:28:05 +0200 In-Reply-To: <878qxga6vv.fsf@gmx.net> (Stephen Berman's message of "Thu, 01 Aug 2024 12:12:52 +0200") X-Provags-ID: V03:K1:8aN4ukL7tBTVhowoYjEEZ5DCG19tZUwmbbQCEuxeCBpZz3dASOv 77HmzYtQpkL6P6t49lcIiuRZ4PuV9FuP+IF16YlAljQr1JGjaBBO/+qb83oSFU25NFXWyaw 1FAfAk7k3N4x8baes28k6/vS7gByaQgSOC3B+zYQXBBsoVgEzc8dSsoP8Xww/qGhNSu9zsT SNQhox5hOIIichqvx+aZQ== UI-OutboundReport: notjunk:1;M01:P0:BzzB6lMqz24=;ddHxbSry/bJ5JE5aD+n89U7w9ZD ZOPTGQBHp0AQZGbwGoDnUdNSuQ0kwRUYEXCwRgMMXvgGEGLJk4xD1hWUdi96CrIiMnDhBvV17 EQOKGjeu8XQf6ouBHyANaKlPLDqVyFylAPHBojTzwybfUuTv3x5tDR4+5oNh6azDhYqTqR0cb Zz/ek5Gx7E2jjxa+hnfa8FnZQVrPq+4fB3Uhozv3gV1fwqqNAFfilcVQCGrsL/Sc4x+ar0M8J NupUdiDlQfX4C4pSMLtO+27rEsez88pr6uZCpv3dDFEcP8HirnSsZvN2UFyQYcvcHFGNhHLDr YwYnMRb3e6s8hHOEt3ZjjBezKaphM1D6wgeV0nlCZLez4eK2cIrdUjfZCie1/Qhzs2JtexTsY 3qJMtzWGIzgU0eRBBjhtivg/G+PVDW3GjBM9RgBHqawAGnM4DFsArD/wFCxhxAHW4QEMxY5Zh WZJaM4v/NTwDh6KWhghAVqxrS7X4WqI9dodDxjlWi/FeAk1/SqTk3L0/o2braBGC1wn1cF7OE i7KVvUh2H92XNwYyJ3ygZoejVdgIFwYHW7zcOcb/EHsmgnp9NhLsi2d/79KpZ41Mfyn3HgZYc lsDM/bw7hxgJ82hHQXBbHx+1VKGsTvqIEVnXT1G8Li9UvD+vApLdOSUPkjfUgyH+GPokGwu6T BgEfdsTeGH5ONSFoTQE+pQIuBfpq7g+tP33Xcf25bD8A+gT5luB4WcrmcmXoQTA73vUAosmLL AhP7cBjGf8Ql3CE6eNB9LBi4jCTef41ffSawMzpDbwTuC3lt7YThVn7QDkEIuDqwSXL8hHGO X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:289621 Archived-At: On Thu, 01 Aug 2024 12:12:52 +0200 Stephen Berman = wrote: > On Thu, 01 Aug 2024 08:09:52 +0300 Eli Zaretskii wrote: > >>> From: john muhl >>> Cc: Juri Linkov , Mauro Aranda , >>> 72404@debbugs.gnu.org, stephen.berman@gmx.net >>> Date: Wed, 31 Jul 2024 15:18:46 -0500 >>> >>> Eli Zaretskii writes: >>> >>> >> 0. emacs-30 -Q >>> >> 1. Eval: (require 'log-edit) >>> >> 2. Check the value of 'log-edit-hook'. >>> >> Its value is >>> >> (log-edit-insert-message-template log-edit-insert-cvs-template l= og-edit-insert-changelog log-edit-show-files) >>> >> 3. M-x customize-variable RET log-edit-hook RET >>> >> 4. Click the checkbox to enable 'log-edit-insert-cvs-rcstemplate'. >>> >> 5. Apply >>> >> 6. Check the value of 'log-edit-hook'. >>> >> Its value is (log-edit-insert-cvs-rcstemplate) >>> >> >>> >> In GNU Emacs 30.0.60 (build 1, x86_64-pc-linux-gnu, X toolkit, >>> >> cairo version 1.16.0, Xaw3d scroll bars) of 2024-07-31 >>> >> Repository revision: ceb5a1522270c41d0c9f5e6b52d61e3173f72f1d >>> >> Repository branch: emacs-30 >>> >> Windowing system distributor 'The X.Org Foundation', version 11 >>> >> Configured using: 'configure --with-native-compilation --with-x-too= lkit=3Dlucid' >>> >> >>> >> Whereas in GNU Emacs 29.3.50 it was correctly changed to >>> >> (log-edit-insert-message-template log-edit-insert-cvs-rcstemplate >>> >> log-edit-insert-cvs-template log-edit-insert-changelog log-edit-sho= w-files) >>> > >>> > Thanks. Bisection would be useful, I think. >>> > >>> > Adding Mauro, in case he has some ideas or even fixes. >>> >>> Reverting 8d354925ddb fixes it here. >> >> Thanks! >> >> Stephen, please look at this ASAP, as this sounds like a serious >> and very recent regression. > > I took a look and tried stepping through with Edebug, but so far could > not find out how my changes in that commit cause the regression. I > won't have time for further debugging until next week, and given my > unfamiliarty with the widget and custom code (I didn't even know about > :options till now), I may well not be able to fix this. Feel free to > revert the commit in the mean time. It would also be good to have a > test for this case (in emacs-30 with the commit all widget and custom > tests pass). I did happen to have a bit more time for this problem, and I think I've found the cause, a single line in commit 8d354925ddb: diff --git a/lisp/wid-edit.el b/lisp/wid-edit.el index 693991a6f3e..aa653549dad 100644 =2D-- a/lisp/wid-edit.el +++ b/lisp/wid-edit.el @@ -2549,7 +2549,8 @@ widget-checklist-add-item (t (widget-create-child-value widget type (car (cdr chosen))) - (widget-specify-selected child))))) + ;; (widget-specify-selected child) + )))) (t (error "Unknown escape `%c'" escape))))) ;; Update properties. With this line commented out as in the above patch, I get the expected value when carrying out Juri's recipe. Moreover, after making that change, I then briefly tested customizing the face widget-unselected (which the problematic commit added) to inherit from the default face and it shows the labels of unselected check boxes in the default face, as it should. So maybe deleting the commented out line above and leaving the rest of the change is a sufficient fix. But I have to admit I don't know why that line causes the problem, and I haven't done enough testing of this change to the widget-unselected face feature, so this is just a status report. Steve Berman