From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Tassilo Horn Newsgroups: gmane.emacs.devel Subject: Re: No NEWS entry for doc-view-mupdf-use-svg (Emacs 30.0.91 feedback) Date: Mon, 23 Sep 2024 20:35:32 +0200 Message-ID: <87tte6b4ln.fsf@gnu.org> References: <87cyky43fb.fsf@ice9.digital> <86setu5f85.fsf@gnu.org> <87zfo22jy4.fsf@ice9.digital> <86bk0h5sx9.fsf@gnu.org> <87ldzlgxvh.fsf@ice9.digital> <87msk0oqoq.fsf@gnu.org> <87plovmmox.fsf@ice9.digital> <8734lqzx64.fsf@gnu.org> <877cb2kbta.fsf@ledu-giraud.fr> <8634lqh9bt.fsf@gnu.org> <87msjyv2xb.fsf@gnu.org> <86msjyfkn3.fsf@gnu.org> <87tte64ah1.fsf@gnu.org> <87setqgsp5.fsf@ledu-giraud.fr> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="31363"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: mu4e 1.12.6; emacs 31.0.50 Cc: Manuel Giraud , Eli Zaretskii , morgan@ice9.digital, visuweshm@gmail.com To: Manuel Giraud via "Emacs development discussions." Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Mon Sep 23 20:36:31 2024 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1ssnvC-0007y3-Et for ged-emacs-devel@m.gmane-mx.org; Mon, 23 Sep 2024 20:36:30 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1ssnuQ-0005qf-4c; Mon, 23 Sep 2024 14:35:42 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1ssnuO-0005qF-Ea for emacs-devel@gnu.org; Mon, 23 Sep 2024 14:35:40 -0400 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1ssnuL-00069M-VQ; Mon, 23 Sep 2024 14:35:37 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=MIME-Version:Date:References:In-Reply-To:Subject:To: From; bh=sKXcNuAhOzImqMyVLxFT3szOuNc3wBxbkTMCETe7ui8=; b=gUk95He6PZ2/Az9oJc5Z uJk9z/S8KYiLUm0o4/VEyUNWTiOHI4hewO5jkhJihWzy2cy4HH+WYOhBq1UllvTQW8k69v1/h4OsR HAsILXJezc8pOK8Ws0er8VGGWv4431npOTUxN9IP89wsGrfAb0e3ef5kdZ2EWlr3GvlRpYpuofSN0 TNeLI2IZD7zsjPmh+ljhA0hpaROMuy1IGT1wqx442H7FQR6Ps119aJaZoQUSrWLF9UOpmzJF8zfDO zgZAVWu6WxSlUQKkDg7NG1Popw1q1HShtos96Th8gutPOVKesZBdUGKDkX0b+0vnh7eF7+aPzQt5C TaX9bIdnGqAgIQ==; X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgeeftddrudelledguddvjecutefuodetggdotefrod ftvfcurfhrohhfihhlvgemucfhrghsthforghilhdpggftfghnshhusghstghrihgsvgdp uffrtefokffrpgfnqfghnecuuegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivg hnthhsucdlqddutddtmdenucfjughrpefhvfevufgjfhgffffkgggtsehttdertddtredt necuhfhrohhmpefvrghsshhilhhoucfjohhrnhcuoehtshguhhesghhnuhdrohhrgheqne cuggftrfgrthhtvghrnhepleduvdegfeduvdejkeefteelgeetgfevhefhueffueffgeeh gfeufefgvdffgedtnecuvehluhhsthgvrhfuihiivgeptdenucfrrghrrghmpehmrghilh hfrhhomhepthhhohhrnhdomhgvshhmthhprghuthhhphgvrhhsohhnrghlihhthidqkeei jeefkeejkeegqdeifeehvdelkedqthhsughhpeepghhnuhdrohhrghesfhgrshhtmhgrih hlrdhfmhdpnhgspghrtghpthhtohephedpmhhouggvpehsmhhtphhouhhtpdhrtghpthht ohepvhhishhufigvshhhmhesghhmrghilhdrtghomhdprhgtphhtthhopehmohhrghgrnh esihgtvgelrdguihhgihhtrghlpdhrtghpthhtohepvghlihiisehgnhhurdhorhhgpdhr tghpthhtohepmhgrnh X-ME-Proxy: Feedback-ID: ib2b94485:Fastmail In-Reply-To: <87setqgsp5.fsf@ledu-giraud.fr> (Manuel Giraud via's message of "Mon, 23 Sep 2024 19:56:06 +0200") X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.devel:323992 Archived-At: Manuel Giraud via "Emacs development discussions." writes: Hi Manuel, >> -(defface doc-view-svg-face '((t :inherit default)) >> +(defface doc-view-svg-face '((t :inherit default >> + :background "white" >> + :foreground "black")) > > Since this face is used only for its foreground and background colors, > I think you could leave the :inherit. I know. But that makes it slightly easier to turn on styling by theme. Or, well, having both nil without inheriting has the same effect, but as you have said, explicit is better. I agree with that, so I kept it on purpose. Bye, Tassilo