From: Tassilo Horn <tsdh@gnu.org>
To: Manuel Giraud via "Emacs development discussions." <emacs-devel@gnu.org>
Cc: Manuel Giraud <manuel@ledu-giraud.fr>,
Eli Zaretskii <eliz@gnu.org>,
morgan@ice9.digital, visuweshm@gmail.com
Subject: Re: No NEWS entry for doc-view-mupdf-use-svg (Emacs 30.0.91 feedback)
Date: Mon, 23 Sep 2024 20:35:32 +0200 [thread overview]
Message-ID: <87tte6b4ln.fsf@gnu.org> (raw)
In-Reply-To: <87setqgsp5.fsf@ledu-giraud.fr> (Manuel Giraud via's message of "Mon, 23 Sep 2024 19:56:06 +0200")
Manuel Giraud via "Emacs development discussions." <emacs-devel@gnu.org> writes:
Hi Manuel,
>> -(defface doc-view-svg-face '((t :inherit default))
>> +(defface doc-view-svg-face '((t :inherit default
>> + :background "white"
>> + :foreground "black"))
>
> Since this face is used only for its foreground and background colors,
> I think you could leave the :inherit.
I know. But that makes it slightly easier to turn on styling by theme.
Or, well, having both nil without inheriting has the same effect, but as
you have said, explicit is better. I agree with that, so I kept it on
purpose.
Bye,
Tassilo
next prev parent reply other threads:[~2024-09-23 18:35 UTC|newest]
Thread overview: 33+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-09-20 17:53 No NEWS entry for doc-view-mupdf-use-svg (Emacs 30.0.91 feedback) Morgan Willcock
2024-09-20 18:53 ` Eli Zaretskii
2024-09-20 19:34 ` Visuwesh
2024-09-20 19:39 ` Morgan Willcock
2024-09-20 22:29 ` chad
2024-09-20 22:46 ` Morgan Willcock
2024-09-21 8:09 ` Eli Zaretskii
2024-09-21 9:27 ` Morgan Willcock
2024-09-21 17:35 ` Tassilo Horn
2024-09-22 20:57 ` Morgan Willcock
2024-09-23 6:44 ` Tassilo Horn
2024-09-23 8:34 ` Manuel Giraud via Emacs development discussions.
2024-09-23 8:45 ` Tassilo Horn
2024-09-23 11:34 ` Manuel Giraud via Emacs development discussions.
2024-09-23 11:56 ` Eli Zaretskii
2024-09-23 14:51 ` Tassilo Horn
2024-09-23 15:35 ` Eli Zaretskii
2024-09-23 15:50 ` Morgan Willcock
2024-09-23 16:10 ` Tassilo Horn
2024-09-23 16:27 ` Eli Zaretskii
2024-09-23 16:54 ` Tassilo Horn
2024-09-24 11:17 ` Eli Zaretskii
2024-09-24 11:22 ` Tassilo Horn
2024-09-23 17:56 ` Manuel Giraud via Emacs development discussions.
2024-09-23 18:35 ` Tassilo Horn [this message]
2024-09-23 19:06 ` Manuel Giraud via Emacs development discussions.
2024-09-23 9:36 ` Visuwesh
2024-09-23 11:55 ` Eli Zaretskii
2024-09-23 12:05 ` Tassilo Horn
2024-09-23 15:32 ` Eli Zaretskii
2024-09-21 7:28 ` Tassilo Horn
2024-09-21 9:27 ` Morgan Willcock
2024-09-21 11:04 ` Visuwesh
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87tte6b4ln.fsf@gnu.org \
--to=tsdh@gnu.org \
--cc=eliz@gnu.org \
--cc=emacs-devel@gnu.org \
--cc=manuel@ledu-giraud.fr \
--cc=morgan@ice9.digital \
--cc=visuweshm@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.