From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Sean Whitton Newsgroups: gmane.emacs.devel Subject: Re: master 00149f18ea9: Support modifying VC change comments for Git Date: Wed, 23 Oct 2024 17:47:50 +0800 Message-ID: <87ttd39mm1.fsf@melete.silentflame.com> References: <86r087dvqa.fsf@gnu.org> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="8412"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Cc: emacs-devel@gnu.org, Dmitry Gutov To: Eli Zaretskii Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Wed Oct 23 11:48:37 2024 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1t3Xym-00020H-R9 for ged-emacs-devel@m.gmane-mx.org; Wed, 23 Oct 2024 11:48:37 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1t3XyH-0000iF-ON; Wed, 23 Oct 2024 05:48:05 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1t3XyF-0000h5-BH for emacs-devel@gnu.org; Wed, 23 Oct 2024 05:48:03 -0400 Original-Received: from sendmail.purelymail.com ([34.202.193.197]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1t3XyD-0005kP-PK for emacs-devel@gnu.org; Wed, 23 Oct 2024 05:48:02 -0400 DKIM-Signature: a=rsa-sha256; b=SgEpSmgqJMioy1ZO7b0fxVRkh7/XA2gvMaf05t+2DQG2+GoqrhpZ8yqRkpCZ12Vz8tM39nSR0wbhccASqOyINsaYY0O7ldxuWdH3Ute+J5a5awvFjY1npx0oVaXv2Dnz0uDfs57CCDWIg7SHmA3fKsR6W+yXJVh2sGBgGE7uc8YzCXZzMiMvFwlSY4egdvAKUs+7QbJHenmAYuokVg62YtFQsSrOma+mhUHqRO8M8WdSkFN+HTwijHt94/vHacIDZl+5C9Mna5TgIsR0ayxnoTGEIIWD6oPqTn5YBm+IdVxjg2f2d92FiT6RVzFdaC8IClTw5pVZ2VZ4thnUqKW3dQ==; s=purelymail2; d=spwhitton.name; v=1; bh=W80MhBWqPSF+LAagkk9MMW5BFMmmPSzdju0nftE2AnU=; h=Received:Received:From:To:Subject:Date; DKIM-Signature: a=rsa-sha256; b=xw/NJk3edEHfrxRfCtQjUuV8iwILxjD9CesklxTBrb+QXfMkdn1GJjGLpvaD17QpneASiyKDtlH5jtUYuJHkWqwti7CNL/YSsGB+OXdlArp3l0B2yZ1PB6K0oEAbT4RpfKh7Na+aVvxbiCZcIQ++OI9CVlY7Vv63k1E4+T6deufmH2qfPCF9k615NaBaFZIOZZiSMCnGtnzdfxNEdFEfDxw0xxyPphn+x9i4T84/1B9/6xEneFLkKKMMUlwRHJLQfSHk3UsZJxI4xkN8UP9V3p3D08TWrko1fPsinG1bV/hKM+OH3Ew8wfEeyCEY8/xeTsxH9/oVYHomP9C1HX2z+g==; s=purelymail2; d=purelymail.com; v=1; bh=W80MhBWqPSF+LAagkk9MMW5BFMmmPSzdju0nftE2AnU=; h=Feedback-ID:Received:Received:From:To:Subject:Date; Feedback-ID: 20115:3760:null:purelymail X-Pm-Original-To: emacs-devel@gnu.org Original-Received: by smtp.purelymail.com (Purelymail SMTP) with ESMTPSA id -1191081912; (version=TLSv1.3 cipher=TLS_AES_256_GCM_SHA384); Wed, 23 Oct 2024 09:47:53 +0000 (UTC) Original-Received: by melete.silentflame.com (Postfix, from userid 1000) id A959F7EA4E0; Wed, 23 Oct 2024 17:47:50 +0800 (CST) In-Reply-To: <86r087dvqa.fsf@gnu.org> (Eli Zaretskii's message of "Wed, 23 Oct 2024 12:17:17 +0300") Received-SPF: pass client-ip=34.202.193.197; envelope-from=spwhitton@spwhitton.name; helo=sendmail.purelymail.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_VALIDITY_RPBL_BLOCKED=0.001, RCVD_IN_VALIDITY_SAFE_BLOCKED=0.001, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=unavailable autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.devel:324784 Archived-At: Hello, On Wed 23 Oct 2024 at 12:17pm +03, Eli Zaretskii wrote: > The values of the new option vc-allow-rewriting-published-history > could have their mnemonic value improved (and also become more > consistent with our practices elsewhere), if they were changed as > follows: > > nil (default): don't allow > ask: ask whether to allow > t: allow without asking > > The current values, where t means "ask for confirmation" and 'no-ask' > allows without asking is IMO sub-optimal, because t usually means in > Emacs "do something unconditionally". > > So I suggest to change the values as described above. `ask' is nicer than `no-ask', indeed. I am however keen to steer people towards `ask'. In addition to t often meaning "do something conditionally", it often means "turn this on in the most common way" even if the most common way is not the most permissive way. I would be grateful for more opinions on how this option should look. CCing Dmitry. -- Sean Whitton