From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Ihor Radchenko Newsgroups: gmane.emacs.devel Subject: Re: [PATCH] add compiled regexp primitive lisp object Date: Sun, 22 Dec 2024 20:02:19 +0000 Message-ID: <87ttavlc50.fsf@localhost> References: <87mslxxddk.fsf@protonmail.com> <5He97LtsyeyQoTLU7d91oP2CLO8s_2afdgcNxozsFjzu8qGbB_7nXmsZL5O6Ej7K-tuEmngCcPKJpDAjxeKz4jk1DvqSUbdOLpw5U1vo1SY=@hypnicjerk.ai> <87le1avopk.fsf@protonmail.com> <2LOLmIp1X8w4CGbqq3qDrzmKVA0KzYNL1N9lBtWdB-MtEv9oCuYgJMYprG170wMPjYxeQImAmWOPatGTTl4KxZMlptNo9A9hnHt84vdN9EA=@hypnicjerk.ai> <87ttfxtszi.fsf@protonmail.com> <86r0b1o5sr.fsf@gnu.org> <868qx8o83w.fsf@gnu.org> <875xscec62.fsf@gmail.com> <87o764sb6y.fsf@gmail.com> <87a5cn7cnu.fsf@localhost> <86cyhj5xmc.fsf@gnu.org> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="29278"; mail-complaints-to="usenet@ciao.gmane.io" Cc: monnier@iro.umontreal.ca, mattiase@acm.org, arstoffel@gmail.com, eller.helmut@gmail.com, dmcc2@hypnicjerk.ai, pipcet@protonmail.com, emacs-devel@gnu.org, acorallo@gnu.org, stefankangas@gmail.com To: Eli Zaretskii Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Sun Dec 22 21:01:53 2024 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1tPS9A-0007Tp-US for ged-emacs-devel@m.gmane-mx.org; Sun, 22 Dec 2024 21:01:53 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1tPS8J-0001FF-RL; Sun, 22 Dec 2024 15:00:59 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1tPS8H-0001F7-Ns for emacs-devel@gnu.org; Sun, 22 Dec 2024 15:00:58 -0500 Original-Received: from mout01.posteo.de ([185.67.36.65]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1tPS8B-0002LQ-TY for emacs-devel@gnu.org; Sun, 22 Dec 2024 15:00:55 -0500 Original-Received: from submission (posteo.de [185.67.36.169]) by mout01.posteo.de (Postfix) with ESMTPS id 1BBFE240027 for ; Sun, 22 Dec 2024 21:00:49 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=posteo.net; s=2017; t=1734897649; bh=6PV/ZblxEu5l5m0CnmPE/ac4nKrTpZgPWVrIMTpRmKA=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version:Content-Type: From; b=Fm9hn9SEd/YAGQVXclKliMn6DdCxmArTsQPfa0GG9ajwENIIkRixD6Stqr8EYkhJQ Gk0XAv9VqrJhXxBdDYiIzyV7jTK8M0hiaeij9i80od6Z6M23Ni0dPSqjxB9888jrma uE0J4TLYyA2i5QmPLxW1gs1t4otA9I3DqVSkoMmEJq7XypVunwgPEzJk/1MC3M8FK1 xALNdpqT0XDbiHY8Sidd8+PjwxlA/ja3gsczLdAu/ptFdp6nkOsqR6HJv/7PqJV8U4 uXlwMOaM5+YnF0WXv1CfaROSi70kRpe8KG6GSh/yP9qpJZZSw6faEeKfQO+BY4B5Gt P2L9B1sJi/C3g== Original-Received: from customer (localhost [127.0.0.1]) by submission (posteo.de) with ESMTPSA id 4YGX8H5c1xz6tm8; Sun, 22 Dec 2024 21:00:47 +0100 (CET) In-Reply-To: <86cyhj5xmc.fsf@gnu.org> Received-SPF: pass client-ip=185.67.36.65; envelope-from=yantar92@posteo.net; helo=mout01.posteo.de X-Spam_score_int: -43 X-Spam_score: -4.4 X-Spam_bar: ---- X-Spam_report: (-4.4 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_MED=-2.3, RCVD_IN_MSPIKE_H3=-0.01, RCVD_IN_MSPIKE_WL=-0.01, RCVD_IN_VALIDITY_CERTIFIED_BLOCKED=0.001, RCVD_IN_VALIDITY_RPBL_BLOCKED=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=unavailable autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.devel:326882 Archived-At: Eli Zaretskii writes: >> See https://debbugs.gnu.org/cgi/bugreport.cgi?bug=63225 >> TL;DR: Compiling regexps can take a significant fraction of time when >> parsing Org documents. > > Which fraction? Close to 10%. See the very first message. I just repeated my benchmark using M-: (benchmark-run 1 (org-element-parse-buffer 'object)) on the latest Emacs master (emacs -Q) 17.77% emacs emacs [.] re_match_2_internal 7.98% emacs emacs [.] re_compile_pattern 4.70% emacs emacs [.] re_search_2 4.31% emacs emacs [.] re_iswctype > ... That bug has a lot of numbers, but I couldn't find > any numbers for the percentage of time take by re_compile_pattern and > friends. So I guess your conclusion above was based on indirect > evidence and/or estimations/hunches? Nope, I did similar profiling. The further discussion started from there, discussing about regexp cache, cache misses (that are causing re_compile_pattern to be called frequently), and ways to improve the performance. -- Ihor Radchenko // yantar92, Org mode maintainer, Learn more about Org mode at . Support Org development at , or support my work at