Re: syntax highlight fix for add-log.el

[Lute Kamstra <Lute.Kamstra.lists@xs4all.nl>]

Marcelo Toledo <marcelo@marcelotoledo.org> writes:

> The manual describing a Change Log entry, says: (...) "Aside from
> these header lines, every line in the change log starts with a space
> or a tab.".

Your patch goes only half the way in fixing the problem you describe.
What about this change to fix the rest?

Lute.


Index: lisp/add-log.el
===================================================================
RCS file: /cvsroot/emacs/emacs/lisp/add-log.el,v
retrieving revision 1.158
diff -u -r1.158 add-log.el
--- lisp/add-log.el	4 Apr 2005 08:47:07 -0000	1.158
+++ lisp/add-log.el	4 Apr 2005 10:39:11 -0000
@@ -225,8 +225,8 @@
       (2 'change-log-email-face)))
     ;;
     ;; File names.
-    ("^\\(?: +\\|\t\\)\\* \\([^ ,:([\n]+\\)"
-     (1 'change-log-file-face)
+    ("^\\( +\\|\t\\)\\* \\([^ ,:([\n]+\\)"
+     (2 'change-log-file-face)
      ;; Possibly further names in a list:
      ("\\=, \\([^ ,:([\n]+\\)" nil nil (1 'change-log-file-face))
      ;; Possibly a parenthesized list of names:
@@ -236,8 +236,8 @@
       nil nil (1 'change-log-list-face)))
     ;;
     ;; Function or variable names.
-    ("^\t(\\([^(),\n]+\\|(\\(setf\\|SETF\\) [^() ,\n]+)\\)"
-     (1 'change-log-list-face)
+    ("^\\( +\\|\t\\)(\\([^(),\n]+\\|(\\(setf\\|SETF\\) [^() ,\n]+)\\)"
+     (2 'change-log-list-face)
      ("\\=, *\\([^(),\n]+\\|(\\(setf\\|SETF\\) [^() ,\n]+)\\)" nil nil
       (1 'change-log-list-face)))
     ;;
@@ -250,8 +250,8 @@
     ;; Acknowledgements.
     ;; Don't include plain "From" because that is vague;
     ;; we want to encourage people to say something more specific.
-    ("\\(^\t\\|  \\)\\(Patch\\(es\\)? by\\|Report\\(ed by\\| from\\)\\|Suggest\\(ed by\\|ion from\\)\\)"
-     2 'change-log-acknowledgement-face))
+    ("\\(^\\( +\\|\t\\)\\|  \\)\\(Patch\\(es\\)? by\\|Report\\(ed by\\| from\\)\\|Suggest\\(ed by\\|ion from\\)\\)"
+     3 'change-log-acknowledgement-face))
   "Additional expressions to highlight in Change Log mode.")
 
 (defvar change-log-mode-map