all messages for Emacs-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
* `read-passwd' and the *Messages* buffer
@ 2006-04-11 20:01 Romain Francoise
  0 siblings, 0 replies; only message in thread
From: Romain Francoise @ 2006-04-11 20:01 UTC (permalink / raw)


I find it disturbing that `read-passwd' logs the minibuffer session in
the messages buffer, i.e. if you do

M-: (read-passwd "Password? ") RET

then enter, say, `foo', the messages buffer contains:

Password? 
Password? .
Password? ..
Password? ...

Is this really necessary?  Anyone who happens to see the contents of the
messages buffer then knows the length of my password...

Unless someone objects, I'll install the following patch which binds
`message-log-max' to nil during the prompting, to disable logging.

Index: lisp/subr.el
===================================================================
RCS file: /cvsroot/emacs/emacs/lisp/subr.el,v
retrieving revision 1.502
diff -c -r1.502 subr.el
*** lisp/subr.el	6 Apr 2006 19:20:38 -0000	1.502
--- lisp/subr.el	11 Apr 2006 19:49:55 -0000
***************
*** 1540,1546 ****
        (let ((pass nil)
  	    (c 0)
  	    (echo-keystrokes 0)
! 	    (cursor-in-echo-area t))
  	(add-text-properties 0 (length prompt)
  			     minibuffer-prompt-properties prompt)
  	(while (progn (message "%s%s"
--- 1540,1547 ----
        (let ((pass nil)
  	    (c 0)
  	    (echo-keystrokes 0)
! 	    (cursor-in-echo-area t)
! 	    message-log-max)
  	(add-text-properties 0 (length prompt)
  			     minibuffer-prompt-properties prompt)
  	(while (progn (message "%s%s"

Thanks,

-- 
Romain Francoise <romain@orebokech.com> | The sea! the sea! the open
it's a miracle -- http://orebokech.com/ | sea! The blue, the fresh, the
                                        | ever free! --Bryan W. Procter

^ permalink raw reply	[flat|nested] only message in thread

only message in thread, other threads:[~2006-04-11 20:01 UTC | newest]

Thread overview: (only message) (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2006-04-11 20:01 `read-passwd' and the *Messages* buffer Romain Francoise

Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/emacs.git
	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.