PCL-CVS: "Can not run two cvs processes simultaneously"

PCL-CVS: "Can not run two cvs processes simultaneously"

[Romain Francoise]

[I sent this to Stefan last week but didn't get a reply.]

This change:

2006-07-07  Stefan Monnier  <monnier@iro.umontreal.ca>

	* pcvs-defs.el (cvs-temp-buffer-name): Fix non-hiddenness.

makes it impossible to have more than one asynchronous CVS operation
going on at any given time; trying to run M-x cvs-update or cvs-examine
when one is already running results in a "Can not run two cvs processes
simultaneously" error.  It works fine after reverting this change.

It's probably because the buffer name is now unique-per-Emacs, when it
was unique-per-working-directory before...

-- 
Romain Francoise <romain@orebokech.com> | The sea! the sea! the open
it's a miracle -- http://orebokech.com/ | sea! The blue, the fresh, the
                                        | ever free! --Bryan W. Procter

Re: PCL-CVS: "Can not run two cvs processes simultaneously"

[Romain Francoise]

I'll install the following change unless someone objects:

Index: lisp/pcvs-defs.el
===================================================================
RCS file: /cvsroot/emacs/emacs/lisp/pcvs-defs.el,v
retrieving revision 1.38
diff -c -r1.38 pcvs-defs.el
*** lisp/pcvs-defs.el	7 Jul 2006 15:39:53 -0000	1.38
--- lisp/pcvs-defs.el	1 Aug 2006 16:14:59 -0000
***************
*** 240,248 ****
  the directory name of the cvs buffer.")
  
  (defvar cvs-temp-buffer-name
!   ;; Was '(expand-file-name " *cvs-tmp*" dir), but that causes them to
!   ;; become non-hidden if uniquification is done `forward'.
!   " *cvs-tmp*"
    "*Name of the cvs temporary buffer.
  Output from cvs is placed here for asynchronous commands.")
  
--- 240,253 ----
  the directory name of the cvs buffer.")
  
  (defvar cvs-temp-buffer-name
!   ;; If uniquification is done `forward' the buffer becomes non-hidden,
!   ;; so force a hidden buffer in that case.  Note that having a unique
!   ;; name here prevents concurrent runs of CVS, even in different *cvs*
!   ;; buffers!
!   '(if (and (boundp 'uniquify-buffer-name-style)
! 	    (eq uniquify-buffer-name-style 'forward))
!        " *cvs-tmp*"
!      (expand-file-name " *cvs-tmp*" dir))
    "*Name of the cvs temporary buffer.
  Output from cvs is placed here for asynchronous commands.")

-- 
Romain Francoise <romain@orebokech.com> | The sea! the sea! the open
it's a miracle -- http://orebokech.com/ | sea! The blue, the fresh, the
                                        | ever free! --Bryan W. Procter

Re: PCL-CVS: "Can not run two cvs processes simultaneously"

[Stuart D. Herring]

>   (defvar cvs-temp-buffer-name
> !   ;; If uniquification is done `forward' the buffer becomes non-hidden,
> !   ;; so force a hidden buffer in that case.  Note that having a unique
> !   ;; name here prevents concurrent runs of CVS, even in different *cvs*
> !   ;; buffers!
> !   '(if (and (boundp 'uniquify-buffer-name-style)
> ! 	    (eq uniquify-buffer-name-style 'forward))
> !        " *cvs-tmp*"
> !      (expand-file-name " *cvs-tmp*" dir))
>     "*Name of the cvs temporary buffer.
>   Output from cvs is placed here for asynchronous commands.")

I haven't been following this thread closely, but there has to be a better
way than to just say that forward uniquification loses.  Isn't there a
mechanism to disable uniquification for some buffer?  I see
`uniquify-ignore-buffers-re' at least; perhaps there should also be a way
to disable it via a local variable or so?

Davis

-- 
This product is sold by volume, not by mass.  If it appears too dense or
too sparse, it is because mass-energy conversion has occurred during
shipping.

Re: PCL-CVS: "Can not run two cvs processes simultaneously"

[Romain Francoise]

"Stuart D. Herring" <herring@lanl.gov> writes:

> Isn't there a mechanism to disable uniquification for some buffer?

Why does it uniquify hidden buffers anyway?  Uniquification is useful
for buffers that are visible to the user, and hidden buffers typically
aren't.

(In any case, crippling PCL-CVS for the sake of uniquify isn't really
smart either.)

-- 
Romain Francoise <romain@orebokech.com> | The sea! the sea! the open
it's a miracle -- http://orebokech.com/ | sea! The blue, the fresh, the
                                        | ever free! --Bryan W. Procter