xterm.el

xterm.el

[Johan Bockgård]

This patch fixes some incorrect key definitions and adds a binding for
C-M-SPC.


Also, maybe it would be more useful if the `Alt-foo' bindings (A-up,
A-down, etc) in xterm.el were `Meta-foo'?


Index: lisp/term/xterm.el
===================================================================
RCS file: /cvsroot/emacs/emacs/lisp/term/xterm.el,v
retrieving revision 1.36
diff -u -r1.36 xterm.el
--- lisp/term/xterm.el	21 Jan 2007 03:22:34 -0000	1.36
+++ lisp/term/xterm.el	4 Apr 2007 15:44:00 -0000
@@ -246,7 +246,7 @@
       (define-key map "\e[27;5;49~"  [?\C-1])
       ;; Not all C-DIGIT keys have a distinct binding.
       (define-key map "\e[27;5;57~"  [?\C-9])
-      (define-key map "\e[27;5;59~"  [(C-\;)])
+      (define-key map "\e[27;5;59~"  [?\C-\;])
       (define-key map "\e[27;5;61~"  [?\C-=])
       (define-key map "\e[27;5;92~"  [?\C-\\])
 
@@ -255,7 +255,7 @@
       (define-key map "\e[27;6;35~"  [?\C-#])
       (define-key map "\e[27;6;36~"  [?\C-$])
       (define-key map "\e[27;6;37~"  [?\C-%])
-      (define-key map "\e[27;6;38~"  [(C-&)])
+      (define-key map "\e[27;6;38~"  [?\C-&])
       (define-key map "\e[27;6;40~"  [?\C-(])
       (define-key map "\e[27;6;41~"  [?\C-)])
       (define-key map "\e[27;6;42~"  [?\C-*])
@@ -263,13 +263,13 @@
       (define-key map "\e[27;6;58~"  [?\C-:])
       (define-key map "\e[27;6;60~"  [?\C-<])
       (define-key map "\e[27;6;62~"  [?\C->])
-      (define-key map "\e[27;6;63~"  [(C-\?)])
+      (define-key map "\e[27;6;63~"  [(control ??)])
 
       ;; These are the strings emitted for various C-M- combinations
       ;; for keyboards that the Meta and Alt modifiers are on the same
       ;; key (usually labeled "Alt").
-      (define-key map "\e[27;13;9~"  [(C-M-tab)])
-      (define-key map "\e[27;13;13~" [(C-M-return)])
+      (define-key map "\e[27;13;9~"  [C-M-tab])
+      (define-key map "\e[27;13;13~" [C-M-return])
 
       (define-key map "\e[27;13;39~" [?\C-\M-\'])
       (define-key map "\e[27;13;44~" [?\C-\M-,])
@@ -295,7 +295,7 @@
       (define-key map "\e[27;14;35~"  [?\C-\M-#])
       (define-key map "\e[27;14;36~"  [?\C-\M-$])
       (define-key map "\e[27;14;37~"  [?\C-\M-%])
-      (define-key map "\e[27;14;38~"  [(C-M-&)])
+      (define-key map "\e[27;14;38~"  [?\C-\M-&])
       (define-key map "\e[27;14;40~"  [?\C-\M-(])
       (define-key map "\e[27;14;41~"  [?\C-\M-)])
       (define-key map "\e[27;14;42~"  [?\C-\M-*])
@@ -303,11 +303,12 @@
       (define-key map "\e[27;14;58~"  [?\C-\M-:])
       (define-key map "\e[27;14;60~"  [?\C-\M-<])
       (define-key map "\e[27;14;62~"  [?\C-\M->])
-      (define-key map "\e[27;14;63~"  [(C-M-\?)])
+      (define-key map "\e[27;14;63~"  [(control meta ??)])
 
-      (define-key map "\e[27;7;9~"  [(C-M-tab)])
-      (define-key map "\e[27;7;13~" [(C-M-return)])
+      (define-key map "\e[27;7;9~"  [C-M-tab])
+      (define-key map "\e[27;7;13~" [C-M-return])
 
+      (define-key map "\e[27;7;32~" [?\C-\M-\s])
       (define-key map "\e[27;7;39~" [?\C-\M-\'])
       (define-key map "\e[27;7;44~" [?\C-\M-,])
       (define-key map "\e[27;7;45~" [?\C-\M--])
@@ -332,7 +333,7 @@
       (define-key map "\e[27;8;35~"  [?\C-\M-#])
       (define-key map "\e[27;8;36~"  [?\C-\M-$])
       (define-key map "\e[27;8;37~"  [?\C-\M-%])
-      (define-key map "\e[27;8;38~"  [(C-M-&)])
+      (define-key map "\e[27;8;38~"  [?\C-\M-&])
       (define-key map "\e[27;8;40~"  [?\C-\M-(])
       (define-key map "\e[27;8;41~"  [?\C-\M-)])
       (define-key map "\e[27;8;42~"  [?\C-\M-*])
@@ -340,13 +341,13 @@
       (define-key map "\e[27;8;58~"  [?\C-\M-:])
       (define-key map "\e[27;8;60~"  [?\C-\M-<])
       (define-key map "\e[27;8;62~"  [?\C-\M->])
-      (define-key map "\e[27;8;63~"  [(C-M-\?)])
+      (define-key map "\e[27;8;63~"  [(control meta ??)])
 
       (define-key map "\e[27;2;9~"   [S-tab])
       (define-key map "\e[27;2;13~"  [S-return])
 
-      (define-key map "\e[27;6;9~"   [(C-S-tab)])
-      (define-key map "\e[27;6;13~"  [(C-S-return)])
+      (define-key map "\e[27;6;9~"   [C-S-tab])
+      (define-key map "\e[27;6;13~"  [C-S-return])
 
       ;; Other versions of xterm might emit these.
       (define-key map "\e[A" [up])

Re: xterm.el

[Richard Stallman]

Some of thse lines are written in a way that is
totally incorrect.  I wonder how that happened.

If we convert most of the lists inside the vectors,
why keep them in just three cases?

    +      (define-key map "\e[27;6;63~"  [(control ??)])

    +      (define-key map "\e[27;14;63~"  [(control meta ??)])

    +      (define-key map "\e[27;8;63~"  [(control meta ??)])

Re: xterm.el

[Johan Bockgård]

Richard Stallman <rms@gnu.org> writes:

> If we convert most of the lists inside the vectors, why keep them in
> just three cases?
>
>     +      (define-key map "\e[27;6;63~"  [(control ??)])
>
>     +      (define-key map "\e[27;14;63~"  [(control meta ??)])
>
>     +      (define-key map "\e[27;8;63~"  [(control meta ??)])

(info "(elisp)Ctl-Char Syntax")

    For historical reasons, Emacs treats the <DEL> character as the
    control equivalent of `?':

         ?\^? => 127     ?\C-? => 127

    As a result, it is currently not possible to represent the character
    `Control-?', which is a meaningful input character under X, using
    `\C-'.  It is not easy to change this, as various Lisp files refer to
    <DEL> in this way.

-- 
Johan Bockgård

Re: xterm.el

[Richard Stallman]

    (info "(elisp)Ctl-Char Syntax")

	For historical reasons, Emacs treats the <DEL> character as the
	control equivalent of `?':

	     ?\^? => 127     ?\C-? => 127

	As a result, it is currently not possible to represent the character
	`Control-?', which is a meaningful input character under X, using
	`\C-'.  It is not easy to change this, as various Lisp files refer to
	<DEL> in this way.

Let's add a comment at those places referring to this.

Would someone please install this change?

Re: xterm.el

[Chong Yidong]

Richard Stallman <rms@gnu.org> writes:

> Would someone please install this change?

Done.