From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: storm@cua.dk (Kim F. Storm) Newsgroups: gmane.emacs.devel Subject: Re: A bug in tetris Date: Tue, 21 Aug 2007 10:32:11 +0200 Message-ID: <87sl6dp9tg.fsf@kfs-lx.testafd.dk> References: <7dbe73ed0708190822o5431b2b7m437a1d5073afe55@mail.gmail.com> <87hcmvp3bn.fsf@kfs-lx.testafd.dk> NNTP-Posting-Host: lo.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-Trace: sea.gmane.org 1187685278 17796 80.91.229.12 (21 Aug 2007 08:34:38 GMT) X-Complaints-To: usenet@sea.gmane.org NNTP-Posting-Date: Tue, 21 Aug 2007 08:34:38 +0000 (UTC) Cc: emacs-devel@gnu.org, sdl.web@gmail.com, Kenichi Handa To: rms@gnu.org Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Tue Aug 21 10:34:35 2007 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([199.232.76.165]) by lo.gmane.org with esmtp (Exim 4.50) id 1INPC7-0000Xj-3b for ged-emacs-devel@m.gmane.org; Tue, 21 Aug 2007 10:34:35 +0200 Original-Received: from localhost ([127.0.0.1] helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1INPC6-0004Dq-I7 for ged-emacs-devel@m.gmane.org; Tue, 21 Aug 2007 04:34:34 -0400 Original-Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1INPA7-000289-Ce for emacs-devel@gnu.org; Tue, 21 Aug 2007 04:32:31 -0400 Original-Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1INPA5-00026V-Oy for emacs-devel@gnu.org; Tue, 21 Aug 2007 04:32:30 -0400 Original-Received: from [199.232.76.173] (helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1INPA5-000266-FM for emacs-devel@gnu.org; Tue, 21 Aug 2007 04:32:29 -0400 Original-Received: from mail-relay.sonofon.dk ([212.88.64.25]) by monty-python.gnu.org with smtp (Exim 4.60) (envelope-from ) id 1INPA5-0001JX-2T for emacs-devel@gnu.org; Tue, 21 Aug 2007 04:32:29 -0400 Original-Received: (qmail 41266 invoked from network); 21 Aug 2007 08:32:19 -0000 Original-Received: from unknown (HELO kfs-lx.testafd.dk.cua.dk) (213.83.150.2) by 0 with SMTP; 21 Aug 2007 08:32:19 -0000 In-Reply-To: (Richard Stallman's message of "Mon\, 20 Aug 2007 14\:30\:48 -0400") User-Agent: Gnus/5.11 (Gnus v5.11) Emacs/22.1 (gnu/linux) X-Detected-Kernel: FreeBSD 4.6-4.9 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:76869 Archived-At: Richard Stallman writes: > > Maybe the newlines in the gamegrid must be marked to not increase > > line height by its own: > > > (propertize "\n" 'line-height t) > > Isn't it better to make that the default behaviour if a line > is not empty? > > Did we discuss this question when that feature was added? I don't remember. > Was there any particular reason to handle this the way we did? I answered (vaguely) yesterday, but I now recall the reasoning for not making it standard: In most cases, I would assume that if you put a face (with a smaller line height) on the text on a whole line, you also put that face on the newline if you want the whole line to have the smaller line height. If you leave the default face on the newline, you (probably) want to have the default line spacing for the line even if the text on the line is in a smaller face. So this is the current default behaviour (as it was in 21.x) -- which IMO is correct for normal use cases. In the rare case where a line is in the default face, but only contains (small height) images (e.g. in a game grid or a sliced image) do you get into a case where the height of the newline may get into the way -- that is why I made a special line-height=t property for the newline to handle such unusual cases. The insert-sliced-image function uses this property. Game grid functions should do that too. Conclusion: I think we should keep the current default. -- Kim F. Storm http://www.cua.dk