From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Juri Linkov Newsgroups: gmane.emacs.devel Subject: Re: 23.0.50; Middle w in of permissions in dired-mode is red and bold: dired-warning Date: Sat, 15 Mar 2008 18:20:10 +0200 Organization: JURTA Message-ID: <87skys3qvb.fsf@jurta.org> References: <87hckt9z1u.fsf_-_@jurta.org> <878x0n1g86.fsf@jurta.org> <877ig50vta.fsf@stupidchicken.com> NNTP-Posting-Host: lo.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-Trace: ger.gmane.org 1205598799 21690 80.91.229.12 (15 Mar 2008 16:33:19 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Sat, 15 Mar 2008 16:33:19 +0000 (UTC) Cc: Chong Yidong , emacs-devel@gnu.org To: Eli Zaretskii Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Sat Mar 15 17:33:47 2008 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([199.232.76.165]) by lo.gmane.org with esmtp (Exim 4.50) id 1JaZKN-00037P-0W for ged-emacs-devel@m.gmane.org; Sat, 15 Mar 2008 17:33:47 +0100 Original-Received: from localhost ([127.0.0.1] helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1JaZJn-00020l-L8 for ged-emacs-devel@m.gmane.org; Sat, 15 Mar 2008 12:33:11 -0400 Original-Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1JaZJj-0001z9-DZ for emacs-devel@gnu.org; Sat, 15 Mar 2008 12:33:07 -0400 Original-Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1JaZJh-0001yH-3n for emacs-devel@gnu.org; Sat, 15 Mar 2008 12:33:06 -0400 Original-Received: from [199.232.76.173] (helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1JaZJg-0001yE-UB for emacs-devel@gnu.org; Sat, 15 Mar 2008 12:33:04 -0400 Original-Received: from relay02.kiev.sovam.com ([62.64.120.197]) by monty-python.gnu.org with esmtps (TLS-1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.60) (envelope-from ) id 1JaZJd-0002Rw-7n; Sat, 15 Mar 2008 12:33:01 -0400 Original-Received: from [83.170.232.243] (helo=smtp.svitonline.com) by relay02.kiev.sovam.com with esmtp (Exim 4.67) (envelope-from ) id 1JaZJX-000Mys-TI; Sat, 15 Mar 2008 18:32:58 +0200 In-Reply-To: (Eli Zaretskii's message of "Sat, 15 Mar 2008 16:10:48 +0200") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/23.0.60 (x86_64-pc-linux-gnu) X-Scanner-Signature: 96b5a640d20a32298b7e0b1f479135d9 X-DrWeb-checked: yes X-SpamTest-Envelope-From: juri@jurta.org X-SpamTest-Group-ID: 00000000 X-SpamTest-Header: Not Detected X-SpamTest-Info: Profiles 2421 [Mar 14 2008] X-SpamTest-Info: helo_type=3 X-SpamTest-Info: {HEADERS: header Content-Type found without required header Content-Transfer-Encoding} X-SpamTest-Info: {TO: local part of email appears in body} X-SpamTest-Method: none X-SpamTest-Rate: 20 X-SpamTest-Status: Not detected X-SpamTest-Status-Extended: not_detected X-SpamTest-Version: SMTP-Filter Version 3.0.0 [0255], KAS30/Release X-detected-kernel: by monty-python.gnu.org: FreeBSD 6.x (1) X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:92682 Archived-At: > It's your call, but at this late stage in the pretest, I'd advise > against _any_ changes that are not strictly necessary for a functional > Emacs. Face appearance cannot be an obstacle to Emacs functionality, > IMO, because it's all too easy to customize such a face. But this will require for most users of dired to customize this face immediately after seeing it, and always run Emacs with .emacs that contains this customization. This will be annoying for them. > Now, Martin did his change for a reason, see the log entry above. It > looks like the change on the trunk by Juri simply reversed Martin's > change (modulo face renaming), which means we are now back at the > problem whereby world-writable files will not stand out on 8-color > text terminals. At the very least, we should take care of that > original problem on the trunk. No, your analysis is not correct. This problem began with the following bug report: http://lists.gnu.org/archive/html/bug-gnu-emacs/2007-08/msg00212.html Date: Thu, 30 Aug 2007 10:53:38 +1000 To: bug-gnu-emacs@gnu.org From: trentbuck@gmail.com Subject: dired-warning face not colored on 8-color ttys The `dired-warning' face inherits from font-lock-comment-face. Since Emacs 22, this face is no longer red on eight-color terminals, but rather is the same colour as normal text. This effectively means that the user cannot see warnings. I submit that dired-warning should inherit from font-lock-comment-delimiter-face. Probably this change should be made to a number of other faces that inherit from font-lock-comment-face. My change fixed this original problem by inheriting from font-lock-comment-delimiter-face instead of font-lock-comment-face. So we can say that the original problem is fixed now on the trunk. During the discussion about fixing this problem, it was proposed to try inheriting from font-lock-warning-face. This change was unnecessary to fix the original problem, and was accompanied by numerous doubts: http://lists.gnu.org/archive/html/emacs-devel/2007-09/msg00436.html http://lists.gnu.org/archive/html/emacs-devel/2007-10/msg00756.html After this experimental change was installed, it caused complaints: http://lists.gnu.org/archive/html/emacs-devel/2007-10/msg00724.html Now we have a situation the very opposite to what it has to be: the trunk contains a fix for the reported bug, and the 22 branch contains an experimental incompatible change. I think the most reasonable and safest thing to do now on the branch is to install the original bug fix that changes the parent of the dired-warning face from font-lock-comment-face to font-lock-comment-delimiter-face. -- Juri Linkov http://www.jurta.org/emacs/