From: Juri Linkov <juri@jurta.org>
To: Eli Zaretskii <eliz@gnu.org>
Cc: Chong Yidong <cyd@stupidchicken.com>, emacs-devel@gnu.org
Subject: Re: 23.0.50; Middle w in of permissions in dired-mode is red and bold: dired-warning
Date: Sat, 15 Mar 2008 18:20:10 +0200 [thread overview]
Message-ID: <87skys3qvb.fsf@jurta.org> (raw)
In-Reply-To: <uhcf8hyc7.fsf@gnu.org> (Eli Zaretskii's message of "Sat, 15 Mar 2008 16:10:48 +0200")
> It's your call, but at this late stage in the pretest, I'd advise
> against _any_ changes that are not strictly necessary for a functional
> Emacs. Face appearance cannot be an obstacle to Emacs functionality,
> IMO, because it's all too easy to customize such a face.
But this will require for most users of dired to customize this face
immediately after seeing it, and always run Emacs with .emacs that
contains this customization. This will be annoying for them.
> Now, Martin did his change for a reason, see the log entry above. It
> looks like the change on the trunk by Juri simply reversed Martin's
> change (modulo face renaming), which means we are now back at the
> problem whereby world-writable files will not stand out on 8-color
> text terminals. At the very least, we should take care of that
> original problem on the trunk.
No, your analysis is not correct.
This problem began with the following bug report:
http://lists.gnu.org/archive/html/bug-gnu-emacs/2007-08/msg00212.html
Date: Thu, 30 Aug 2007 10:53:38 +1000
To: bug-gnu-emacs@gnu.org
From: trentbuck@gmail.com
Subject: dired-warning face not colored on 8-color ttys
The `dired-warning' face inherits from font-lock-comment-face. Since
Emacs 22, this face is no longer red on eight-color terminals, but
rather is the same colour as normal text. This effectively means that
the user cannot see warnings.
I submit that dired-warning should inherit from
font-lock-comment-delimiter-face. Probably this change should be made
to a number of other faces that inherit from font-lock-comment-face.
My change fixed this original problem by inheriting from
font-lock-comment-delimiter-face instead of font-lock-comment-face.
So we can say that the original problem is fixed now on the trunk.
During the discussion about fixing this problem, it was proposed to try
inheriting from font-lock-warning-face. This change was unnecessary to
fix the original problem, and was accompanied by numerous doubts:
http://lists.gnu.org/archive/html/emacs-devel/2007-09/msg00436.html
http://lists.gnu.org/archive/html/emacs-devel/2007-10/msg00756.html
After this experimental change was installed, it caused complaints:
http://lists.gnu.org/archive/html/emacs-devel/2007-10/msg00724.html
Now we have a situation the very opposite to what it has to be:
the trunk contains a fix for the reported bug, and the 22 branch
contains an experimental incompatible change.
I think the most reasonable and safest thing to do now on the
branch is to install the original bug fix that changes the
parent of the dired-warning face from font-lock-comment-face
to font-lock-comment-delimiter-face.
--
Juri Linkov
http://www.jurta.org/emacs/
next prev parent reply other threads:[~2008-03-15 16:20 UTC|newest]
Thread overview: 37+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-10-13 18:02 23.0.50; Middle ``w´´ in of permissions in dired-mode is red and bold: dired-warning Peter Dyballa
2007-10-13 18:22 ` 23.0.50; Middle ``wŽŽ " martin rudalics
2007-10-13 18:41 ` Peter Dyballa
2007-10-13 19:44 ` 23.0.50; Middle ``w▌▌ " Glenn Morris
2007-10-13 20:37 ` Re: 23.0.50; Middle ``wŽŽ " Eli Zaretskii
2007-10-13 21:30 ` Peter Dyballa
2007-10-13 23:24 ` Miles Bader
2007-10-14 4:10 ` Eli Zaretskii
2007-10-14 4:03 ` Eli Zaretskii
2007-10-14 5:40 ` Re: 23.0.50; Middle ``wZZ " Drew Adams
2007-10-14 20:24 ` Eli Zaretskii
2007-10-14 20:54 ` Drew Adams
2007-10-14 21:20 ` Eli Zaretskii
2007-10-14 21:21 ` 23.0.50; Middle w " Juri Linkov
2007-10-14 22:20 ` Eli Zaretskii
2008-03-13 2:19 ` Juri Linkov
2008-03-13 4:21 ` Eli Zaretskii
2008-03-13 10:37 ` Juri Linkov
2008-03-13 20:16 ` Eli Zaretskii
2008-03-14 1:07 ` Juri Linkov
[not found] ` <f7ccd24b0803140146m22e5305dy704d7415bc00f8cd@mail.gmail.com>
2008-03-14 8:48 ` Juanma Barranquero
2008-03-14 21:30 ` Juri Linkov
2008-03-14 23:37 ` Juanma Barranquero
2008-03-15 0:17 ` Juri Linkov
2008-03-15 0:26 ` Juanma Barranquero
2008-03-14 12:12 ` Eli Zaretskii
2008-03-14 22:45 ` Chong Yidong
2008-03-15 0:16 ` Juri Linkov
2008-03-15 14:27 ` Eli Zaretskii
2008-03-15 16:20 ` Juri Linkov
2008-03-15 18:30 ` Eli Zaretskii
2008-03-15 14:10 ` Eli Zaretskii
2008-03-15 16:20 ` Juri Linkov [this message]
2008-03-15 20:44 ` Stefan Monnier
2008-03-16 14:26 ` martin rudalics
2008-03-16 16:29 ` Juri Linkov
2007-10-15 0:49 ` 23.0.50; Middle ``wZZ " Stefan Monnier
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87skys3qvb.fsf@jurta.org \
--to=juri@jurta.org \
--cc=cyd@stupidchicken.com \
--cc=eliz@gnu.org \
--cc=emacs-devel@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.