From: Chong Yidong <cyd@stupidchicken.com>
To: Kenichi Handa <handa@m17n.org>
Cc: intrigeri@boum.org, 103@emacsbugs.donarmstrong.com, emacs-devel@gnu.org
Subject: Re: 23.0.60; Segmentation fault loading auto-lang.el
Date: Tue, 08 Apr 2008 12:50:11 -0400 [thread overview]
Message-ID: <87skxwl29o.fsf@stupidchicken.com> (raw)
In-Reply-To: <E1Jj7gx-00039V-Vp@etlken.m17n.org> (Kenichi Handa's message of "Tue, 08 Apr 2008 15:52:27 +0900")
Kenichi Handa <handa@m17n.org> writes:
> In article <87r6dg3oe2.fsf@stupidchicken.com>, Chong Yidong <cyd@stupidchicken.com> writes:
>
>> > - download http://www.marquardt-home.de/auto-lang.el to ~/.elisp/
>> > - run emacs -Q
>> > - M-x load-file
>> > - choose file ~/.elisp/auto-lang.el
>> > => Emacs segfaults (same result with emacs -Q -nw)
>
>> This is due to an infinite nesting depth in regexp-opt, which can be
>> tracked down to the following problem:
>
>> (let ((str (string-as-unibyte "ä")))
>> (string-match (char-to-string (string-to-char str)) str))
>
>> evaluates to 0 in Emacs 22, and to nil in Emacs 23. It turns out that
>> this screws up the use of all-completions in regexp-opt-group.
>
>> Anyone have any idea what's going on here?
>
> (string-as-unibyte "ä") => "\303\244"
> (string-to-char "\303\244") => 195 (because ?\303 == 195)
> (char-to-string 195) => "Ã" (because 195==0xC3 U+00C3=='Ã')
> (string-match "Ã" "ä") => nil (obvious)
>
> Any Lisp program that depends on the result of
> string-as-unibyte (thus Emacs' internal character
> representation) won't work in Emacs 23.
I see. However, maybe the following change to regexp-opt-group in
regexp-opt.el would make things a little more predictable. What do you
think?
*** trunk/lisp/emacs-lisp/regexp-opt.el.~1.37.~ 2008-03-14 17:17:34.000000000 -0400
--- trunk/lisp/emacs-lisp/regexp-opt.el 2008-04-08 12:46:49.000000000 -0400
***************
*** 226,232 ****
;; Otherwise, divide the list into those that start with a
;; particular letter and those that do not, and recurse on them.
! (let* ((char (char-to-string (string-to-char (car strings))))
(half1 (all-completions char strings))
(half2 (nthcdr (length half1) strings)))
(concat open-group
--- 226,232 ----
;; Otherwise, divide the list into those that start with a
;; particular letter and those that do not, and recurse on them.
! (let* ((char (substring (car strings) 0 1))
(half1 (all-completions char strings))
(half2 (nthcdr (length half1) strings)))
(concat open-group
next prev parent reply other threads:[~2008-04-08 16:50 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-04-08 5:29 23.0.60; Segmentation fault loading auto-lang.el Chong Yidong
2008-04-08 6:52 ` Kenichi Handa
2008-04-08 16:50 ` Chong Yidong [this message]
2008-04-09 1:42 ` Stefan Monnier
2008-04-09 2:19 ` Kenichi Handa
-- strict thread matches above, loose matches on Subject: below --
2008-03-30 18:38 intrigeri
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87skxwl29o.fsf@stupidchicken.com \
--to=cyd@stupidchicken.com \
--cc=103@emacsbugs.donarmstrong.com \
--cc=emacs-devel@gnu.org \
--cc=handa@m17n.org \
--cc=intrigeri@boum.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.