* bug#956: In CVS Emacs, replace-regexp doesn't honor inhibit-read-only.
@ 2008-09-10 15:44 Francis Litterio
0 siblings, 0 replies; 4+ messages in thread
From: Francis Litterio @ 2008-09-10 15:44 UTC (permalink / raw
To: bug-gnu-emacs
In CVS Emacs, replace-regexp doesn't honor inhibit-read-only. To
reproduce, evaluate this form:
(let ((inhibit-read-only t))
(with-current-buffer (get-buffer-create "zzz")
(insert "fooxxxbar")
(replace-regexp "x+" "z" nil (point-min) (point-max))))
You will see this error: Buffer is read-only: #<buffer zzz>
This may be caused by this code in function perform-replace (in
lisp/replace.el):
(let ((inhibit-read-only
query-replace-skip-read-only))
The docstring for query-replace-skip-read-only says:
*Non-nil means `query-replace' and friends ignore read-only matches.
which does not seem to match how it is used in that let form, especially
since replace-regexp is not interactive like query-replace.
--
Fran
^ permalink raw reply [flat|nested] 4+ messages in thread
* bug#956: In CVS Emacs, replace-regexp doesn't honor inhibit-read-only.
[not found] <mailman.18916.1221064061.18990.bug-gnu-emacs@gnu.org>
@ 2008-09-11 1:43 ` Francis Litterio
[not found] ` <mailman.18955.1221098864.18990.bug-gnu-emacs@gnu.org>
1 sibling, 0 replies; 4+ messages in thread
From: Francis Litterio @ 2008-09-11 1:43 UTC (permalink / raw
To: 956; +Cc: Chong Yidong
I wrote:
> In CVS Emacs, replace-regexp doesn't honor inhibit-read-only. To
> reproduce, evaluate this form:
>
> (let ((inhibit-read-only t))
> (with-current-buffer (get-buffer-create "zzz")
> (insert "fooxxxbar")
> (replace-regexp "x+" "z" nil (point-min) (point-max))))
Of course, that should have been:
(let ((inhibit-read-only t))
(with-current-buffer (get-buffer-create "zzz")
(toggle-read-only 1) ;; Forgot this in my original report!
(insert "fooxxxbar")
(replace-regexp "x+" "z" nil (point-min) (point-max))))
Chong Yidong wrote:
> Thanks for spotting this. I've checked in a fix.
Thanks!
--
Fran
^ permalink raw reply [flat|nested] 4+ messages in thread
* bug#956: In CVS Emacs, replace-regexp doesn't honor inhibit-read-only.
[not found] ` <mailman.18955.1221098864.18990.bug-gnu-emacs@gnu.org>
@ 2008-09-11 19:33 ` Francis Litterio
2008-09-12 0:43 ` Chong Yidong
0 siblings, 1 reply; 4+ messages in thread
From: Francis Litterio @ 2008-09-11 19:33 UTC (permalink / raw
To: 956; +Cc: Chong Yidong
Francis Litterio wrote:
> I wrote:
>
>> In CVS Emacs, replace-regexp doesn't honor inhibit-read-only. To
>> reproduce, evaluate this form:
> (let ((inhibit-read-only t))
> (with-current-buffer (get-buffer-create "zzz")
>
> (toggle-read-only 1) ;; Forgot this in my original report!
>
> (insert "fooxxxbar")
> (replace-regexp "x+" "z" nil (point-min) (point-max))))
>
> Chong Yidong wrote:
>
>> Thanks for spotting this. I've checked in a fix.
>
> Thanks!
I updated from CVS after seeing your above message, and the bug is still
there. What file did you change?
--
Fran
^ permalink raw reply [flat|nested] 4+ messages in thread
* bug#956: In CVS Emacs, replace-regexp doesn't honor inhibit-read-only.
2008-09-11 19:33 ` Francis Litterio
@ 2008-09-12 0:43 ` Chong Yidong
0 siblings, 0 replies; 4+ messages in thread
From: Chong Yidong @ 2008-09-12 0:43 UTC (permalink / raw
To: Francis Litterio; +Cc: 956
Francis Litterio <flitterio@gmail.com> writes:
> I updated from CVS after seeing your above message, and the bug is still
> there. What file did you change?
I forgot to commit the file itself; please try again.
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2008-09-12 0:43 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
[not found] <mailman.18916.1221064061.18990.bug-gnu-emacs@gnu.org>
2008-09-11 1:43 ` bug#956: In CVS Emacs, replace-regexp doesn't honor inhibit-read-only Francis Litterio
[not found] ` <mailman.18955.1221098864.18990.bug-gnu-emacs@gnu.org>
2008-09-11 19:33 ` Francis Litterio
2008-09-12 0:43 ` Chong Yidong
2008-09-10 15:44 Francis Litterio
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.