From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Chong Yidong Newsgroups: gmane.emacs.devel Subject: Re: patch to fileio.c Date: Thu, 13 Nov 2008 10:43:42 -0500 Message-ID: <87skpv3a35.fsf@cyd.mit.edu> References: <87zlkfe7c2.fsf@cyd.mit.edu> NNTP-Posting-Host: lo.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-Trace: ger.gmane.org 1226591195 26824 80.91.229.12 (13 Nov 2008 15:46:35 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Thu, 13 Nov 2008 15:46:35 +0000 (UTC) To: emacs-devel@gnu.org Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Thu Nov 13 16:47:37 2008 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([199.232.76.165]) by lo.gmane.org with esmtp (Exim 4.50) id 1L0ePw-0006bh-Lr for ged-emacs-devel@m.gmane.org; Thu, 13 Nov 2008 16:47:37 +0100 Original-Received: from localhost ([127.0.0.1]:51313 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1L0eOo-0000mH-Ew for ged-emacs-devel@m.gmane.org; Thu, 13 Nov 2008 10:46:26 -0500 Original-Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1L0eLy-0008GJ-C9 for emacs-devel@gnu.org; Thu, 13 Nov 2008 10:43:30 -0500 Original-Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1L0eLx-0008Fe-1o for emacs-devel@gnu.org; Thu, 13 Nov 2008 10:43:29 -0500 Original-Received: from [199.232.76.173] (port=47238 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1L0eLw-0008FS-SW for emacs-devel@gnu.org; Thu, 13 Nov 2008 10:43:28 -0500 Original-Received: from cyd.mit.edu ([18.115.2.24]:55009) by monty-python.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1L0eLx-0002tB-1a for emacs-devel@gnu.org; Thu, 13 Nov 2008 10:43:29 -0500 Original-Received: by cyd.mit.edu (Postfix, from userid 1000) id 59CF157E09E; Thu, 13 Nov 2008 10:43:42 -0500 (EST) In-Reply-To: (Fabrice Popineau's message of "Fri, 7 Nov 2008 01:17:51 +0100") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/23.0.60 (gnu/linux) X-detected-operating-system: by monty-python.gnu.org: Genre and OS details not recognized. X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:105642 Archived-At: "Fabrice Popineau" writes: > [ I'm posting my answer here too.] > >> Thanks for the patch. Your analysis sounds correct. >> >> However, I would like to test it first. Do you have a recipe for >> demonstrating incorrect specpdl_ptr handling (e.g. a crash)? > > I compiled emacs with msvc, and it crashed all the time under the same > circumstance. Visit a file, modify it outside emacs, and try to > re-visit it. Emacs will detect that it has been modified and will ask > about reloading it. The fd is closed twice because of the > unwind_protect. With msvcrt.dll, the MS C library, this is a > crash. I'm not sure that glibc is that picky. Possibly you won't see > the problem. However, to make sure, and to test the patch, I added > printf() statements at both places where fd can be closed, to trace > what happened. Does anyone else using Windows see this problem?