all messages for Emacs-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
From: Giorgos Keramidas <keramida@ceid.upatras.gr>
To: Dan Nicolaescu <dann@ics.uci.edu>
Cc: emacs-devel@gnu.org
Subject: emacsclient.c build on FreeBSD
Date: Sun, 14 Dec 2008 03:02:12 +0200	[thread overview]
Message-ID: <87skorin6z.fsf@kobe.laptop> (raw)

Hi Dan,

This change:

: 2008-12-10  Dan Nicolaescu  <dann@ics.uci.edu>
:
:         * emacsclient.c (print_help_and_exit): Describe what an empty
:         string argument does for --alternate-editor.
:         (set_socket): Make it possible to not exit in case of an error.
:         (start_daemon_and_retry_set_socket): New function.
:         (main): Use it.  Restore the NULL value for socket_name and
:         server_file after the set_socket call.

needs a small patch to build on FreeBSD/i386:

%%%
diff -r 1d6f7d6431ac lib-src/emacsclient.c
--- a/lib-src/emacsclient.c     Sun Dec 14 02:39:37 2008 +0200
+++ b/lib-src/emacsclient.c     Sun Dec 14 02:58:31 2008 +0200
@@ -42,6 +42,7 @@
 #else /* !WINDOWSNT */

 # include <sys/types.h>
+# include <sys/wait.h>

 # ifdef HAVE_INET_SOCKETS
 #  include <netinet/in.h>
%%%

The WUNTRACED macro referenced by the new code in the patch is defined
in <sys/wait.h> on FreeBSD, and without this include the build of Emacs
fails.  I looked for a HAVE_SYS_WAIT_H macro but couldn't find one.  If
<sys/wait.h> is not available on GNU/Linux we can definitely add a check
in configure.in too :)




             reply	other threads:[~2008-12-14  1:02 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-12-14  1:02 Giorgos Keramidas [this message]
2008-12-14  1:07 ` emacsclient.c build on FreeBSD Giorgos Keramidas
2008-12-14  3:28 ` Dan Nicolaescu
2008-12-14  4:21   ` Giorgos Keramidas

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87skorin6z.fsf@kobe.laptop \
    --to=keramida@ceid.upatras.gr \
    --cc=dann@ics.uci.edu \
    --cc=emacs-devel@gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/emacs.git
	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.