From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Chong Yidong Newsgroups: gmane.emacs.bugs Subject: bug#788: menu indications of key bindings for remapped commands Date: Sun, 15 Mar 2009 21:34:20 -0400 Message-ID: <87skle6yjn.fsf@cyd.mit.edu> References: <871vsy8y4m.fsf@cyd.mit.edu> Reply-To: Chong Yidong , 788@emacsbugs.donarmstrong.com NNTP-Posting-Host: lo.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-Trace: ger.gmane.org 1237167849 17784 80.91.229.12 (16 Mar 2009 01:44:09 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Mon, 16 Mar 2009 01:44:09 +0000 (UTC) Cc: 788@emacsbugs.donarmstrong.com To: Stefan Monnier Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Mon Mar 16 02:45:26 2009 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([199.232.76.165]) by lo.gmane.org with esmtp (Exim 4.50) id 1Lj1tG-0007MM-UO for geb-bug-gnu-emacs@m.gmane.org; Mon, 16 Mar 2009 02:45:19 +0100 Original-Received: from localhost ([127.0.0.1]:58673 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1Lj1ru-0007E8-Nn for geb-bug-gnu-emacs@m.gmane.org; Sun, 15 Mar 2009 21:43:54 -0400 Original-Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1Lj1rp-0007Bg-IN for bug-gnu-emacs@gnu.org; Sun, 15 Mar 2009 21:43:49 -0400 Original-Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1Lj1rl-00075R-0k for bug-gnu-emacs@gnu.org; Sun, 15 Mar 2009 21:43:49 -0400 Original-Received: from [199.232.76.173] (port=45845 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1Lj1rk-00075J-QP for bug-gnu-emacs@gnu.org; Sun, 15 Mar 2009 21:43:44 -0400 Original-Received: from rzlab.ucr.edu ([138.23.92.77]:40383) by monty-python.gnu.org with esmtps (TLS-1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.60) (envelope-from ) id 1Lj1rk-0002H3-90 for bug-gnu-emacs@gnu.org; Sun, 15 Mar 2009 21:43:44 -0400 Original-Received: from rzlab.ucr.edu (rzlab.ucr.edu [127.0.0.1]) by rzlab.ucr.edu (8.13.8/8.13.8/Debian-3) with ESMTP id n2G1hgY5004333; Sun, 15 Mar 2009 18:43:42 -0700 Original-Received: (from debbugs@localhost) by rzlab.ucr.edu (8.13.8/8.13.8/Submit) id n2G1e6SE003424; Sun, 15 Mar 2009 18:40:06 -0700 X-Loop: owner@emacsbugs.donarmstrong.com Resent-From: Chong Yidong Resent-To: bug-submit-list@donarmstrong.com Resent-CC: Emacs Bugs Resent-Date: Mon, 16 Mar 2009 01:40:06 +0000 Resent-Message-ID: Resent-Sender: owner@emacsbugs.donarmstrong.com X-Emacs-PR-Message: followup 788 X-Emacs-PR-Package: emacs X-Emacs-PR-Keywords: Original-Received: via spool by 788-submit@emacsbugs.donarmstrong.com id=B788.12371671831706 (code B ref 788); Mon, 16 Mar 2009 01:40:06 +0000 Original-Received: (at 788) by emacsbugs.donarmstrong.com; 16 Mar 2009 01:33:03 +0000 X-Spam-Bayes: score:0.5 Bayes not run. spammytokens:Tokens not available. hammytokens:Tokens not available. Original-Received: from cyd.mit.edu (CYD.MIT.EDU [18.115.2.24]) by rzlab.ucr.edu (8.13.8/8.13.8/Debian-3) with ESMTP id n2G1X1WC001697 for <788@emacsbugs.donarmstrong.com>; Sun, 15 Mar 2009 18:33:02 -0700 Original-Received: by cyd.mit.edu (Postfix, from userid 1000) id 2309B57E21C; Sun, 15 Mar 2009 21:34:20 -0400 (EDT) In-Reply-To: (Stefan Monnier's message of "Sun, 15 Mar 2009 20:59:39 -0400") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/23.0.60 (gnu/linux) X-detected-operating-system: by monty-python.gnu.org: GNU/Linux 2.6 (newer, 3) Resent-Date: Sun, 15 Mar 2009 21:43:49 -0400 X-BeenThere: bug-gnu-emacs@gnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.bugs:26372 Archived-At: Stefan Monnier writes: >> Ideally, we would follow the remappings, but I think this could mess up >> the menu cache (e.g., if the remapped-to command is rebound). > > What menu cache? AFAIK the keybindings shown in menus are not cached > any more. I meant the where_is_cache, which currently stores such keybindings as [remap foo]. In parse_menu_item, we call Fwhere_is_internal, which consults the cache and gets this result. The cache is consulted because the `firstonly' argument for this call is `t', which causes Fwhere_is_internal to consult the cache; if it's nil, Fwhere_is_internal does not use the cache.