save-excursion defeated by set-buffer

save-excursion defeated by set-buffer

[Thierry Volpiatto]

Hi,
in last CVS version, when i start emacs, i have a compile log writing 
"save-excursion defeated by set-buffer".
The reason is that many package use:

,----
| (save-excursion
|   (set-buffer foo)
|   do something)
`----

instead of using with-current-buffer.

But why the compile buffer show up on start of emacs instead of only
showing the warning when compiling?

-- 
A + Thierry Volpiatto
Location: Saint-Cyr-Sur-Mer - France

Re: save-excursion defeated by set-buffer

[Stefan Monnier]

> But why the compile buffer show up on start of emacs instead of only
> showing the warning when compiling?

I do not know.  Try to

   (require 'bytecomp)
   (debug-on-entry 'byte-compile-form)

early in your .emacs and hope that it catches the cuprit?


        Stefan

Re: save-excursion defeated by set-buffer

[Thierry Volpiatto]

Stefan Monnier <monnier@iro.umontreal.ca> writes:

>> But why the compile buffer show up on start of emacs instead of only
>> showing the warning when compiling?
>
> I do not know.  Try to
>
>    (require 'bytecomp)
>    (debug-on-entry 'byte-compile-form)
>
> early in your .emacs and hope that it catches the cuprit?
Thanks Stefan.

After loading .emacs step by step, i found the problem:
It comes from bbdb.

I have a compile log buffer with:

Warning: `save-excursion' defeated by `set-buffer'.

On startup.

-- 
A + Thierry Volpiatto
Location: Saint-Cyr-Sur-Mer - France

Re: save-excursion defeated by set-buffer

[Thierry Volpiatto]

Thierry Volpiatto <thierry.volpiatto@gmail.com> writes:

> Stefan Monnier <monnier@iro.umontreal.ca> writes:
>
>>> But why the compile buffer show up on start of emacs instead of only
>>> showing the warning when compiling?
>>
>> I do not know.  Try to
>>
>>    (require 'bytecomp)
>>    (debug-on-entry 'byte-compile-form)
>>
>> early in your .emacs and hope that it catches the cuprit?
> Thanks Stefan.
>
> After loading .emacs step by step, i found the problem:
> It comes from bbdb.

More exactly from files bbdb-gui.el, bbdb-com.el.

After replacing all occurence of "(save-excursion (set-buffer foo) ...)"
by "(with-current-buffer foo", all work fine again.

An exception that is a little different: (in bbdb-finger)

,----[ Replace ]
| (save-excursion
|     (with-output-to-temp-buffer bbdb-finger-buffer-name
|          (set-buffer bbdb-finger-buffer-name)
`----

,----[ By ]
| (with-current-buffer (get-buffer-create bbdb-finger-buffer-name)
|   (with-output-to-temp-buffer bbdb-finger-buffer-name
`----
 
> I have a compile log buffer with:
>
> Warning: `save-excursion' defeated by `set-buffer'.
>
> On startup.

-- 
A + Thierry Volpiatto
Location: Saint-Cyr-Sur-Mer - France