From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Thierry Volpiatto Newsgroups: gmane.emacs.devel Subject: Re: Base patch for bug #5975 (bookmarking from Gnus Article buffer). Date: Wed, 14 Jul 2010 10:29:11 +0200 Organization: ThierryVolpiatto Message-ID: <87sk3mbh60.fsf@tux.homenetwork> References: <87y6dydn6q.fsf@tux.homenetwork> <201006292126.15409.tassilo@member.fsf.org> <87iq51ehnv.fsf@tux.homenetwork> <201006292210.43121.tassilo@member.fsf.org> <87eifpegqx.fsf@tux.homenetwork> <87k4ozdq6b.fsf_-_@red-bean.com> <87d3urdppj.fsf@red-bean.com> NNTP-Posting-Host: lo.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-Trace: dough.gmane.org 1279096340 2749 80.91.229.12 (14 Jul 2010 08:32:20 GMT) X-Complaints-To: usenet@dough.gmane.org NNTP-Posting-Date: Wed, 14 Jul 2010 08:32:20 +0000 (UTC) To: emacs-devel@gnu.org Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Wed Jul 14 10:32:19 2010 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([199.232.76.165]) by lo.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1OYxO6-0007RZ-7z for ged-emacs-devel@m.gmane.org; Wed, 14 Jul 2010 10:32:18 +0200 Original-Received: from localhost ([127.0.0.1]:33810 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1OYxO5-0005cs-KE for ged-emacs-devel@m.gmane.org; Wed, 14 Jul 2010 04:32:17 -0400 Original-Received: from [140.186.70.92] (port=58789 helo=eggs.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1OYxNz-0005cn-4h for emacs-devel@gnu.org; Wed, 14 Jul 2010 04:32:12 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.69) (envelope-from ) id 1OYxNx-0007Z1-NO for emacs-devel@gnu.org; Wed, 14 Jul 2010 04:32:11 -0400 Original-Received: from lo.gmane.org ([80.91.229.12]:34146) by eggs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1OYxNx-0007Yv-Gh for emacs-devel@gnu.org; Wed, 14 Jul 2010 04:32:09 -0400 Original-Received: from list by lo.gmane.org with local (Exim 4.69) (envelope-from ) id 1OYxNv-0007Nj-5K for emacs-devel@gnu.org; Wed, 14 Jul 2010 10:32:07 +0200 Original-Received: from 27.77.197-77.rev.gaoland.net ([77.197.77.27]) by main.gmane.org with esmtp (Gmexim 0.1 (Debian)) id 1AlnuQ-0007hv-00 for ; Wed, 14 Jul 2010 10:32:07 +0200 Original-Received: from thierry.volpiatto by 27.77.197-77.rev.gaoland.net with local (Gmexim 0.1 (Debian)) id 1AlnuQ-0007hv-00 for ; Wed, 14 Jul 2010 10:32:07 +0200 X-Injected-Via-Gmane: http://gmane.org/ Original-Lines: 29 Original-X-Complaints-To: usenet@dough.gmane.org X-Gmane-NNTP-Posting-Host: 27.77.197-77.rev.gaoland.net User-Agent: Gnus/5.110011 (No Gnus v0.11) Emacs/24.0.50 (gnu/linux) Cancel-Lock: sha1:ikjXwld1nmd5owIuR89ixCPjyVI= X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6 (newer, 3) X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:127261 Archived-At: Karl Fogel writes: > Karl Fogel writes: >>Just for reference, the current (preparatory) patch is below. I will >>follow up separately with the gnus/* patch, so it's in the archives. > > Here's that patch (still needs the C-w fix referred to in the bug, though). BTW, generally for all contributors patchs: if patch WORK and is basically correct and is accepted of course, why not applying patch as it is and modifying as Emacs developpers like in one or more little other commits. Actually: - contributor send patch - patch is accepted and applyied after modification by Emacs developers. Instead: - Apply contributor patch as it is (if more or less correct and working of course) - Make changes you like in other commits. Like that complete track of what have been done is kept. -- Thierry Volpiatto Get my Gnupg key: gpg --keyserver pgp.mit.edu --recv-keys 59F29997