From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: =?utf-8?Q?=C3=93scar_Fuentes?= Newsgroups: gmane.emacs.devel Subject: Re: rename and clean unexec.c Date: Wed, 28 Jul 2010 22:13:16 +0200 Message-ID: <87sk33pdpf.fsf@telefonica.net> References: <83hbjjcxex.fsf@gnu.org> NNTP-Posting-Host: lo.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-Trace: dough.gmane.org 1280349350 18889 80.91.229.12 (28 Jul 2010 20:35:50 GMT) X-Complaints-To: usenet@dough.gmane.org NNTP-Posting-Date: Wed, 28 Jul 2010 20:35:50 +0000 (UTC) To: emacs-devel@gnu.org Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Wed Jul 28 22:35:47 2010 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([199.232.76.165]) by lo.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1OeDLu-00046E-UR for ged-emacs-devel@m.gmane.org; Wed, 28 Jul 2010 22:35:47 +0200 Original-Received: from localhost ([127.0.0.1]:49603 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1OeD12-0007UM-A7 for ged-emacs-devel@m.gmane.org; Wed, 28 Jul 2010 16:14:12 -0400 Original-Received: from [140.186.70.92] (port=43934 helo=eggs.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1OeD0S-0007NY-3U for emacs-devel@gnu.org; Wed, 28 Jul 2010 16:14:06 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.69) (envelope-from ) id 1OeD0O-00026M-To for emacs-devel@gnu.org; Wed, 28 Jul 2010 16:13:33 -0400 Original-Received: from lo.gmane.org ([80.91.229.12]:34308) by eggs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1OeD0O-00026D-N8 for emacs-devel@gnu.org; Wed, 28 Jul 2010 16:13:32 -0400 Original-Received: from list by lo.gmane.org with local (Exim 4.69) (envelope-from ) id 1OeD0L-00030R-AT for emacs-devel@gnu.org; Wed, 28 Jul 2010 22:13:29 +0200 Original-Received: from 83.42.13.171 ([83.42.13.171]) by main.gmane.org with esmtp (Gmexim 0.1 (Debian)) id 1AlnuQ-0007hv-00 for ; Wed, 28 Jul 2010 22:13:29 +0200 Original-Received: from ofv by 83.42.13.171 with local (Gmexim 0.1 (Debian)) id 1AlnuQ-0007hv-00 for ; Wed, 28 Jul 2010 22:13:29 +0200 X-Injected-Via-Gmane: http://gmane.org/ Original-Lines: 25 Original-X-Complaints-To: usenet@dough.gmane.org X-Gmane-NNTP-Posting-Host: 83.42.13.171 User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.0.50 (gnu/linux) Cancel-Lock: sha1:Ch5JRiMTZ1z5kje3opdWl05ftcE= X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6 (newer, 3) X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:127943 Archived-At: Dan Nicolaescu writes: >> I don't see a need to rename it. Renaming complicates VC forensics, >> even though bzr supports renames. This isn't the only DOS-specific >> file in Emacs that doesn't have "dos" as part of its name. > > By that argument we should never rename anything. > Missing renaming support was one of the main reasons that CVS was abandoned. > This file has a generic name, that's the most of obvious for someone > looking for unexec, but that file is almost always the wrong place to > look. Speaking as someone who is getting familiar with the code base, it is useful to see a hint on the name about its platform-specific nature. I dedicated some time to partition the source files among shared, platform-specific, feature-specific, etc and it could be done a bit faster if they had more informative names. It is nothing terribly important, though. It is like renaming a function or variable with a cryptic name. Helps on some ways and hurts on others. IMHO it is almost always a good thing, as any code cleanup. Putting some comment at the top of the file hurts nobody and helps a lot, though. That practice is already used on several files. [snip]