Re: [PATCH] Add rainbow-mode

[Wojciech Meyer <wojciech.meyer@googlemail.com>]

Lennart Borgman <lennart.borgman@gmail.com> writes:

> 2010/7/30 Ted Zlatanov <tzz@lifelogs.com>:
>> On Tue, 27 Jul 2010 06:44:50 -0700 "Drew Adams" <drew.adams@oracle.com> wrote:
>>
>>>> > I'm glad to present rainbow-mode. This is a minor mode that
>>>> > displays color names with colored background.
>>>>
>>>> There is (since two years) a minor mode, css-color-mode in
>>>> css-color.el written by Niels Giesen...
>>>> See http://bazaar.launchpad.net/~nxhtml/nxhtml/main/files/head:/util/
>>
>> DA> See also: http://www.emacswiki.org/emacs/HexColour.

>>
>> I looked at all of them and rainbow-mode seems to be a superset of their
>> functionality (except for highlighting "blue" in blue, for instance).
>> It's definitely more configurable and smarter about the major mode.  The
>> name may have to change so it's clearer what it does: visual-color.el,
>> perhaps?

I checked this as well, it looks like `rainbow-mode' is mode sensitive
(among other things to consider).

>
> I do not think rainbow-mode has all the functionality in
> css-color-mode (but I only glanced at rainbow-mode so I am not quite
> sure). Are you really sure of this?

I've looked at it too, it has a lot of functionality (including hs[vl]-rgb
conversions). And defines more colours. However it is more heavy weight
and CSS specific.

If I have a right to vote, I would try to include some funcionality from
`css-color-mode' into `rainbow-mode', because of both of them have
potential, and rainbow-mode seems to be more generic...


>
>> I'd like to see it become part of Emacs; it would be useful to me and
>> probably many others.
>>
>> Ted
>>
>>
>>

I think it would be a right thing to do, but also see above.

Just mine two cents.

Wojciech